Evolution-X-Devices/device_google_bramble
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

dumpstate: Include Citadel status in all bugreports

Browse Source 
Gather Citadel's firmware version, uptime stats, and motherboard type in all
bug reports. None of this can be used to identify a specific phone, so it's
safe to run in production builds.

Previously we were running --id and --selftest. Because these could be used
to indentify a specific Citadel chip, we only gathered it on userdebug and
test builds. We used that to isolate problems with early Citadel samples in
prototype phones, which we've done, fixed, and replaced. We don't need that
info anymore.

Bug: 141235263
Test: manual
Change-Id: I6e4d3817fc7f3793956c60f6189ac1ff84b2ae55
Signed-off-by: Bill Richardson <wfrichar@google.com>
This commit is contained in:
Bill Richardson
2020-01-10 17:28:20 -08:00
parent d559305b84
commit ea5ca7374c
1 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
dumpstate/DumpstateDevice.cpp
View File

@@ -494,12 +494,10 @@ Return<void> DumpstateDevice::dumpstateBoard(const hidl_handle& handle) {
dumpModem(fd, fdModem);
}
// Citadel info (only enabled on -eng and -userdebug builds)
if (!PropertiesHelper::IsUserBuild()) {
RunCommandToFd(fd, "Citadel ID", {"/vendor/bin/hw/citadel_updater", "--id"});
RunCommandToFd(fd, "Citadel VER", {"/vendor/bin/hw/citadel_updater", "-lv"});
RunCommandToFd(fd, "Citadel SELFTEST", {"/vendor/bin/hw/citadel_updater", "--selftest"});
}
// Citadel info
RunCommandToFd(fd, "Citadel VERSION", {"/vendor/bin/hw/citadel_updater", "-lv"});
RunCommandToFd(fd, "Citadel STATS", {"/vendor/bin/hw/citadel_updater", "--stats"});
RunCommandToFd(fd, "Citadel BOARDID", {"/vendor/bin/hw/citadel_updater", "--board_id"});
DumpVibrator(fd);