From 85ea759504bfe654c89b785c785e1ca3d708fb29 Mon Sep 17 00:00:00 2001
From: Ruthwar Ambeer <rambeer@codeaurora.org>
Date: Tue, 31 Jul 2018 17:21:32 +0530
Subject: [PATCH] gts4lv: Move AtFwd hal from device to framework manifest.

AtFwd hal is implemented as an android service and
it stars from system partition, that is, it's not
a traditional vendor hal and hence it should be
declared in the framework manifest and not in the
device manifest.
This commit introduces new device specific framework
manifest (framework_manifest.xml) and moves AtFwd hal
from device to framework manifest.

Change-Id: Iacdb5604a682b8462d16297f4b543928bb100282
CRs-Fixed: 2287149
---
 BoardConfig.mk         |  1 +
 framework_manifest.xml | 11 +++++++++++
 manifest.xml           |  9 ---------
 3 files changed, 12 insertions(+), 9 deletions(-)
 create mode 100644 framework_manifest.xml

diff --git a/BoardConfig.mk b/BoardConfig.mk
index 3ed0b83..22ddccf 100644
--- a/BoardConfig.mk
+++ b/BoardConfig.mk
@@ -25,6 +25,7 @@ TARGET_OTA_ASSERT_DEVICE := gts4lv
 TARGET_BOARD_NAME := SRPRL03A001
 
 # HIDL
+DEVICE_FRAMEWORK_MANIFEST_FILE := $(DEVICE_PATH)/framework_manifest.xml
 DEVICE_MANIFEST_FILE += $(DEVICE_PATH)/manifest.xml
 
 # Kernel
diff --git a/framework_manifest.xml b/framework_manifest.xml
new file mode 100644
index 0000000..8ff68ad
--- /dev/null
+++ b/framework_manifest.xml
@@ -0,0 +1,11 @@
+<manifest version="1.0" type="framework">
+    <hal format="hidl">
+        <name>vendor.qti.hardware.radio.atcmdfwd</name>
+        <transport>hwbinder</transport>
+        <version>1.0</version>
+        <interface>
+            <name>IAtCmdFwd</name>
+            <instance>AtCmdFwdService</instance>
+        </interface>
+    </hal>
+</manifest>
diff --git a/manifest.xml b/manifest.xml
index be00d6a..3596d9c 100644
--- a/manifest.xml
+++ b/manifest.xml
@@ -42,13 +42,4 @@
             <instance>imsd</instance>
         </interface>
     </hal>
-    <hal format="hidl">
-        <name>vendor.qti.hardware.radio.atcmdfwd</name>
-        <transport>hwbinder</transport>
-        <version>1.0</version>
-        <interface>
-            <name>IAtCmdFwd</name>
-            <instance>AtCmdFwdService</instance>
-        </interface>
-    </hal>
 </manifest>