From 95d22e6bf2bf6825d80ec607cf2e16dfa9a67efd Mon Sep 17 00:00:00 2001 From: dereference23 Date: Sat, 19 Jul 2025 20:56:53 +0300 Subject: [PATCH] raphael: tfa98xx: Fix PCM device check It should've been && instead of ||, but pcm_open() always returns a valid pointer, so we just drop the NULL check. Change-Id: Ibf1d0b34b02ca5910cd4c1bee4d55a04205e2203 --- tfa98xx/tfa98xx_feedback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tfa98xx/tfa98xx_feedback.c b/tfa98xx/tfa98xx_feedback.c index 49224d7..09303bc 100644 --- a/tfa98xx/tfa98xx_feedback.c +++ b/tfa98xx/tfa98xx_feedback.c @@ -96,7 +96,7 @@ static int amp_set_feedback(amplifier_device_t* device, void* adev, uint32_t snd tfa_dev->tfa98xx_out = pcm_open(tfa_dev->adev->snd_card, pcm_dev_tx_id, PCM_IN, &pcm_config_tfa98xx); - if (tfa_dev->tfa98xx_out && !pcm_is_ready(tfa_dev->tfa98xx_out)) { + if (!pcm_is_ready(tfa_dev->tfa98xx_out)) { ALOGE("%d: %s", __LINE__, pcm_get_error(tfa_dev->tfa98xx_out)); rc = -EIO; goto disable;