From 11aceafac2ea524fd4babc119e228d9611d8eb52 Mon Sep 17 00:00:00 2001 From: David Lin Date: Fri, 26 Jan 2018 16:57:52 -0800 Subject: [PATCH] slimbus: fix issue with unbalanced mutex slimbus.c:1363 slim_config_mgrports() warn: inconsistent returns 'mutex:&ctrl->sched.m_reconf' Bug: 77543262 Change-Id: If3be903db3b7c87f5cac78ba1123339cc2ed5bb4 Signed-off-by: David Lin --- drivers/slimbus/slimbus.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/slimbus/slimbus.c b/drivers/slimbus/slimbus.c index 1140b33cf314..d45958266b8d 100644 --- a/drivers/slimbus/slimbus.c +++ b/drivers/slimbus/slimbus.c @@ -1355,8 +1355,10 @@ int slim_config_mgrports(struct slim_device *sb, u32 *ph, int nports, for (i = 0; i < nports; i++) { u8 pn = SLIM_HDL_TO_PORT(ph[i]); - if (ctrl->ports[pn].state == SLIM_P_CFG) + if (ctrl->ports[pn].state == SLIM_P_CFG) { + mutex_unlock(&ctrl->sched.m_reconf); return -EISCONN; + } ctrl->ports[pn].cfg = *cfg; } mutex_unlock(&ctrl->sched.m_reconf);