Evolution-X-Devices/kernel_google_wahoo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

binder: allow new refs to zombie nodes if other refs exist

Browse Source 
A recent change disallowed new refs to zombie nodes, however
it turns out this is overly restrictive. Change to allow
new refs to zombie nodes if there is at least 1 other ref.

Change-Id: I470dcfcba84c716931a860931af3a61ab9dc8359
Test: verfied fix for gmscore crash loop case
Bug: 36406078
Signed-off-by: Todd Kjos <tkjos@google.com>
This commit is contained in:
Todd Kjos
2017-03-23 14:00:39 -07:00
parent d668aac7f1
commit 3c9f33d6b0
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/android/binder.c
View File

@@ -971,13 +971,13 @@ static struct binder_ref *binder_get_ref_for_node(struct binder_proc *proc,
* to insure a weak ref on the node)
*/
binder_proc_lock(node_proc, __LINE__);
if (node->is_zombie) {
if (node->is_zombie && hlist_empty(&node->refs)) {
/*
* Do not allow new refs to zombie nodes
* Do not allow new refs to unreferenced zombie nodes
*/
binder_proc_unlock(node_proc, __LINE__);
binder_debug(BINDER_DEBUG_INTERNAL_REFS,
"%d attempt to take new ref %d desc %d on zombie node\n",
"%d attempt to take new ref %d desc %d on unreferenced zombie node\n",
proc->pid, new_ref->debug_id, new_ref->desc);
kfree(new_ref);
binder_stats_deleted(BINDER_STAT_REF);