Evolution-X-Devices/kernel_google_wahoo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

binder: read thread sequence number on every iteration when reaping

Browse Source 
Objects are reaped and kfree'd when we know that all threads
that were active when the object became a zombie have left
the kernel. The loop that checks this was reading the active
thread sequence number at the beginning and caching it. However,
if in the 1st iteration there are no threads, it will cache ~0ULL
and all zombies will be reaped even if new ones arrive and need
to be protected. Check the sequence number on each iteration.

Bug: 36220321
Change-Id: I694ff29800cf4ab8d37cb3bb1d5508a525dd88da
Test: tested manually
Signed-off-by: Todd Kjos <tkjos@google.com>
Signed-off-by: Siqi Lin <siqilin@google.com>
This commit is contained in:
Todd Kjos
2017-03-14 17:38:46 -07:00
committed by Thierry Strudel
parent e98c35d65d
commit 7b7c3cb589
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/android/binder.c
View File

@@ -4160,7 +4160,6 @@ static bool binder_proc_clear_zombies(struct binder_proc *proc)
static void binder_clear_zombies(void)
{
struct binder_proc *proc;
u64 thread_seq = binder_get_thread_seq();
struct binder_seq_node *z;
spin_lock(&zombie_procs.lock);
@@ -4171,7 +4170,7 @@ static void binder_clear_zombies(void)
while ((z = list_first_entry_or_null(&zombie_procs.active_threads,
typeof(*z), list_node)) != NULL) {
if (thread_seq < z->active_seq)
if (binder_get_thread_seq() < z->active_seq)
break;
list_del_init(&z->list_node);