Zheyu Ma
1c616528ba
can: peak_pci: peak_pci_remove(): fix UAF
commit 949fe9b35570361bc6ee2652f89a0561b26eec98 upstream.
When remove the module peek_pci, referencing 'chan' again after
releasing 'dev' will cause UAF.
Fix this by releasing 'dev' later.
The following log reveals it:
[ 35.961814 ] BUG: KASAN: use-after-free in peak_pci_remove+0x16f/0x270 [peak_pci]
[ 35.963414 ] Read of size 8 at addr ffff888136998ee8 by task modprobe/5537
[ 35.965513 ] Call Trace:
[ 35.965718 ] dump_stack_lvl+0xa8/0xd1
[ 35.966028 ] print_address_description+0x87/0x3b0
[ 35.966420 ] kasan_report+0x172/0x1c0
[ 35.966725 ] ? peak_pci_remove+0x16f/0x270 [peak_pci]
[ 35.967137 ] ? trace_irq_enable_rcuidle+0x10/0x170
[ 35.967529 ] ? peak_pci_remove+0x16f/0x270 [peak_pci]
[ 35.967945 ] __asan_report_load8_noabort+0x14/0x20
[ 35.968346 ] peak_pci_remove+0x16f/0x270 [peak_pci]
[ 35.968752 ] pci_device_remove+0xa9/0x250
Fixes: e6d9c80b7c ("can: peak_pci: add support of some new PEAK-System PCI cards")
Link: https://lore.kernel.org/all/1634192913-15639-1-git-send-email-zheyuma97@gmail.com
Cc: stable@vger.kernel.org
Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-27 09:32:39 +02:00
..
2021-03-30 14:45:00 +02:00
2018-03-28 18:40:16 +02:00
2021-03-30 14:45:00 +02:00
2020-01-14 20:03:03 +01:00
2021-10-27 09:32:39 +02:00
2020-12-29 13:42:33 +01:00
2019-10-17 13:40:53 -07:00
2021-10-27 09:32:39 +02:00
2016-08-10 11:49:28 +02:00
2015-11-23 09:37:38 +01:00
2021-03-30 14:45:01 +02:00
2021-04-10 13:01:58 +02:00
2015-07-15 09:04:27 +02:00
2015-11-23 09:37:38 +01:00
2015-09-17 22:39:08 +02:00
2015-03-22 23:50:11 +01:00
2015-09-17 22:39:08 +02:00
2015-11-23 09:37:34 +01:00
2021-10-27 09:32:39 +02:00
2020-06-11 09:21:38 +02:00
2017-11-15 17:13:13 +01:00
2017-12-16 10:33:47 +01:00
2015-07-12 21:13:22 +02:00
2018-07-28 07:45:04 +02:00