Ye Bin
e245b6ccaa
PM: hibernate: Get block device exclusively in swsusp_check()
[ Upstream commit 39fbef4b0f77f9c89c8f014749ca533643a37c9f ]
The following kernel crash can be triggered:
[ 89.266592] ------------[ cut here ]------------
[ 89.267427] kernel BUG at fs/buffer.c:3020!
[ 89.268264] invalid opcode: 0000 [#1] SMP KASAN PTI
[ 89.269116] CPU: 7 PID: 1750 Comm: kmmpd-loop0 Not tainted 5.10.0-862.14.0.6.x86_64-08610-gc932cda3cef4-dirty #20
[ 89.273169] RIP: 0010:submit_bh_wbc.isra.0+0x538/0x6d0
[ 89.277157] RSP: 0018:ffff888105ddfd08 EFLAGS: 00010246
[ 89.278093] RAX: 0000000000000005 RBX: ffff888124231498 RCX: ffffffffb2772612
[ 89.279332] RDX: 1ffff11024846293 RSI: 0000000000000008 RDI: ffff888124231498
[ 89.280591] RBP: ffff8881248cc000 R08: 0000000000000001 R09: ffffed1024846294
[ 89.281851] R10: ffff88812423149f R11: ffffed1024846293 R12: 0000000000003800
[ 89.283095] R13: 0000000000000001 R14: 0000000000000000 R15: ffff8881161f7000
[ 89.284342] FS: 0000000000000000(0000) GS:ffff88839b5c0000(0000) knlGS:0000000000000000
[ 89.285711] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 89.286701] CR2: 00007f166ebc01a0 CR3: 0000000435c0e000 CR4: 00000000000006e0
[ 89.287919] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[ 89.289138] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
[ 89.290368] Call Trace:
[ 89.290842] write_mmp_block+0x2ca/0x510
[ 89.292218] kmmpd+0x433/0x9a0
[ 89.294902] kthread+0x2dd/0x3e0
[ 89.296268] ret_from_fork+0x22/0x30
[ 89.296906] Modules linked in:
by running the following commands:
1. mkfs.ext4 -O mmp /dev/sda -b 1024
2. mount /dev/sda /home/test
3. echo "/dev/sda" > /sys/power/resume
That happens because swsusp_check() calls set_blocksize() on the
target partition which confuses the file system:
Thread1 Thread2
mount /dev/sda /home/test
get s_mmp_bh --> has mapped flag
start kmmpd thread
echo "/dev/sda" > /sys/power/resume
resume_store
software_resume
swsusp_check
set_blocksize
truncate_inode_pages_range
truncate_cleanup_page
block_invalidatepage
discard_buffer --> clean mapped flag
write_mmp_block
submit_bh
submit_bh_wbc
BUG_ON(!buffer_mapped(bh))
To address this issue, modify swsusp_check() to open the target block
device with exclusive access.
Signed-off-by: Ye Bin <yebin10@huawei.com>
[ rjw: Subject and changelog edits ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2021-11-26 11:58:38 +01:00
..
2020-05-10 10:26:19 +02:00
2016-09-24 10:07:42 +02:00
2021-03-03 16:44:15 +01:00
2021-06-16 11:34:53 +02:00
2020-09-23 08:44:26 +02:00
2021-03-24 10:57:01 +01:00
2015-11-11 17:36:04 +01:00
2021-08-10 17:39:42 +02:00
2021-11-26 11:58:38 +01:00
2021-11-12 13:17:07 +01:00
2019-06-11 12:24:04 +02:00
2021-07-28 09:12:34 +02:00
2020-11-18 18:25:02 +01:00
2021-10-27 09:32:40 +02:00
2015-10-21 15:18:35 +01:00
2018-01-10 09:27:08 +01:00
2018-02-16 20:09:45 +01:00
2015-08-06 16:14:53 -04:00
2015-11-04 08:23:51 -05:00
2020-10-01 11:11:52 +02:00
2020-05-02 17:20:48 +02:00
2015-11-04 08:23:51 -05:00
2020-03-11 07:51:13 +01:00
2019-11-28 18:26:01 +01:00
2018-11-21 09:27:35 +01:00
2017-01-06 11:16:14 +01:00
2015-12-03 10:18:21 -05:00
2019-12-21 10:35:24 +01:00
2021-06-16 11:34:53 +02:00
2015-06-04 23:57:18 +02:00
2015-11-10 12:06:23 +01:00
2020-06-20 10:23:24 +02:00
2019-07-10 09:56:36 +02:00
2017-10-12 11:27:35 +02:00
2019-08-04 09:35:01 +02:00
2021-02-03 23:16:16 +01:00
2017-07-21 07:44:56 +02:00
2021-02-03 23:16:16 +01:00
2021-08-10 17:39:42 +02:00
2018-01-10 09:27:10 +01:00
2019-02-20 10:13:14 +01:00
2015-11-23 09:44:58 +01:00
2017-12-16 10:33:55 +01:00
2016-02-25 12:01:16 -08:00
2015-11-06 17:50:42 -08:00
2021-05-22 10:38:28 +02:00
2015-09-10 13:29:01 -07:00
2015-11-06 17:50:42 -08:00
2020-10-14 09:46:22 +02:00
2021-02-10 09:07:27 +01:00
2015-09-10 13:29:01 -07:00
2018-09-09 20:04:34 +02:00
2021-02-10 09:07:27 +01:00
2017-03-12 06:37:26 +01:00
2019-01-13 10:05:32 +01:00
2015-10-21 15:18:36 +01:00
2021-03-03 16:44:23 +01:00
2020-04-02 19:02:31 +02:00
2020-05-27 16:40:27 +02:00
2019-10-17 13:40:58 -07:00
2015-11-09 15:53:39 -08:00
2019-08-04 09:34:42 +02:00
2018-04-13 19:50:03 +02:00
2021-09-26 13:33:46 +02:00
2021-05-26 11:27:32 +02:00
2020-11-18 18:25:04 +01:00
2018-05-30 07:49:00 +02:00
2018-04-24 09:32:05 +02:00
2018-07-25 10:18:27 +02:00
2021-11-26 11:58:36 +01:00
2015-11-06 17:50:42 -08:00
2015-10-20 10:23:55 +02:00
2015-12-12 10:15:34 -08:00
2015-11-05 19:34:48 -08:00
2021-09-26 13:33:46 +02:00
2016-04-12 09:08:58 -07:00
2020-07-09 09:35:08 +02:00
2015-09-05 13:46:58 -07:00
2020-01-12 11:22:40 +01:00
2015-10-06 11:25:01 -07:00
2021-03-03 16:44:19 +01:00
2018-01-10 09:27:10 +01:00
2018-09-09 20:04:35 +02:00
2018-09-09 20:04:35 +02:00
2017-01-06 11:16:16 +01:00
2017-11-15 17:13:11 +01:00
2021-08-04 11:56:44 +02:00