Linus Lüssing 44bc7d1b97 net: fix bridge multicast packet checksum validation ...

[ Upstream commit 9b368814b336b0a1a479135eb2815edbc00efd3c ]

We need to update the skb->csum after pulling the skb, otherwise
an unnecessary checksum (re)computation can ocure for IGMP/MLD packets
in the bridge code. Additionally this fixes the following splats for
network devices / bridge ports with support for and enabled RX checksum
offloading:

[...]
[   43.986968] eth0: hw csum failure
[   43.990344] CPU: 3 PID: 0 Comm: swapper/3 Not tainted 4.4.0 #2
[   43.996193] Hardware name: BCM2709
[   43.999647] [<800204e0>] (unwind_backtrace) from [<8001cf14>] (show_stack+0x10/0x14)
[   44.007432] [<8001cf14>] (show_stack) from [<801ab614>] (dump_stack+0x80/0x90)
[   44.014695] [<801ab614>] (dump_stack) from [<802e4548>] (__skb_checksum_complete+0x6c/0xac)
[   44.023090] [<802e4548>] (__skb_checksum_complete) from [<803a055c>] (ipv6_mc_validate_checksum+0x104/0x178)
[   44.032959] [<803a055c>] (ipv6_mc_validate_checksum) from [<802e111c>] (skb_checksum_trimmed+0x130/0x188)
[   44.042565] [<802e111c>] (skb_checksum_trimmed) from [<803a06e8>] (ipv6_mc_check_mld+0x118/0x338)
[   44.051501] [<803a06e8>] (ipv6_mc_check_mld) from [<803b2c98>] (br_multicast_rcv+0x5dc/0xd00)
[   44.060077] [<803b2c98>] (br_multicast_rcv) from [<803aa510>] (br_handle_frame_finish+0xac/0x51c)
[...]

Fixes: 9afd85c9e4 ("net: Export IGMP/MLD message validation code")
Reported-by: Álvaro Fernández Rojas <noltari@gmail.com>
Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2016-04-20 15:41:58 +09:00

..

datagram.c

net: rename SOCK_ASYNC_NOSPACE and SOCK_ASYNC_WAITDATA

2015-12-01 15:45:05 -05:00

dev_addr_lists.c

net: fix spelling for synchronized

2014-11-18 15:26:32 -05:00

dev_ioctl.c

dev_ioctl: use sizeof(x) instead of sizeof x

2014-11-18 15:27:32 -05:00

dev.c

IFF_NO_QUEUE: Fix for drivers not calling ether_setup()

2016-03-03 15:07:07 -08:00

drop_monitor.c

net: Replace get_cpu_var through this_cpu_ptr

2014-08-26 13:45:47 -04:00

dst.c

net: possible use after free in dst_release

2016-01-06 15:00:27 -05:00

ethtool.c

ethtool: Use kcalloc instead of kmalloc for ethtool_get_strings

2015-10-14 19:00:20 -07:00

fib_rules.c

fib_rules: fix fib rule dumps across multiple skbs

2015-09-24 15:21:54 -07:00

filter.c

net: bpf: reject invalid shifts

2016-01-31 11:29:01 -08:00

flow_dissector.c

flow_dissector: Fix unaligned access in __skb_flow_dissector when used by eth_get_headlen

2016-03-03 15:07:06 -08:00

flow.c

flow: Move __get_hash_from_flowi{4,6} into flow_dissector.c

2015-09-01 17:00:24 -07:00

gen_estimator.c

net_sched: gen_estimator: extend pps limit

2015-07-08 13:59:20 -07:00

gen_stats.c

gen_stats.c: Duplicate xstats buffer for later use

2015-02-19 15:45:53 -05:00

link_watch.c

dev: introduce dev_get_iflink()

2015-04-02 14:04:59 -04:00

lwtunnel.c

dst: Pass net into dst->output

2015-10-08 04:27:03 -07:00

Makefile

lwtunnel: infrastructure for handling light weight tunnels like mpls

2015-07-21 10:39:03 -07:00

neighbour.c

net/neighbour: fix crash at dumping device-agnostic proxy entries

2015-12-03 00:07:51 -05:00

net_namespace.c

netns: make nsid_lock per net

2015-05-17 23:41:11 -04:00

net-procfs.c

rps: selective flow shedding during softnet overflow

2013-05-20 13:48:04 -07:00

net-sysfs.c

switchdev: rename SWITCHDEV_ATTR_* enum values to SWITCHDEV_ATTR_ID_*

2015-10-03 04:49:37 -07:00

net-sysfs.h

net: netdev_kobject_init: annotate with __init

2014-01-05 20:27:54 -05:00

net-traces.c

net: FIB tracepoints

2015-08-29 13:05:16 -07:00

netclassid_cgroup.c

Merge branch 'master' into for-4.4-fixes

2015-12-07 10:09:03 -05:00

netevent.c

netevent: remove automatic variable in register_netevent_notifier()

2015-05-31 00:03:21 -07:00

netpoll.c

netpoll: Drop budget parameter from NAPI polling call hierarchy

2015-09-29 14:57:16 -07:00

netprio_cgroup.c

cgroup: fix handling of multi-destination migration from subtree_control enabling

2015-12-03 10:18:21 -05:00

pktgen.c

net: pktgen: fix null ptr deref in skb allocation

2016-01-31 11:29:00 -08:00

ptp_classifier.c

ptp: Change ptp_class to a proper bitmask

2015-11-03 11:08:22 -05:00

request_sock.c

tcp: restore fastopen operations

2015-10-05 03:19:06 -07:00

rtnetlink.c

rtnetlink: fix frame size warning in rtnl_fill_ifinfo

2015-11-17 15:25:44 -05:00

scm.c

unix: correctly track in-flight fds in sending process user_struct

2016-03-03 15:07:05 -08:00

secure_seq.c

net: remove a sparse error in secure_dccpv6_sequence_number()

2015-05-25 22:55:37 -04:00

skbuff.c

net: fix bridge multicast packet checksum validation

2016-04-20 15:41:58 +09:00

sock_diag.c

net/core: make sock_diag.c explicitly non-modular

2015-10-09 07:52:27 -07:00

sock.c

net: check both type and procotol for tcp sockets

2015-12-17 15:46:32 -05:00

stream.c

net: fix sock_wake_async() rcu protection

2015-12-01 15:45:05 -05:00

sysctl_net_core.c

net:Add sysctl_max_skb_frags

2016-03-03 15:07:05 -08:00

timestamping.c

net: skb_defer_rx_timestamp should check for phydev before setting up classify

2015-07-09 14:17:15 -07:00

tso.c

net: tso: add support for IPv6

2015-10-26 22:24:22 -07:00

utils.c

net: move net_get_random_once to lib

2015-10-08 05:26:35 -07:00