Daniel Bristot de Oliveira
e61d484a2d
cgroup: Disable IRQs while holding css_set_lock
While testing the deadline scheduler + cgroup setup I hit this
warning.
[ 132.612935] ------------[ cut here ]------------
[ 132.612951] WARNING: CPU: 5 PID: 0 at kernel/softirq.c:150 __local_bh_enable_ip+0x6b/0x80
[ 132.612952] Modules linked in: (a ton of modules...)
[ 132.612981] CPU: 5 PID: 0 Comm: swapper/5 Not tainted 4.7.0-rc2 #2
[ 132.612981] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.8.2-20150714_191134- 04/01/2014
[ 132.612982] 0000000000000086 45c8bb5effdd088b ffff88013fd43da0 ffffffff813d229e
[ 132.612984] 0000000000000000 0000000000000000 ffff88013fd43de0 ffffffff810a652b
[ 132.612985] 00000096811387b5 0000000000000200 ffff8800bab29d80 ffff880034c54c00
[ 132.612986] Call Trace:
[ 132.612987] <IRQ> [<ffffffff813d229e>] dump_stack+0x63/0x85
[ 132.612994] [<ffffffff810a652b>] __warn+0xcb/0xf0
[ 132.612997] [<ffffffff810e76a0>] ? push_dl_task.part.32+0x170/0x170
[ 132.612999] [<ffffffff810a665d>] warn_slowpath_null+0x1d/0x20
[ 132.613000] [<ffffffff810aba5b>] __local_bh_enable_ip+0x6b/0x80
[ 132.613008] [<ffffffff817d6c8a>] _raw_write_unlock_bh+0x1a/0x20
[ 132.613010] [<ffffffff817d6c9e>] _raw_spin_unlock_bh+0xe/0x10
[ 132.613015] [<ffffffff811388ac>] put_css_set+0x5c/0x60
[ 132.613016] [<ffffffff8113dc7f>] cgroup_free+0x7f/0xa0
[ 132.613017] [<ffffffff810a3912>] __put_task_struct+0x42/0x140
[ 132.613018] [<ffffffff810e776a>] dl_task_timer+0xca/0x250
[ 132.613027] [<ffffffff810e76a0>] ? push_dl_task.part.32+0x170/0x170
[ 132.613030] [<ffffffff8111371e>] __hrtimer_run_queues+0xee/0x270
[ 132.613031] [<ffffffff81113ec8>] hrtimer_interrupt+0xa8/0x190
[ 132.613034] [<ffffffff81051a58>] local_apic_timer_interrupt+0x38/0x60
[ 132.613035] [<ffffffff817d9b0d>] smp_apic_timer_interrupt+0x3d/0x50
[ 132.613037] [<ffffffff817d7c5c>] apic_timer_interrupt+0x8c/0xa0
[ 132.613038] <EOI> [<ffffffff81063466>] ? native_safe_halt+0x6/0x10
[ 132.613043] [<ffffffff81037a4e>] default_idle+0x1e/0xd0
[ 132.613044] [<ffffffff810381cf>] arch_cpu_idle+0xf/0x20
[ 132.613046] [<ffffffff810e8fda>] default_idle_call+0x2a/0x40
[ 132.613047] [<ffffffff810e92d7>] cpu_startup_entry+0x2e7/0x340
[ 132.613048] [<ffffffff81050235>] start_secondary+0x155/0x190
[ 132.613049] ---[ end trace f91934d162ce9977 ]---
The warn is the spin_(lock|unlock)_bh(&css_set_lock) in the interrupt
context. Converting the spin_lock_bh to spin_lock_irq(save) to avoid
this problem - and other problems of sharing a spinlock with an
interrupt.
Cc: Tejun Heo <tj@kernel.org>
Cc: Li Zefan <lizefan@huawei.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Juri Lelli <juri.lelli@arm.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: cgroups@vger.kernel.org
Cc: stable@vger.kernel.org # 4.5+
Cc: linux-kernel@vger.kernel.org
Reviewed-by: Rik van Riel <riel@redhat.com>
Reviewed-by: "Luis Claudio R. Goncalves" <lgoncalv@redhat.com>
Signed-off-by: Daniel Bristot de Oliveira <bristot@redhat.com>
Acked-by: Zefan Li <lizefan@huawei.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Chatur27 <jasonbright2709@gmail.com>
2022-03-04 20:16:58 +01:00
..
2022-03-04 20:16:56 +01:00
2018-02-05 08:58:36 -08:00
2021-07-24 19:19:07 +03:00
2022-03-04 20:16:56 +01:00
2020-09-23 08:44:26 +02:00
2021-07-24 19:24:49 +03:00
2021-09-02 00:24:42 +03:00
2022-02-09 19:41:39 +02:00
2021-12-27 01:16:43 +02:00
2019-11-01 12:32:03 +08:00
2022-03-04 20:16:48 +01:00
2021-12-27 01:17:29 +02:00
2022-03-04 20:16:56 +01:00
2018-01-10 09:27:08 +01:00
2018-02-16 20:09:45 +01:00
2020-10-01 11:11:52 +02:00
2020-05-02 08:44:27 -07:00
2020-03-11 07:51:13 +01:00
2019-12-17 13:28:23 +08:00
2018-11-21 09:27:35 +01:00
2022-03-04 20:16:43 +01:00
2022-03-04 20:16:43 +01:00
2022-03-04 20:16:58 +01:00
2020-06-22 11:21:01 -07:00
2019-11-01 12:32:03 +08:00
2022-03-04 20:16:48 +01:00
2019-08-04 09:35:01 +02:00
2021-08-12 03:09:18 +03:00
2017-07-21 07:44:56 +02:00
2022-03-04 20:16:44 +01:00
2021-09-02 00:24:42 +03:00
2018-01-10 09:27:10 +01:00
2019-02-20 10:13:14 +01:00
2018-02-23 10:03:32 -08:00
2018-05-15 17:49:01 -07:00
2021-05-22 10:38:28 +02:00
2020-10-14 09:46:22 +02:00
2021-12-08 08:44:07 +01:00
2018-09-10 16:56:36 -07:00
2021-07-24 19:18:51 +03:00
2019-01-13 10:05:32 +01:00
2021-07-24 19:19:07 +03:00
2020-04-02 19:02:31 +02:00
2022-03-04 20:16:44 +01:00
2020-05-27 16:40:27 +02:00
2019-11-22 15:15:55 +08:00
2022-03-04 20:16:49 +01:00
2021-01-05 15:58:33 +00:00
2021-09-26 13:33:46 +02:00
2021-05-26 11:27:32 +02:00
2020-11-18 18:25:04 +01:00
2018-05-30 07:49:00 +02:00
2018-07-28 05:10:11 -07:00
2019-03-04 18:14:43 -08:00
2021-11-26 11:58:36 +01:00
2017-12-14 08:26:37 -08:00
2021-10-12 00:11:01 +03:00
2022-03-04 20:16:33 +01:00
2020-01-12 11:22:40 +01:00
2021-03-03 16:44:19 +01:00
2018-01-10 09:27:10 +01:00
2022-03-04 20:16:49 +01:00
2021-08-05 14:15:08 +03:00
2018-09-09 20:04:35 +02:00
2022-03-04 20:16:49 +01:00
2017-11-15 17:13:11 +01:00
2021-08-05 14:01:54 +03:00