Michael Ellerman 0bd585eb40
powerpc/4xx: Fix build errors from mfdcr() ...
[ Upstream commit eead089311f4d935ab5d1d8fbb0c42ad44699ada ]
lkp reported a build error in fsp2.o:
CC arch/powerpc/platforms/44x/fsp2.o
{standard input}:577: Error: unsupported relocation against base
Which comes from:
pr_err("GESR0: 0x%08x\n", mfdcr(base + PLB4OPB_GESR0));
Where our mfdcr() macro is stringifying "base + PLB4OPB_GESR0", and
passing that to the assembler, which obviously doesn't work.
The mfdcr() macro already checks that the argument is constant using
__builtin_constant_p(), and if not calls the out-of-line version of
mfdcr(). But in this case GCC is smart enough to notice that "base +
PLB4OPB_GESR0" will be constant, even though it's not something we can
immediately stringify into a register number.
Segher pointed out that passing the register number to the inline asm
as a constant would be better, and in fact it fixes the build error,
presumably because it gives GCC a chance to resolve the value.
While we're at it, change mtdcr() similarly.
Reported-by: kernel test robot <lkp@intel.com >
Suggested-by: Segher Boessenkool <segher@kernel.crashing.org >
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au >
Acked-by: Feng Tang <feng.tang@intel.com >
Link: https://lore.kernel.org/r/20210218123058.748882-1-mpe@ellerman.id.au
Signed-off-by: Sasha Levin <sashal@kernel.org >
2021-03-30 14:44:58 +02:00
2020-11-22 09:56:58 +01:00
2020-01-29 10:21:35 +01:00
2015-02-20 15:19:43 -05:00
2019-11-28 18:26:29 +01:00
2017-07-27 15:06:04 -07:00
2019-05-16 19:44:49 +02:00
2014-11-12 16:31:46 +11:00
2012-10-09 09:47:26 +01:00
2013-08-14 14:57:40 +10:00
2014-09-25 23:14:43 +10:00
2015-10-21 20:50:30 +11:00
2015-08-07 22:59:20 -05:00
2015-08-07 22:59:19 -05:00
2016-01-31 11:29:03 -08:00
2019-05-16 19:44:49 +02:00
2021-03-17 16:07:23 +01:00
2015-07-29 11:56:13 +10:00
2014-04-23 10:05:16 +10:00
2014-10-08 20:15:37 +11:00
2014-06-11 17:03:28 +10:00
2014-12-15 10:46:40 +11:00
2020-12-29 13:42:36 +01:00
2015-05-22 15:12:30 +10:00
2014-10-15 07:48:18 +02:00
2015-03-23 14:29:40 +11:00
2013-01-10 15:09:06 +11:00
2014-05-23 08:28:02 +09:00
2021-03-30 14:44:58 +02:00
2014-05-20 10:54:06 +10:00
2015-07-13 10:10:54 +10:00
2015-10-15 15:58:16 +11:00
2015-09-10 13:29:01 -07:00
2013-04-18 13:03:53 +10:00
2015-05-28 15:31:53 +02:00
2014-06-11 17:04:33 +10:00
2016-02-25 12:01:18 -08:00
2012-02-14 14:06:50 -07:00
2017-07-21 07:44:57 +02:00
2014-04-09 12:53:28 +10:00
2019-03-23 08:44:21 +01:00
2018-02-16 20:09:34 +01:00
2020-11-22 09:56:57 +01:00
2012-03-28 18:30:02 +01:00
2018-09-09 20:04:32 +02:00
2020-11-22 09:56:58 +01:00
2018-05-26 08:48:53 +02:00
2014-01-23 16:36:54 -08:00
2011-11-08 14:51:46 +11:00
2014-06-25 18:49:40 -05:00
2012-11-15 13:00:58 +11:00
2012-10-05 23:38:38 +02:00
2015-01-12 05:04:13 -08:00
2015-02-03 18:47:18 +01:00
2015-07-20 22:30:53 -04:00
2020-11-22 09:56:58 +01:00
2012-05-11 18:00:14 -06:00
2014-11-03 12:12:32 +11:00
2015-11-09 15:11:24 -08:00
2015-06-25 17:00:35 -07:00
2019-05-16 19:44:49 +02:00
2013-10-11 16:48:53 +11:00
2014-05-20 10:54:06 +10:00
2014-08-05 16:33:48 +10:00
2014-09-25 23:14:43 +10:00
2012-02-14 14:06:50 -07:00
2013-06-12 12:37:26 +01:00
2016-09-15 08:27:49 +02:00
2012-11-15 13:00:58 +11:00
2013-01-03 15:57:04 -08:00
2015-07-29 10:02:36 +02:00
2015-07-13 10:10:54 +10:00
2018-05-30 07:49:12 +02:00
2014-09-25 23:14:43 +10:00
2014-07-28 14:11:23 +10:00
2015-08-03 11:34:15 +02:00
2015-10-06 14:52:48 -04:00
2011-12-20 10:20:19 -05:00
2014-12-29 15:44:53 +11:00
2012-02-21 11:40:36 +01:00
2012-07-24 15:27:29 +08:00
2020-06-29 20:07:56 -04:00
2020-11-22 09:56:58 +01:00
2014-09-22 10:11:34 +02:00
2013-10-17 14:45:05 +02:00
2015-06-05 17:26:35 +02:00
2015-08-22 11:16:19 +02:00
2015-08-22 11:16:19 +02:00
2014-03-19 19:57:15 -05:00
2015-08-22 11:16:19 +02:00
2019-06-22 08:18:26 +02:00
2014-01-09 10:14:57 +01:00
2015-05-28 10:42:58 +02:00
2014-04-23 10:05:20 +10:00
2013-12-09 11:40:25 +11:00
2012-04-24 15:34:16 -07:00
2015-10-09 08:01:38 +11:00
2014-03-07 15:52:10 +11:00
2015-06-24 17:49:41 -07:00
2012-10-09 09:47:26 +01:00
2015-06-24 17:49:41 -07:00
2015-06-02 21:37:28 -05:00
2014-07-28 15:23:13 +02:00
2015-10-12 15:30:09 +11:00
2014-07-28 14:10:23 +10:00
2014-04-23 10:05:34 +10:00
2015-10-22 16:06:08 +02:00
2012-09-14 10:15:35 +02:00
2015-03-31 22:23:17 -05:00
2015-10-22 15:19:40 +02:00
2012-08-24 20:26:04 +10:00
2013-07-01 18:38:41 -05:00
2018-11-21 09:27:36 +01:00
2015-10-05 21:32:50 +11:00
2013-06-26 12:10:55 +02:00
2015-04-11 20:49:27 +10:00
2015-03-23 14:05:49 +11:00
2016-03-16 08:43:01 -07:00
2018-04-24 09:32:06 +02:00
2014-07-28 14:10:25 +10:00
2019-05-16 19:44:44 +02:00
2014-10-02 16:04:21 +10:00
2018-04-13 19:50:08 +02:00
2013-04-18 13:03:50 +10:00
2015-08-18 19:32:11 +10:00
2015-06-25 15:22:36 -07:00
2020-08-21 10:53:05 +02:00
2013-08-07 18:38:03 -05:00
2014-07-28 14:30:47 +10:00
2014-10-15 11:23:20 +11:00
2013-12-10 11:25:05 +11:00
2013-12-10 11:25:05 +11:00
2014-11-17 10:12:42 +00:00
2015-06-02 21:37:27 -05:00
2014-11-14 17:24:21 +11:00
2014-11-14 17:24:21 +11:00
2015-10-12 15:30:09 +11:00
2021-01-17 13:55:13 +01:00
2018-02-16 20:09:34 +01:00
2015-06-03 13:27:19 +10:00
2013-01-10 15:08:37 +11:00
2019-05-16 19:44:50 +02:00
2019-05-16 19:44:49 +02:00
2015-08-18 19:34:42 +10:00
2013-06-20 16:55:09 +10:00
2015-07-16 16:02:37 +10:00
2014-09-25 23:14:43 +10:00
2014-01-15 13:46:44 +11:00
2015-06-02 21:37:28 -05:00
2015-02-16 17:56:05 -08:00
2015-02-16 17:56:05 -08:00
2015-06-19 17:10:29 +10:00
2015-08-07 23:00:01 -05:00
2015-02-16 17:56:05 -08:00
2015-02-16 17:56:05 -08:00
2014-08-13 18:20:41 +10:00
2015-06-19 17:10:29 +10:00
2014-09-09 19:02:45 +10:00
2015-09-16 15:47:51 +02:00
2012-11-15 13:00:58 +11:00
2014-06-11 16:35:38 +10:00
2019-05-16 19:45:18 +02:00
2013-08-07 18:38:04 -05:00
2020-10-29 09:03:06 +01:00
2014-09-25 23:14:43 +10:00
2015-07-23 19:43:11 +10:00
2012-03-28 18:30:02 +01:00
2013-11-06 14:13:49 +11:00
2015-04-17 09:04:10 -04:00
2014-06-10 18:54:22 -07:00
2020-11-22 09:56:58 +01:00
2020-11-22 09:56:58 +01:00
2019-12-21 10:34:44 +01:00
2013-06-01 08:29:23 +10:00
2015-04-10 20:02:49 +10:00
2015-03-06 23:21:07 +01:00
2012-09-17 16:31:51 +10:00
2015-08-04 08:49:21 -07:00
2015-08-18 19:29:49 +10:00
2012-10-09 09:47:26 +01:00
2014-10-08 20:14:54 +11:00
2014-09-25 23:14:51 +10:00
2014-04-30 15:26:18 +10:00
2015-03-24 13:33:52 +11:00
2012-09-12 14:57:09 -05:00
2015-07-14 14:56:48 +08:00
2018-04-24 09:32:06 +02:00
2015-07-29 11:56:13 +10:00
2013-02-03 18:16:11 -05:00
2015-12-16 21:52:32 +11:00
2011-11-25 14:32:57 +11:00
2012-10-09 09:47:26 +01:00
2015-04-12 21:03:30 +02:00
2015-04-21 15:21:31 +02:00
2013-11-22 16:56:48 -06:00
2014-11-17 10:12:42 +00:00
2014-12-05 16:26:15 +11:00
2014-03-29 15:44:05 +01:00
2017-08-06 19:19:40 -07:00
2015-08-06 16:36:23 +10:00
2015-06-10 14:06:29 +10:00
2015-09-16 15:47:51 +02:00
2014-09-25 23:14:43 +10:00
2012-10-09 09:47:26 +01:00
2020-11-22 09:56:58 +01:00
2012-11-15 13:00:58 +11:00
2015-03-16 18:50:17 +11:00
2012-11-15 13:00:58 +11:00
2014-09-25 23:14:43 +10:00
2013-12-30 14:02:29 +11:00
2015-11-16 17:05:53 +11:00
2013-11-20 16:31:01 +01:00
2019-12-21 10:35:36 +01:00
2014-02-17 11:19:37 +11:00
2015-03-23 14:29:40 +11:00
2015-05-05 13:35:39 -06:00
2016-05-11 11:21:20 +02:00
2015-04-10 20:02:49 +10:00
2013-10-30 16:02:28 +11:00
0bd585eb40