diff --git a/drivers/media/pci/ttpci/budget-av.c b/drivers/media/pci/ttpci/budget-av.c index 3766c7aa96f4..38cac508bd72 100644 --- a/drivers/media/pci/ttpci/budget-av.c +++ b/drivers/media/pci/ttpci/budget-av.c @@ -1462,8 +1462,7 @@ static int budget_av_attach(struct saa7146_dev *dev, struct saa7146_pci_extensio budget_av->has_saa7113 = 1; err = saa7146_vv_init(dev, &vv_data); if (err != 0) { - ttpci_budget_deinit(&budget_av->budget); - kfree(budget_av); + /* fixme: proper cleanup here */ ERR("cannot init vv subsystem\n"); return err; } @@ -1472,10 +1471,9 @@ static int budget_av_attach(struct saa7146_dev *dev, struct saa7146_pci_extensio vv_data.vid_ops.vidioc_s_input = vidioc_s_input; if ((err = saa7146_register_device(&budget_av->vd, dev, "knc1", VFL_TYPE_VIDEO))) { - saa7146_vv_release(dev); - ttpci_budget_deinit(&budget_av->budget); - kfree(budget_av); + /* fixme: proper cleanup here */ ERR("cannot register capture v4l2 device\n"); + saa7146_vv_release(dev); return err; }