From 4da8b9dbc7add67cac4fbe910f7f60001a508d84 Mon Sep 17 00:00:00 2001 From: tashar02 Date: Fri, 11 Jul 2025 14:05:40 +0530 Subject: [PATCH] drivers: Guard dump_stack with DEBUG_KERNEL Thanks to @tashar02 for pointing out these dump_stacks which were causing logspams Signed-off-by: Wahid7852 --- drivers/leds/led-core.c | 1 - drivers/soc/mediatek/mtk-cmdq-helper.c | 2 ++ 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/leds/led-core.c b/drivers/leds/led-core.c index 9ce6b32f52a1..d7d8cb15f976 100644 --- a/drivers/leds/led-core.c +++ b/drivers/leds/led-core.c @@ -177,7 +177,6 @@ static void led_blink_setup(struct led_classdev *led_cdev, void led_init_core(struct led_classdev *led_cdev) { INIT_WORK(&led_cdev->set_brightness_work, set_brightness_delayed); - setup_timer(&led_cdev->blink_timer, led_timer_function, (unsigned long)led_cdev); } diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c index e3832162ccf5..2d72516ed782 100755 --- a/drivers/soc/mediatek/mtk-cmdq-helper.c +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c @@ -183,7 +183,9 @@ struct cmdq_client *cmdq_mbox_create(struct device *dev, int index) if (IS_ERR(client->chan)) { cmdq_err("channel request fail:%d, idx:%d", PTR_ERR(client->chan), index); +#ifdef CONFIG_DEBUG_KERNEL dump_stack(); +#endif kfree(client); return NULL; }