Andrey Ryabinin
5eb48b4401
stackdepot: respect __GFP_NOLOCKDEP allocation flag
commit 6fe60465e1d53ea321ee909be26d97529e8f746c upstream.
If stack_depot_save_flags() allocates memory it always drops
__GFP_NOLOCKDEP flag. So when KASAN tries to track __GFP_NOLOCKDEP
allocation we may end up with lockdep splat like bellow:
======================================================
WARNING: possible circular locking dependency detected
6.9.0-rc3+ #49 Not tainted
------------------------------------------------------
kswapd0/149 is trying to acquire lock:
ffff88811346a920
(&xfs_nondir_ilock_class){++++}-{4:4}, at: xfs_reclaim_inode+0x3ac/0x590
[xfs]
but task is already holding lock:
ffffffff8bb33100 (fs_reclaim){+.+.}-{0:0}, at:
balance_pgdat+0x5d9/0xad0
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #1 (fs_reclaim){+.+.}-{0:0}:
__lock_acquire+0x7da/0x1030
lock_acquire+0x15d/0x400
fs_reclaim_acquire+0xb5/0x100
prepare_alloc_pages.constprop.0+0xc5/0x230
__alloc_pages+0x12a/0x3f0
alloc_pages_mpol+0x175/0x340
stack_depot_save_flags+0x4c5/0x510
kasan_save_stack+0x30/0x40
kasan_save_track+0x10/0x30
__kasan_slab_alloc+0x83/0x90
kmem_cache_alloc+0x15e/0x4a0
__alloc_object+0x35/0x370
__create_object+0x22/0x90
__kmalloc_node_track_caller+0x477/0x5b0
krealloc+0x5f/0x110
xfs_iext_insert_raw+0x4b2/0x6e0 [xfs]
xfs_iext_insert+0x2e/0x130 [xfs]
xfs_iread_bmbt_block+0x1a9/0x4d0 [xfs]
xfs_btree_visit_block+0xfb/0x290 [xfs]
xfs_btree_visit_blocks+0x215/0x2c0 [xfs]
xfs_iread_extents+0x1a2/0x2e0 [xfs]
xfs_buffered_write_iomap_begin+0x376/0x10a0 [xfs]
iomap_iter+0x1d1/0x2d0
iomap_file_buffered_write+0x120/0x1a0
xfs_file_buffered_write+0x128/0x4b0 [xfs]
vfs_write+0x675/0x890
ksys_write+0xc3/0x160
do_syscall_64+0x94/0x170
entry_SYSCALL_64_after_hwframe+0x71/0x79
Always preserve __GFP_NOLOCKDEP to fix this.
Link: https://lkml.kernel.org/r/20240418141133.22950-1-ryabinin.a.a@gmail.com
Fixes: cd11016e5f ("mm, kasan: stackdepot implementation. Enable stackdepot for SLAB")
Signed-off-by: Andrey Ryabinin <ryabinin.a.a@gmail.com>
Reported-by: Xiubo Li <xiubli@redhat.com>
Closes: https://lore.kernel.org/all/a0caa289-ca02-48eb-9bf2-d86fd47b71f4@redhat.com/
Reported-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Closes: https://lore.kernel.org/all/f9ff999a-e170-b66b-7caf-293f2b147ac2@opensource.wdc.com/
Suggested-by: Dave Chinner <david@fromorbit.com>
Tested-by: Xiubo Li <xiubli@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Alexander Potapenko <glider@google.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
(cherry picked from commit 79b25b1a58d0a6b53dfd685bca8a1984c86710dd)
Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>
2025-12-24 11:20:15 +00:00
..
2017-11-02 11:10:55 +01:00
2022-06-25 11:46:27 +02:00
2020-11-10 10:29:03 +01:00
2017-10-03 17:54:25 -07:00
2017-11-02 11:10:55 +01:00
2023-09-23 10:47:04 +02:00
2022-04-20 09:08:12 +02:00
2019-07-31 07:28:30 +02:00
2025-08-27 17:06:45 +05:30
2021-11-26 11:40:28 +01:00
2020-06-25 15:41:57 +02:00
2017-08-15 09:02:08 -07:00
2017-11-02 11:10:55 +01:00
2017-12-14 09:52:52 +01:00
2022-06-06 08:20:56 +02:00
2017-07-14 15:05:13 -07:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2020-01-29 15:02:39 +01:00
2019-04-05 22:31:33 +02:00
2024-01-10 12:49:04 +00:00
2017-11-02 11:10:55 +01:00
2018-12-05 12:30:44 -08:00
2017-11-02 11:10:55 +01:00
2023-08-30 16:35:15 +02:00
2017-11-02 11:10:55 +01:00
2017-09-08 18:26:49 -07:00
2017-11-02 11:10:55 +01:00
2023-06-14 10:35:25 +02:00
2017-11-02 11:10:55 +01:00
2017-06-09 11:52:07 +02:00
2020-10-29 09:07:10 +01:00
2017-11-02 11:10:55 +01:00
2020-11-10 10:29:04 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2020-03-03 02:10:06 +08:00
2023-08-11 11:33:47 +02:00
2020-04-16 17:06:03 +08:00
2017-11-02 11:10:55 +01:00
2021-07-20 16:17:51 +02:00
2021-11-26 11:40:28 +01:00
2017-11-02 11:10:55 +01:00
2020-01-27 14:46:39 +01:00
2017-10-12 17:16:40 +01:00
2019-04-20 09:15:07 +02:00
2022-06-23 12:23:57 +05:30
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2019-11-12 19:18:01 +01:00
2023-06-14 18:03:26 +05:30
2017-11-02 11:10:55 +01:00
2018-05-09 09:51:54 +02:00
2017-07-10 16:32:35 -07:00
2017-08-10 15:54:06 -07:00
2020-04-24 08:00:31 +02:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2021-01-12 20:09:06 +01:00
2017-02-24 17:46:57 -08:00
2017-02-24 17:46:57 -08:00
2022-05-12 12:17:06 +02:00
2017-11-02 11:10:55 +01:00
2022-07-12 16:27:29 +02:00
2017-11-02 11:10:55 +01:00
2019-04-05 22:31:24 +02:00
2018-12-17 09:28:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2018-08-17 21:01:11 +02:00
2022-02-23 11:57:35 +01:00
2017-11-02 11:10:55 +01:00
2017-03-02 08:42:38 +01:00
2017-11-02 11:10:55 +01:00
2022-03-23 09:01:34 +01:00
2025-09-21 09:20:37 +00:00
2020-08-27 23:59:38 +08:00
2017-05-16 08:44:22 -03:00
2020-08-01 00:47:04 +08:00
2020-01-27 14:46:44 +01:00
2018-10-03 17:00:48 -07:00
2021-05-22 10:57:41 +02:00
2023-11-11 12:32:52 +05:30
2021-07-20 16:17:33 +02:00
2021-07-20 16:17:33 +02:00
2017-06-08 17:36:03 +08:00
2017-02-24 17:46:56 -08:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2022-07-10 16:50:55 +05:30
2021-12-25 18:07:04 +05:30
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2021-05-22 10:57:39 +02:00
2018-09-05 09:26:35 +02:00
2022-06-14 16:54:01 +02:00
2023-01-18 09:26:10 +01:00
2017-11-02 11:10:55 +01:00
2018-02-25 11:08:01 +01:00
2023-01-18 09:26:04 +01:00
2017-02-03 16:35:42 -05:00
2017-11-02 11:10:55 +01:00
2017-03-02 08:42:34 +01:00
2017-03-22 19:18:43 -07:00
2017-03-02 08:42:27 +01:00
2023-08-11 11:33:32 +02:00
2022-06-25 11:46:36 +02:00
2025-09-03 18:13:53 +00:00
2017-11-02 11:10:55 +01:00
2018-12-17 09:28:55 +01:00
2017-09-08 18:26:48 -07:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2019-04-03 06:25:09 +02:00
2019-05-31 06:47:10 -07:00
2020-11-05 11:06:58 +01:00
2021-07-20 16:17:47 +02:00
2022-06-25 11:46:27 +02:00
2021-12-25 18:07:04 +05:30
2022-06-25 11:46:39 +02:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2025-12-24 11:20:15 +00:00
2017-09-13 18:53:16 -07:00
2022-01-03 23:21:18 +05:30
2020-06-22 11:22:58 +02:00
2020-06-22 11:22:58 +02:00
2022-07-10 16:50:55 +05:30
2017-11-02 11:10:55 +01:00
2018-05-22 18:53:58 +02:00
2021-10-17 10:08:32 +02:00
2019-01-13 10:01:07 +01:00
2023-08-30 16:35:13 +02:00
2018-12-08 13:03:35 +01:00
2020-02-19 10:09:50 +01:00
2022-04-20 09:08:21 +02:00
2017-05-08 17:15:10 -07:00
2020-02-14 01:31:11 +01:00
2017-02-26 11:03:38 -05:00
2022-06-28 17:38:20 +00:00
2017-07-25 12:35:23 -07:00
2017-05-08 17:15:10 -07:00
2020-03-05 09:58:19 -08:00
2017-07-12 16:26:00 -07:00
2017-05-01 09:36:30 +02:00
2017-07-21 09:38:30 +02:00
2021-10-09 14:09:46 +02:00
2023-08-11 11:33:35 +02:00
2017-10-22 03:14:07 +01:00
2017-10-22 03:14:07 +01:00
2023-10-31 18:41:02 +05:30
2023-09-23 10:46:52 +02:00
2017-11-02 11:10:55 +01:00
2023-02-25 11:50:31 +01:00
2017-06-05 16:59:05 +02:00
2024-01-10 13:03:02 +00:00
2017-11-02 11:10:55 +01:00
2017-08-15 09:02:07 -07:00