Files
kernel_realme_nemo/include/linux
Eric Biggers a36e1978c6 wait: add wake_up_pollfree()
commit 42288cb44c4b5fff7653bc392b583a2b8bd6a8c0 upstream.

Several ->poll() implementations are special in that they use a
waitqueue whose lifetime is the current task, rather than the struct
file as is normally the case.  This is okay for blocking polls, since a
blocking poll occurs within one task; however, non-blocking polls
require another solution.  This solution is for the queue to be cleared
before it is freed, using 'wake_up_poll(wq, EPOLLHUP | POLLFREE);'.

However, that has a bug: wake_up_poll() calls __wake_up() with
nr_exclusive=1.  Therefore, if there are multiple "exclusive" waiters,
and the wakeup function for the first one returns a positive value, only
that one will be called.  That's *not* what's needed for POLLFREE;
POLLFREE is special in that it really needs to wake up everyone.

Considering the three non-blocking poll systems:

- io_uring poll doesn't handle POLLFREE at all, so it is broken anyway.

- aio poll is unaffected, since it doesn't support exclusive waits.
  However, that's fragile, as someone could add this feature later.

- epoll doesn't appear to be broken by this, since its wakeup function
  returns 0 when it sees POLLFREE.  But this is fragile.

Although there is a workaround (see epoll), it's better to define a
function which always sends POLLFREE to all waiters.  Add such a
function.  Also make it verify that the queue really becomes empty after
all waiters have been woken up.

Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20211209010455.42744-2-ebiggers@kernel.org
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-12-14 10:16:55 +01:00
..
2018-02-22 15:42:23 +01:00
2017-08-30 14:40:40 +02:00
2018-08-03 07:50:38 +02:00
2017-08-24 13:23:03 -07:00
2017-08-03 19:09:26 -07:00
2019-11-24 08:22:48 +01:00
2017-08-07 17:22:14 +02:00
2021-12-08 08:46:55 +01:00
2021-12-08 08:46:55 +01:00
2020-04-02 16:34:21 +02:00
2018-02-22 15:42:24 +01:00
2019-12-17 20:38:50 +01:00
2021-03-03 18:22:46 +01:00
2021-02-07 14:47:41 +01:00
2021-11-26 11:40:20 +01:00
2017-08-28 20:51:22 +02:00
2017-09-07 11:53:11 +02:00
2019-12-31 12:37:21 +01:00
2021-07-11 12:48:09 +02:00
2020-07-29 07:42:55 +02:00
2018-02-22 15:42:23 +01:00
2017-07-25 18:05:25 +02:00
2017-09-25 08:56:05 -06:00
2020-11-18 18:28:00 +01:00
2020-03-20 10:54:12 +01:00
2017-08-06 20:55:29 -07:00
2019-06-11 12:21:48 +02:00
2020-04-02 16:34:36 +02:00
2017-08-16 16:28:47 -07:00
2018-11-13 11:15:11 -08:00
2020-12-11 13:39:04 +01:00
2017-07-24 17:50:37 +02:00
2020-04-02 16:34:36 +02:00
2017-08-31 18:50:14 +02:00
2021-12-14 10:16:55 +01:00
2017-08-15 09:02:07 -07:00
2017-08-15 09:02:08 -07:00