Evolution-X-Devices/kernel_samsung_a71
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
32430c8d80aec70d1ddaa2249d4f4e3e4eb11ca4
kernel_samsung_a71/kernel
History
Steven Rostedt (VMware) 7e35f39f21 tracing: Do not reference char * as a string in histograms 
commit 704adfb5a9978462cd861f170201ae2b5e3d3a80 upstream.

The histogram logic was allowing events with char * pointers to be used as
normal strings. But it was easy to crash the kernel with:

 # echo 'hist:keys=filename' > events/syscalls/sys_enter_openat/trigger

And open some files, and boom!

 BUG: unable to handle page fault for address: 00007f2ced0c3280
 #PF: supervisor read access in kernel mode
 #PF: error_code(0x0000) - not-present page
 PGD 1173fa067 P4D 1173fa067 PUD 1171b6067 PMD 1171dd067 PTE 0
 Oops: 0000 [#1] PREEMPT SMP
 CPU: 6 PID: 1810 Comm: cat Not tainted 5.13.0-rc5-test+ #61
 Hardware name: Hewlett-Packard HP Compaq Pro 6300 SFF/339A, BIOS K01
v03.03 07/14/2016
 RIP: 0010:strlen+0x0/0x20
 Code: f6 82 80 2a 0b a9 20 74 11 0f b6 50 01 48 83 c0 01 f6 82 80 2a 0b
a9 20 75 ef c3 66 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 <80> 3f 00 74
10 48 89 f8 48 83 c0 01 80 38 00 75 f7 48 29 f8 c3

 RSP: 0018:ffffbdbf81567b50 EFLAGS: 00010246
 RAX: 0000000000000003 RBX: ffff93815cdb3800 RCX: ffff9382401a22d0
 RDX: 0000000000000100 RSI: 0000000000000000 RDI: 00007f2ced0c3280
 RBP: 0000000000000100 R08: ffff9382409ff074 R09: ffffbdbf81567c98
 R10: ffff9382409ff074 R11: 0000000000000000 R12: ffff9382409ff074
 R13: 0000000000000001 R14: ffff93815a744f00 R15: 00007f2ced0c3280
 FS:  00007f2ced0f8580(0000) GS:ffff93825a800000(0000)
knlGS:0000000000000000
 CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
 CR2: 00007f2ced0c3280 CR3: 0000000107069005 CR4: 00000000001706e0
 Call Trace:
  event_hist_trigger+0x463/0x5f0
  ? find_held_lock+0x32/0x90
  ? sched_clock_cpu+0xe/0xd0
  ? lock_release+0x155/0x440
  ? kernel_init_free_pages+0x6d/0x90
  ? preempt_count_sub+0x9b/0xd0
  ? kernel_init_free_pages+0x6d/0x90
  ? get_page_from_freelist+0x12c4/0x1680
  ? __rb_reserve_next+0xe5/0x460
  ? ring_buffer_lock_reserve+0x12a/0x3f0
  event_triggers_call+0x52/0xe0
  ftrace_syscall_enter+0x264/0x2c0
  syscall_trace_enter.constprop.0+0x1ee/0x210
  do_syscall_64+0x1c/0x80
  entry_SYSCALL_64_after_hwframe+0x44/0xae

Where it triggered a fault on strlen(key) where key was the filename.

The reason is that filename is a char * to user space, and the histogram
code just blindly dereferenced it, with obvious bad results.

I originally tried to use strncpy_from_user/kernel_nofault() but found
that there's other places that its dereferenced and not worth the effort.

Just do not allow "char *" to act like strings.

Link: https://lkml.kernel.org/r/20210715000206.025df9d2@rorschach.local.home

Cc: Ingo Molnar <mingo@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Tzvetomir Stoyanov <tz.stoyanov@gmail.com>
Cc: stable@vger.kernel.org
Acked-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: Tom Zanussi <zanussi@kernel.org>
Fixes: 79e577cbce ("tracing: Support string type key properly")
Fixes: 5967bd5c4239 ("tracing: Let filter_assign_type() detect FILTER_PTR_STRING")
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-07-20 16:17:48 +02:00
..
bpf
bpf: No need to simulate speculative domain for immediates
2021-06-10 12:43:53 +02:00
cgroup
cgroup1: don't allow '\n' in renaming
2021-06-16 11:53:02 +02:00
configs
ANDROID: binder: add hwbinder,vndbinder to BINDER_DEVICES.
2017-08-22 18:43:23 -07:00
debug
kdb: Make memory allocations more robust
2021-03-03 18:22:36 +01:00
events
perf: Fix data race between pin_count increment/decrement
2021-06-16 11:53:04 +02:00
gcov
gcov: add support for GCC 10.1
2020-09-23 10:46:32 +02:00
irq
genirq: Disable interrupts for force threaded handlers
2021-03-24 11:05:06 +01:00
livepatch
livepatch: Nullify obj->mod in klp_module_coming()'s error path
2019-10-07 18:55:09 +02:00
locking
rtmutex: Remove unused argument from rt_mutex_proxy_unlock()
2021-01-30 13:31:16 +01:00
power
PM: hibernate: remove the bogus call to get_gendisk() in software_resume()
2020-10-29 09:07:16 +01:00
printk
printk: fix deadlock when kernel panic
2021-03-03 18:22:55 +01:00
rcu
rcuperf: Fix cleanup path for invalid perf_type strings
2019-05-31 06:47:33 -07:00
sched
sched/fair: Optimize select_idle_cpu
2021-06-10 12:43:53 +02:00
time
posix-timers: Preserve return value in clock_adjtime32()
2021-05-22 10:57:22 +02:00
trace
tracing: Do not reference char * as a string in histograms
2021-07-20 16:17:48 +02:00
.gitignore
…
acct.c
kernel/acct.c: fix the acct->needcheck check in check_free_space()
2018-01-10 09:31:17 +01:00
async.c
kernel/async.c: revert "async: simplify lowest_in_progress()"
2018-02-16 20:23:05 +01:00
audit_fsnotify.c
…
audit_tree.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
audit_watch.c
audit: CONFIG_CHANGE don't log internal bookkeeping as an event
2020-10-01 13:12:33 +02:00
audit.c
audit: fix a net reference leak in audit_list_rules_send()
2020-06-20 10:25:10 +02:00
audit.h
audit: fix a net reference leak in audit_list_rules_send()
2020-06-20 10:25:10 +02:00
auditfilter.c
audit: fix a net reference leak in audit_list_rules_send()
2020-06-20 10:25:10 +02:00
auditsc.c
audit: print empty EXECVE args
2019-12-01 09:14:03 +01:00
backtracetest.c
…
bounds.c
kbuild: fix kernel/bounds.c 'W=1' warning
2018-11-13 11:15:08 -08:00
capability.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
compat.c
make 'user_access_begin()' do 'access_ok()'
2020-06-20 10:24:58 +02:00
configs.c
…
context_tracking.c
…
cpu_pm.c
kernel/cpu_pm: Fix uninitted local in cpu_pm
2020-06-20 10:25:19 +02:00
cpu.c
cpu/hotplug: Cure the cpusets trainwreck
2021-07-20 16:17:46 +02:00
crash_core.c
kdump: write correct address of mem_section into vmcoreinfo
2018-01-17 09:45:27 +01:00
crash_dump.c
…
cred.c
memcg: account security cred as well to kmemcg
2020-01-09 10:17:54 +01:00
delayacct.c
delayacct: Use raw_spinlocks
2018-08-03 07:50:38 +02:00
dma.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
exec_domain.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
exit.c
don't dump the threads that had been already exiting when zapped.
2020-11-18 18:27:58 +01:00
extable.c
extable: Enable RCU if it is not watching in kernel_text_address()
2017-09-23 16:50:20 -04:00
fork.c
fork: fix copy_process(CLONE_PARENT) race with the exiting ->real_parent
2020-11-10 10:29:06 +01:00
freezer.c
…
futex.c
mm, futex: fix shared futex pgoff on shmem huge page
2021-07-11 12:48:12 +02:00
groups.c
kernel: make groups_sort calling a responsibility group_info allocators
2017-12-20 10:10:18 +01:00
hung_task.c
kernel: hung_task.c: disable on suspend
2019-04-20 09:15:05 +02:00
irq_work.c
…
jump_label.c
sched/core: Fix cpu.max vs. cpuhotplug deadlock
2018-12-05 19:41:17 +01:00
kallsyms.c
kallsyms: Don't let kallsyms_lookup_size_offset() fail on retrieving the first symbol
2019-09-21 07:15:38 +02:00
kcmp.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
Kconfig.freezer
…
Kconfig.hz
…
Kconfig.locks
…
Kconfig.preempt
…
kcov.c
kcov: ensure irq code sees a valid area
2018-08-03 07:50:22 +02:00
kexec_core.c
kexec: Allocate decrypted control pages for kdump if SME is enabled
2019-11-24 08:23:15 +01:00
kexec_file.c
kernel: kexec_file: fix error return code of kexec_calculate_store_digests()
2021-05-22 10:57:39 +02:00
kexec_internal.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
kexec.c
kdump: protect vmcoreinfo data under the crash memory
2017-07-12 16:26:00 -07:00
kmod.c
kmod: make request_module() return an error when autoloading is disabled
2020-04-24 08:00:44 +02:00
kprobes.c
kretprobe: Avoid re-registration of the same kretprobe earlier
2021-02-10 09:12:09 +01:00
ksysfs.c
kexec: move vmcoreinfo out of the kernel's .bss section
2017-07-12 16:25:59 -07:00
kthread.c
kthread: prevent deadlock when kthread_mod_delayed_work() races with kthread_cancel_delayed_work_sync()
2021-07-11 12:48:13 +02:00
latencytop.c
…
Makefile
elfcore: fix building with clang
2021-02-10 09:12:08 +01:00
memremap.c
mm, devm_memremap_pages: kill mapping "System RAM" support
2019-01-13 10:01:02 +01:00
module_signing.c
…
module-internal.h
…
module.c
modules: inherit TAINT_PROPRIETARY_MODULE
2021-05-22 10:57:24 +02:00
notifier.c
x86/mm: split vmalloc_sync_all()
2020-04-02 16:34:20 +02:00
nsproxy.c
…
padata.c
padata: purge get_cpu and reorder_via_wq from padata_do_serial
2020-05-27 16:43:05 +02:00
panic.c
panic: ensure preemption is disabled during panic()
2019-10-17 13:43:19 -07:00
params.c
kernel/params.c: improve STANDARD_PARAM_DEF readability
2017-10-03 17:54:26 -07:00
pid_namespace.c
signal/pid_namespace: Fix reboot_pid_ns to use send_sig not force_sig
2019-07-31 07:28:21 +02:00
pid.c
pids: make task_tgid_nr_ns() safe
2017-08-21 12:47:31 -07:00
profile.c
…
ptrace.c
ptrace: make ptrace() fail if the tracee changed its pid unexpectedly
2021-05-26 11:46:58 +02:00
range.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
reboot.c
reboot: fix overflow parsing reboot cpu number
2020-11-18 18:28:02 +01:00
relay.c
kernel/relay.c: fix memleak on destroy relay channel
2020-08-26 10:29:54 +02:00
resource.c
resource: fix integer overflow at reallocation
2018-04-24 09:36:22 +02:00
seccomp.c
seccomp: Add missing return in non-void function
2021-03-03 18:22:53 +01:00
signal.c
signal: Extend exec_id to 64bits
2020-04-24 08:00:38 +02:00
smp.c
smp: Fix smp_call_function_single_async prototype
2021-05-22 10:57:35 +02:00
smpboot.c
kthread: Extract KTHREAD_IS_PER_CPU
2021-02-07 14:47:41 +01:00
smpboot.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
softirq.c
Mark HI and TASKLET softirq synchronous
2018-08-15 18:12:47 +02:00
stacktrace.c
…
stop_machine.c
stop_machine: Atomically queue and wake stopper threads
2018-09-05 09:26:36 +02:00
sys_ni.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
sys.c
kernel/sys.c: avoid copying possible padding bytes in copy_to_user
2020-10-01 13:12:30 +02:00
sysctl_binary.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
sysctl.c
kernel: sysctl: make drop_caches write-only
2020-01-04 13:59:57 +01:00
task_work.c
locking/barriers: Convert users of lockless_dereference() to READ_ONCE()
2017-12-25 14:26:21 +01:00
taskstats.c
taskstats: fix data-race
2020-01-09 10:17:53 +01:00
test_kprobes.c
…
torture.c
torture: Fix typo suppressing CPU-hotplug statistics
2017-07-25 13:04:45 -07:00
tracepoint.c
tracepoint: Do not fail unregistering a probe due to memory failure
2021-03-03 18:22:47 +01:00
tsacct.c
…
ucount.c
…
uid16.c
kernel: make groups_sort calling a responsibility group_info allocators
2017-12-20 10:10:18 +01:00
umh.c
usermodehelper: reset umask to default before executing user process
2020-10-14 09:51:10 +02:00
up.c
smp: Fix smp_call_function_single_async prototype
2021-05-22 10:57:35 +02:00
user_namespace.c
userns: move user access out of the mutex
2018-09-09 19:56:00 +02:00
user-return-notifier.c
…
user.c
…
utsname_sysctl.c
sys: don't hold uts_sem while accessing userspace memory
2018-09-09 19:56:00 +02:00
utsname.c
…
watchdog_hld.c
watchdog: Mark watchdog touch functions as notrace
2018-09-05 09:26:42 +02:00
watchdog.c
watchdog/softlockup: Enforce that timestamp is valid on boot
2020-02-28 16:36:05 +01:00
workqueue_internal.h
Merge branch 'for-4.14-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/wq
2017-11-06 12:26:49 -08:00
workqueue.c
wq: handle VM suspension in stall detection
2021-06-16 11:53:01 +02:00