05ef023f11
commit 64276a9939ff414f2f0db38036cf4e1a0a703394 upstream.
Rather than hard coding various lengths, we can use the right constants.
Strings should be `char *` while buffers should be `u8 *`. Rather than
have a nonsensical and unused maxlength, just remove it. Finally, use
snprintf instead of sprintf, just out of good hygiene.
As well, remove the old comment about returning a binary UUID via the
binary sysctl syscall. That syscall was removed from the kernel in 5.5,
and actually, the "uuid_strategy" function and related infrastructure
for even serving it via the binary sysctl syscall was removed with
894d249115 ("sysctl drivers: Remove dead binary sysctl support") back
in 2.6.33.
Reviewed-by: Dominik Brodowski <linux@dominikbrodowski.net>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
52 lines
1.3 KiB
C
52 lines
1.3 KiB
C
/*
|
|
* UUID/GUID definition
|
|
*
|
|
* Copyright (C) 2010, 2016 Intel Corp.
|
|
* Huang Ying <ying.huang@intel.com>
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License version
|
|
* 2 as published by the Free Software Foundation;
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*/
|
|
#ifndef _LINUX_UUID_H_
|
|
#define _LINUX_UUID_H_
|
|
|
|
#include <uapi/linux/uuid.h>
|
|
|
|
/*
|
|
* The length of a UUID string ("aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee")
|
|
* not including trailing NUL.
|
|
*/
|
|
#define UUID_STRING_LEN 36
|
|
#define UUID_SIZE 16
|
|
|
|
static inline int uuid_le_cmp(const uuid_le u1, const uuid_le u2)
|
|
{
|
|
return memcmp(&u1, &u2, sizeof(uuid_le));
|
|
}
|
|
|
|
static inline int uuid_be_cmp(const uuid_be u1, const uuid_be u2)
|
|
{
|
|
return memcmp(&u1, &u2, sizeof(uuid_be));
|
|
}
|
|
|
|
void generate_random_uuid(unsigned char uuid[16]);
|
|
|
|
extern void uuid_le_gen(uuid_le *u);
|
|
extern void uuid_be_gen(uuid_be *u);
|
|
|
|
bool __must_check uuid_is_valid(const char *uuid);
|
|
|
|
extern const u8 uuid_le_index[16];
|
|
extern const u8 uuid_be_index[16];
|
|
|
|
int uuid_le_to_bin(const char *uuid, uuid_le *u);
|
|
int uuid_be_to_bin(const char *uuid, uuid_be *u);
|
|
|
|
#endif
|