Matteo Croce
77a8c23403
reboot: fix overflow parsing reboot cpu number
commit df5b0ab3e08a156701b537809914b339b0daa526 upstream.
Limit the CPU number to num_possible_cpus(), because setting it to a
value lower than INT_MAX but higher than NR_CPUS produces the following
error on reboot and shutdown:
BUG: unable to handle page fault for address: ffffffff90ab1bb0
#PF: supervisor read access in kernel mode
#PF: error_code(0x0000) - not-present page
PGD 1c09067 P4D 1c09067 PUD 1c0a063 PMD 0
Oops: 0000 [#1] SMP
CPU: 1 PID: 1 Comm: systemd-shutdow Not tainted 5.9.0-rc8-kvm #110
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.13.0-2.fc32 04/01/2014
RIP: 0010:migrate_to_reboot_cpu+0xe/0x60
Code: ea ea 00 48 89 fa 48 c7 c7 30 57 f1 81 e9 fa ef ff ff 66 2e 0f 1f 84 00 00 00 00 00 53 8b 1d d5 ea ea 00 e8 14 33 fe ff 89 da <48> 0f a3 15 ea fc bd 00 48 89 d0 73 29 89 c2 c1 e8 06 65 48 8b 3c
RSP: 0018:ffffc90000013e08 EFLAGS: 00010246
RAX: ffff88801f0a0000 RBX: 0000000077359400 RCX: 0000000000000000
RDX: 0000000077359400 RSI: 0000000000000002 RDI: ffffffff81c199e0
RBP: ffffffff81c1e3c0 R08: ffff88801f41f000 R09: ffffffff81c1e348
R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000
R13: 00007f32bedf8830 R14: 00000000fee1dead R15: 0000000000000000
FS: 00007f32bedf8980(0000) GS:ffff88801f480000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: ffffffff90ab1bb0 CR3: 000000001d057000 CR4: 00000000000006a0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
__do_sys_reboot.cold+0x34/0x5b
do_syscall_64+0x2d/0x40
Fixes: 1b3a5d02ee ("reboot: move arch/x86 reboot= handling to generic kernel")
Signed-off-by: Matteo Croce <mcroce@microsoft.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Fabian Frederick <fabf@skynet.be>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Kees Cook <keescook@chromium.org>
Cc: Mike Rapoport <rppt@kernel.org>
Cc: Pavel Tatashin <pasha.tatashin@soleen.com>
Cc: Petr Mladek <pmladek@suse.com>
Cc: Robin Holt <robinmholt@gmail.com>
Cc: <stable@vger.kernel.org>
Link: https://lkml.kernel.org/r/20201103214025.116799-3-mcroce@linux.microsoft.com
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
[sudip: use reboot_mode instead of mode]
Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-11-18 18:28:02 +01:00
..
2020-10-01 13:12:35 +02:00
2020-08-21 09:48:02 +02:00
2017-08-22 18:43:23 -07:00
2020-11-05 11:06:55 +01:00
2020-11-18 18:28:02 +01:00
2020-09-23 10:46:32 +02:00
2020-11-18 18:27:53 +01:00
2019-10-07 18:55:09 +02:00
2020-09-03 11:22:27 +02:00
2020-10-29 09:07:16 +01:00
2020-10-01 13:12:45 +02:00
2019-05-31 06:47:33 -07:00
2020-08-21 09:48:02 +02:00
2020-11-18 18:28:00 +01:00
2020-11-18 18:27:52 +01:00
2018-01-10 09:31:17 +01:00
2018-02-16 20:23:05 +01:00
2017-11-02 11:10:55 +01:00
2020-10-01 13:12:33 +02:00
2020-06-20 10:25:10 +02:00
2020-06-20 10:25:10 +02:00
2020-06-20 10:25:10 +02:00
2019-12-01 09:14:03 +01:00
2018-11-13 11:15:08 -08:00
2017-11-02 11:10:55 +01:00
2020-06-20 10:24:58 +02:00
2020-06-20 10:25:19 +02:00
2020-04-24 08:00:41 +02:00
2018-01-17 09:45:27 +01:00
2020-01-09 10:17:54 +01:00
2018-08-03 07:50:38 +02:00
2017-11-02 11:10:55 +01:00
2019-10-11 18:18:42 +02:00
2017-11-02 11:10:55 +01:00
2020-11-18 18:27:58 +01:00
2017-09-23 16:50:20 -04:00
2020-11-10 10:29:06 +01:00
2020-11-18 18:27:58 +01:00
2017-12-20 10:10:18 +01:00
2019-04-20 09:15:05 +02:00
2018-12-05 19:41:17 +01:00
2019-09-21 07:15:38 +02:00
2017-11-02 11:10:55 +01:00
2018-08-03 07:50:22 +02:00
2019-11-24 08:23:15 +01:00
2017-07-12 16:26:02 -07:00
2017-11-02 11:10:55 +01:00
2017-07-12 16:26:00 -07:00
2020-04-24 08:00:44 +02:00
2020-10-01 13:12:51 +02:00
2017-07-12 16:25:59 -07:00
2020-11-10 10:29:04 +01:00
2019-12-05 15:38:22 +01:00
2019-01-13 10:01:02 +01:00
2020-02-14 16:32:06 -05:00
2020-04-02 16:34:20 +02:00
2020-05-27 16:43:05 +02:00
2019-10-17 13:43:19 -07:00
2017-10-03 17:54:26 -07:00
2019-07-31 07:28:21 +02:00
2017-08-21 12:47:31 -07:00
2020-01-23 08:20:32 +01:00
2017-11-02 11:10:55 +01:00
2020-11-18 18:28:02 +01:00
2020-08-26 10:29:54 +02:00
2018-04-24 09:36:22 +02:00
2018-05-22 18:54:04 +02:00
2020-04-24 08:00:38 +02:00
2019-02-12 19:46:13 +01:00
2017-10-04 10:53:54 +02:00
2017-11-02 11:10:55 +01:00
2018-08-15 18:12:47 +02:00
2018-09-05 09:26:36 +02:00
2017-11-02 11:10:55 +01:00
2020-10-01 13:12:30 +02:00
2017-11-02 11:10:55 +01:00
2020-01-04 13:59:57 +01:00
2017-12-25 14:26:21 +01:00
2020-01-09 10:17:53 +01:00
2017-07-25 13:04:45 -07:00
2018-05-09 09:51:50 +02:00
2017-12-20 10:10:18 +01:00
2020-10-14 09:51:10 +02:00
2017-08-29 15:14:38 +02:00
2018-09-09 19:56:00 +02:00
2018-09-09 19:56:00 +02:00
2018-09-05 09:26:42 +02:00
2020-02-28 16:36:05 +01:00
2017-11-06 12:26:49 -08:00
2020-03-20 10:54:16 +01:00