From 1cd79cdca9b118ba9a3afaac4962bbf193b7ab36 Mon Sep 17 00:00:00 2001 From: Sultan Alsawaf Date: Sat, 6 Feb 2021 20:17:09 -0800 Subject: [PATCH] binder: Stub out debug prints by default Binder code is very hot, so checking frequently to see if a debug message should be printed is a waste of cycles. We're not debugging binder, so just stub out the debug prints to compile them out entirely. Signed-off-by: Sultan Alsawaf --- drivers/android/binder.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/android/binder.c b/drivers/android/binder.c index 1c53a3e0dc2c..3e43b06ba032 100644 --- a/drivers/android/binder.c +++ b/drivers/android/binder.c @@ -154,6 +154,7 @@ static int binder_set_stop_on_user_error(const char *val, module_param_call(stop_on_user_error, binder_set_stop_on_user_error, param_get_int, &binder_stop_on_user_error, 0644); +#ifdef DEBUG #define binder_debug(mask, x...) \ do { \ if (binder_debug_mask & mask) \ @@ -167,6 +168,16 @@ module_param_call(stop_on_user_error, binder_set_stop_on_user_error, if (binder_stop_on_user_error) \ binder_stop_on_user_error = 2; \ } while (0) +#else +static inline void binder_debug(uint32_t mask, const char *fmt, ...) +{ +} +static inline void binder_user_error(const char *fmt, ...) +{ + if (binder_stop_on_user_error) + binder_stop_on_user_error = 2; +} +#endif #define to_flat_binder_object(hdr) \ container_of(hdr, struct flat_binder_object, hdr)