42b7135e0a
[ Upstream commit 4d521943f76bd0d1e68ea5e02df7aadd30b2838a ] GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. These are simple defines so they could be used in DTS but they will not have the same meaning: 1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE 2. GPIO_ACTIVE_LOW = 1 = IRQ_TYPE_EDGE_RISING Correct the interrupt flags, assuming the author of the code wanted same logical behavior behind the name "ACTIVE_xxx", this is: ACTIVE_LOW => IRQ_TYPE_LEVEL_LOW ACTIVE_HIGH => IRQ_TYPE_LEVEL_HIGH Fixes:a1a8b4594f("NFC: pn544: i2c: Add DTS Documentation") Fixes:6be88670fc("NFC: nxp-nci_i2c: Add I2C support to NXP NCI driver") Fixes: e3b329221567 ("dt-bindings: can: tcan4x5x: Update binding to use interrupt property") Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> Acked-by: Rob Herring <robh@kernel.org> Acked-by: Marc Kleine-Budde <mkl@pengutronix.de> # for tcan4x5x.txt Link: https://lore.kernel.org/r/20201026153620.89268-1-krzk@kernel.org Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
34 lines
877 B
Plaintext
34 lines
877 B
Plaintext
* NXP Semiconductors PN544 NFC Controller
|
|
|
|
Required properties:
|
|
- compatible: Should be "nxp,pn544-i2c".
|
|
- clock-frequency: I²C work frequency.
|
|
- reg: address on the bus
|
|
- interrupts: GPIO interrupt to which the chip is connected
|
|
- enable-gpios: Output GPIO pin used for enabling/disabling the PN544
|
|
- firmware-gpios: Output GPIO pin used to enter firmware download mode
|
|
|
|
Optional SoC Specific Properties:
|
|
- pinctrl-names: Contains only one value - "default".
|
|
- pintctrl-0: Specifies the pin control groups used for this controller.
|
|
|
|
Example (for ARM-based BeagleBone with PN544 on I2C2):
|
|
|
|
&i2c2 {
|
|
|
|
|
|
pn544: pn544@28 {
|
|
|
|
compatible = "nxp,pn544-i2c";
|
|
|
|
reg = <0x28>;
|
|
clock-frequency = <400000>;
|
|
|
|
interrupt-parent = <&gpio1>;
|
|
interrupts = <17 IRQ_TYPE_LEVEL_HIGH>;
|
|
|
|
enable-gpios = <&gpio3 21 GPIO_ACTIVE_HIGH>;
|
|
firmware-gpios = <&gpio3 19 GPIO_ACTIVE_HIGH>;
|
|
};
|
|
};
|