Hoang Le 3ed0b5bb8c tipc: fix NULL deref in tipc_link_xmit() ...

[ Upstream commit b77413446408fdd256599daf00d5be72b5f3e7c6 ]

The buffer list can have zero skb as following path:
tipc_named_node_up()->tipc_node_xmit()->tipc_link_xmit(), so
we need to check the list before casting an &sk_buff.

Fault report:
 [] tipc: Bulk publication failure
 [] general protection fault, probably for non-canonical [#1] PREEMPT [...]
 [] KASAN: null-ptr-deref in range [0x00000000000000c8-0x00000000000000cf]
 [] CPU: 0 PID: 0 Comm: swapper/0 Kdump: loaded Not tainted 5.10.0-rc4+ #2
 [] Hardware name: Bochs ..., BIOS Bochs 01/01/2011
 [] RIP: 0010:tipc_link_xmit+0xc1/0x2180
 [] Code: 24 b8 00 00 00 00 4d 39 ec 4c 0f 44 e8 e8 d7 0a 10 f9 48 [...]
 [] RSP: 0018:ffffc90000006ea0 EFLAGS: 00010202
 [] RAX: dffffc0000000000 RBX: ffff8880224da000 RCX: 1ffff11003d3cc0d
 [] RDX: 0000000000000019 RSI: ffffffff886007b9 RDI: 00000000000000c8
 [] RBP: ffffc90000007018 R08: 0000000000000001 R09: fffff52000000ded
 [] R10: 0000000000000003 R11: fffff52000000dec R12: ffffc90000007148
 [] R13: 0000000000000000 R14: 0000000000000000 R15: ffffc90000007018
 [] FS:  0000000000000000(0000) GS:ffff888037400000(0000) knlGS:000[...]
 [] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
 [] CR2: 00007fffd2db5000 CR3: 000000002b08f000 CR4: 00000000000006f0

Fixes: af9b028e27 ("tipc: make media xmit call outside node spinlock context")
Acked-by: Jon Maloy <jmaloy@redhat.com>
Signed-off-by: Hoang Le <hoang.h.le@dektech.com.au>
Link: https://lore.kernel.org/r/20210108071337.3598-1-hoang.h.le@dektech.com.au
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2021-01-23 15:48:47 +01:00

..

addr.c

…

addr.h

tipc: introduce constants for tipc address validation

2016-07-26 14:26:42 -07:00

bcast.c

tipc: correct initialization of skb list

2017-10-08 21:13:23 -07:00

bcast.h

tipc: make replicast a user selectable option

2017-01-20 12:10:17 -05:00

bearer.c

tipc: error path leak fixes in tipc_enable_bearer()

2018-03-03 10:24:30 +01:00

bearer.h

Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net

2017-09-01 17:42:05 -07:00

core.c

tipc: fix use-after-free in tipc_bcast_get_mode

2020-11-10 10:29:02 +01:00

core.h

netns: make struct pernet_operations::id unsigned int

2016-11-18 10:59:15 -05:00

discover.c

tipc: allocate user memory with GFP_KERNEL flag

2017-01-16 13:31:53 -05:00

discover.h

…

eth_media.c

…

ib_media.c

…

Kconfig

…

link.c

tipc: fix NULL deref in tipc_link_xmit()

2021-01-23 15:48:47 +01:00

link.h

tipc: transfer broadcast nacks in link state messages

2016-09-02 17:10:24 -07:00

Makefile

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

monitor.c

tipc: fix infinite loop when dumping link monitor summary

2018-06-21 04:02:43 +09:00

monitor.h

tipc: dump monitor attributes

2016-07-26 14:26:42 -07:00

msg.c

tipc: fix memory leak caused by tipc_buf_append()

2020-11-05 11:06:51 +01:00

msg.h

tipc: introduce replicast as transport option for multicast

2017-01-20 12:10:17 -05:00

name_distr.c

tipc: add NULL pointer check before calling kfree_rcu

2019-09-19 09:08:02 +02:00

name_distr.h

…

name_table.c

tipc: adjust the policy of holding subscription kref

2017-03-28 18:03:33 -07:00

name_table.h

tipc: add functionality to lookup multicast destination nodes

2017-01-20 12:10:16 -05:00

net.c

netlink: pass extended ACK struct where available

2017-04-13 13:58:22 -04:00

net.h

tipc: add peer removal functionality

2016-08-18 23:36:07 -07:00

netlink_compat.c

tipc: fix uninit skb->data in tipc_nl_compat_dumpit()

2020-09-03 11:22:23 +02:00

netlink.c

tipc: add policy for TIPC_NLA_NET_ADDR

2018-04-29 11:33:12 +02:00

netlink.h

tipc: make cluster size threshold for monitoring configurable

2016-07-26 14:26:42 -07:00

node.c

tipc: tipc clang warning

2020-01-27 14:46:27 +01:00

node.h

tipc: make replicast a user selectable option

2017-01-20 12:10:17 -05:00

server.c

tipc: fix memory leak in tipc_accept_from_sock()

2017-12-17 15:07:56 +01:00

server.h

…

socket.c

tipc: fix shutdown() of connection oriented socket

2020-10-01 13:12:24 +02:00

socket.h

…

subscr.c

tipc: fix modprobe tipc failed after switch order of device registration

2019-06-09 09:18:12 +02:00

subscr.h

tipc: fix modprobe tipc failed after switch order of device registration

2019-06-09 09:18:12 +02:00

sysctl.c

tipc: set sysctl_tipc_rmem and named_timeout right range

2020-01-27 14:46:29 +01:00

udp_media.c

net: ipv6_stub: use ip6_dst_lookup_flow instead of ip6_dst_lookup

2020-05-20 08:17:02 +02:00

udp_media.h

tipc: add UDP remoteip dump to netlink API

2016-08-26 21:38:41 -07:00