From 0de9ecec3a00c83124d323ddb5917a28a98e1190 Mon Sep 17 00:00:00 2001 From: Qais Yousef Date: Thu, 16 May 2024 16:48:56 +0000 Subject: [PATCH] powerhint: Add nodes to control per-task iowait boost It's disabled by default. Ensure camera and game mode explicitly disable it too as it is only required when auto margins are enabled for now. Ensure it is disabled when screen is off too as We don't want io activities to cause wake up on bigger cores while screen is off. Bug: 339664411 Test: PTE A/B test Flag: NONE no behavior change Signed-off-by: Qais Yousef (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:6e7e510a8eeace8d37836d6e428e13a61d66f0c1) Merged-In: Icbbfb2d332b412fa51d6d434d44d1ada8545338c Change-Id: Icbbfb2d332b412fa51d6d434d44d1ada8545338c --- perf/powerhint-caiman.json | 58 ++++++++++++++++++++++++++++++++++++++ perf/powerhint-komodo.json | 58 ++++++++++++++++++++++++++++++++++++++ perf/powerhint-tokay.json | 58 ++++++++++++++++++++++++++++++++++++++ 3 files changed, 174 insertions(+) diff --git a/perf/powerhint-caiman.json b/perf/powerhint-caiman.json index f66b1615..71d5573f 100644 --- a/perf/powerhint-caiman.json +++ b/perf/powerhint-caiman.json @@ -259,6 +259,16 @@ "DefaultIndex": 2, "ResetOnInit": true }, + { + "Name": "PerTaskMaxIowaitBoost", + "Path": "/proc/vendor_sched/per_task_iowait_boost_max_value", + "Values": [ + "0", + "512" + ], + "DefaultIndex": 0, + "ResetOnInit": true + }, { "Name": "CPUUClampMaxFilterEnable", "Path": "/proc/vendor_sched/uclamp_max_filter_enable", @@ -1343,6 +1353,12 @@ "Duration": 0, "Value": "0" }, + { + "PowerHint": "DISPLAY_INACTIVE", + "Node": "PerTaskMaxIowaitBoost", + "Duration": 0, + "Value": "0" + }, { "PowerHint": "CAMERA_LAUNCH", "Node": "CPUSkipMask", @@ -1877,6 +1893,12 @@ "Duration": 0, "Value": "0" }, + { + "PowerHint": "CAMERA_STREAMING_EXTREME", + "Node": "PerTaskMaxIowaitBoost", + "Duration": 0, + "Value": "0" + }, { "PowerHint": "CAMERA_STREAMING_EXTREME", "Node": "CPULittleClusterDownRateLimitUs", @@ -2045,6 +2067,12 @@ "Duration": 0, "Value": "0" }, + { + "PowerHint": "CAMERA_STREAMING_HIGH", + "Node": "PerTaskMaxIowaitBoost", + "Duration": 0, + "Value": "0" + }, { "PowerHint": "CAMERA_STREAMING_HIGH", "Node": "CPULittleClusterDownRateLimitUs", @@ -2237,6 +2265,12 @@ "Duration": 0, "Value": "0" }, + { + "PowerHint": "CAMERA_STREAMING_STANDARD", + "Node": "PerTaskMaxIowaitBoost", + "Duration": 0, + "Value": "0" + }, { "PowerHint": "CAMERA_STREAMING_STANDARD", "Node": "CPULittleClusterDownRateLimitUs", @@ -2345,6 +2379,12 @@ "Duration": 0, "Value": "0" }, + { + "PowerHint": "CAMERA_STREAMING_LOW", + "Node": "PerTaskMaxIowaitBoost", + "Duration": 0, + "Value": "0" + }, { "PowerHint": "CAMERA_STREAMING_LOW", "Node": "CPULittleClusterDownRateLimitUs", @@ -2573,6 +2613,12 @@ "Duration": 0, "Value": "0" }, + { + "PowerHint": "CAMERA_STREAMING_VIDEO_CALL", + "Node": "PerTaskMaxIowaitBoost", + "Duration": 0, + "Value": "0" + }, { "PowerHint": "CAMERA_STREAMING_VIDEO_CALL", "Node": "CPUDVFSHeadroom", @@ -3126,6 +3172,12 @@ "Duration": 0, "Value": "2" }, + { + "PowerHint": "GAME", + "Node": "PerTaskMaxIowaitBoost", + "Duration": 0, + "Value": "0" + }, { "PowerHint": "FACE_UNLOCK_BOOST", "Node": "CPUMidClusterMaxFreq", @@ -3216,6 +3268,12 @@ "Duration": 0, "Value": "0" }, + { + "PowerHint": "CAMERA_PROJECT11", + "Node": "PerTaskMaxIowaitBoost", + "Duration": 0, + "Value": "0" + }, { "PowerHint": "CAMERA_PROJECT11", "Node": "CPULittleClusterDownRateLimitUs", diff --git a/perf/powerhint-komodo.json b/perf/powerhint-komodo.json index ac203089..1a4f6962 100644 --- a/perf/powerhint-komodo.json +++ b/perf/powerhint-komodo.json @@ -259,6 +259,16 @@ "DefaultIndex": 2, "ResetOnInit": true }, + { + "Name": "PerTaskMaxIowaitBoost", + "Path": "/proc/vendor_sched/per_task_iowait_boost_max_value", + "Values": [ + "0", + "512" + ], + "DefaultIndex": 0, + "ResetOnInit": true + }, { "Name": "CPUUClampMaxFilterEnable", "Path": "/proc/vendor_sched/uclamp_max_filter_enable", @@ -1343,6 +1353,12 @@ "Duration": 0, "Value": "0" }, + { + "PowerHint": "DISPLAY_INACTIVE", + "Node": "PerTaskMaxIowaitBoost", + "Duration": 0, + "Value": "0" + }, { "PowerHint": "CAMERA_LAUNCH", "Node": "CPUSkipMask", @@ -1877,6 +1893,12 @@ "Duration": 0, "Value": "0" }, + { + "PowerHint": "CAMERA_STREAMING_EXTREME", + "Node": "PerTaskMaxIowaitBoost", + "Duration": 0, + "Value": "0" + }, { "PowerHint": "CAMERA_STREAMING_EXTREME", "Node": "CPULittleClusterDownRateLimitUs", @@ -2045,6 +2067,12 @@ "Duration": 0, "Value": "0" }, + { + "PowerHint": "CAMERA_STREAMING_HIGH", + "Node": "PerTaskMaxIowaitBoost", + "Duration": 0, + "Value": "0" + }, { "PowerHint": "CAMERA_STREAMING_HIGH", "Node": "CPULittleClusterDownRateLimitUs", @@ -2237,6 +2265,12 @@ "Duration": 0, "Value": "0" }, + { + "PowerHint": "CAMERA_STREAMING_STANDARD", + "Node": "PerTaskMaxIowaitBoost", + "Duration": 0, + "Value": "0" + }, { "PowerHint": "CAMERA_STREAMING_STANDARD", "Node": "CPULittleClusterDownRateLimitUs", @@ -2345,6 +2379,12 @@ "Duration": 0, "Value": "0" }, + { + "PowerHint": "CAMERA_STREAMING_LOW", + "Node": "PerTaskMaxIowaitBoost", + "Duration": 0, + "Value": "0" + }, { "PowerHint": "CAMERA_STREAMING_LOW", "Node": "CPULittleClusterDownRateLimitUs", @@ -2573,6 +2613,12 @@ "Duration": 0, "Value": "0" }, + { + "PowerHint": "CAMERA_STREAMING_VIDEO_CALL", + "Node": "PerTaskMaxIowaitBoost", + "Duration": 0, + "Value": "0" + }, { "PowerHint": "CAMERA_STREAMING_VIDEO_CALL", "Node": "CPUDVFSHeadroom", @@ -3126,6 +3172,12 @@ "Duration": 0, "Value": "2" }, + { + "PowerHint": "GAME", + "Node": "PerTaskMaxIowaitBoost", + "Duration": 0, + "Value": "0" + }, { "PowerHint": "FACE_UNLOCK_BOOST", "Node": "CPUMidClusterMaxFreq", @@ -3216,6 +3268,12 @@ "Duration": 0, "Value": "0" }, + { + "PowerHint": "CAMERA_PROJECT11", + "Node": "PerTaskMaxIowaitBoost", + "Duration": 0, + "Value": "0" + }, { "PowerHint": "CAMERA_PROJECT11", "Node": "CPULittleClusterDownRateLimitUs", diff --git a/perf/powerhint-tokay.json b/perf/powerhint-tokay.json index f66b1615..71d5573f 100644 --- a/perf/powerhint-tokay.json +++ b/perf/powerhint-tokay.json @@ -259,6 +259,16 @@ "DefaultIndex": 2, "ResetOnInit": true }, + { + "Name": "PerTaskMaxIowaitBoost", + "Path": "/proc/vendor_sched/per_task_iowait_boost_max_value", + "Values": [ + "0", + "512" + ], + "DefaultIndex": 0, + "ResetOnInit": true + }, { "Name": "CPUUClampMaxFilterEnable", "Path": "/proc/vendor_sched/uclamp_max_filter_enable", @@ -1343,6 +1353,12 @@ "Duration": 0, "Value": "0" }, + { + "PowerHint": "DISPLAY_INACTIVE", + "Node": "PerTaskMaxIowaitBoost", + "Duration": 0, + "Value": "0" + }, { "PowerHint": "CAMERA_LAUNCH", "Node": "CPUSkipMask", @@ -1877,6 +1893,12 @@ "Duration": 0, "Value": "0" }, + { + "PowerHint": "CAMERA_STREAMING_EXTREME", + "Node": "PerTaskMaxIowaitBoost", + "Duration": 0, + "Value": "0" + }, { "PowerHint": "CAMERA_STREAMING_EXTREME", "Node": "CPULittleClusterDownRateLimitUs", @@ -2045,6 +2067,12 @@ "Duration": 0, "Value": "0" }, + { + "PowerHint": "CAMERA_STREAMING_HIGH", + "Node": "PerTaskMaxIowaitBoost", + "Duration": 0, + "Value": "0" + }, { "PowerHint": "CAMERA_STREAMING_HIGH", "Node": "CPULittleClusterDownRateLimitUs", @@ -2237,6 +2265,12 @@ "Duration": 0, "Value": "0" }, + { + "PowerHint": "CAMERA_STREAMING_STANDARD", + "Node": "PerTaskMaxIowaitBoost", + "Duration": 0, + "Value": "0" + }, { "PowerHint": "CAMERA_STREAMING_STANDARD", "Node": "CPULittleClusterDownRateLimitUs", @@ -2345,6 +2379,12 @@ "Duration": 0, "Value": "0" }, + { + "PowerHint": "CAMERA_STREAMING_LOW", + "Node": "PerTaskMaxIowaitBoost", + "Duration": 0, + "Value": "0" + }, { "PowerHint": "CAMERA_STREAMING_LOW", "Node": "CPULittleClusterDownRateLimitUs", @@ -2573,6 +2613,12 @@ "Duration": 0, "Value": "0" }, + { + "PowerHint": "CAMERA_STREAMING_VIDEO_CALL", + "Node": "PerTaskMaxIowaitBoost", + "Duration": 0, + "Value": "0" + }, { "PowerHint": "CAMERA_STREAMING_VIDEO_CALL", "Node": "CPUDVFSHeadroom", @@ -3126,6 +3172,12 @@ "Duration": 0, "Value": "2" }, + { + "PowerHint": "GAME", + "Node": "PerTaskMaxIowaitBoost", + "Duration": 0, + "Value": "0" + }, { "PowerHint": "FACE_UNLOCK_BOOST", "Node": "CPUMidClusterMaxFreq", @@ -3216,6 +3268,12 @@ "Duration": 0, "Value": "0" }, + { + "PowerHint": "CAMERA_PROJECT11", + "Node": "PerTaskMaxIowaitBoost", + "Duration": 0, + "Value": "0" + }, { "PowerHint": "CAMERA_PROJECT11", "Node": "CPULittleClusterDownRateLimitUs",