From d5db58d62821fbe2ab658bd1c0a9178aed5d25e0 Mon Sep 17 00:00:00 2001 From: "Ali K. Zadeh" Date: Fri, 12 Apr 2024 18:27:25 +0000 Subject: [PATCH] Increase SPC threshold for little and mid cores for CAMERA_STREAMING_STANDARD SPC threshold is too low for both Little and Mid cores. This CL increases this threshold to 55 for Little Core and to 30 for Mid core. Test results show lower framedrop rate in presence of background load, without having a negative impact on the power. Test: 1080p30: https://docs.google.com/spreadsheets/d/1ANQ7hCkvDR03vHVKfy_i8Eh2tyKEw2qpZmFktCACCgI/edit?resourcekey=0-JXymSV8n68bVlqG2B2MVOw#gid=839467803 Test: 4k30: https://docs.google.com/spreadsheets/d/1YBz9TahcF7iMLRC6iPCl-t_-Vx_Lu6qNTdrs_EmOvZk/edit?resourcekey=0-UarnZQ86b6Vt_LBBjeZQQg#gid=586707919 Test: 1080p120: https://docs.google.com/spreadsheets/d/1kgSEqpT24_qmMrIPGjUkxTVsqVZg5gJAWOCu7p2n02c/edit#gid=697949868 Test: Loaded: Spc Lit 55: https://docs.google.com/spreadsheets/d/1j3MBl0uyjQQmeqC-JN6pqDpYd9FI4UfQq8xXfJcwcis/edit?resourcekey=0-BsWXhyH5D6QJGU2nqfoi_Q#gid=1983120744 Test: Loaded: Spc Mid 30: 1080p30 https://docs.google.com/spreadsheets/d/1FeHEOp_XHM_NJdXeTgDi9VZY2Nql_44aJEvEVtCHWUQ/edit#gid=1505208441 Test: Loaded: Spc Mid 30: 4k30: https://docs.google.com/spreadsheets/d/137ltu2nq5aN-5gA7CxwrCVpUC3fLRE94D30hsaH0-SI/edit#gid=17725636 Bug: 304536786 Change-Id: I07c81d6c3297e54202dc8966b4306d77daf34447 --- perf/powerhint-caiman.json | 5 +++-- perf/powerhint-komodo.json | 5 +++-- perf/powerhint-ripcurrentpro.json | 5 +++-- perf/powerhint-tokay.json | 5 +++-- 4 files changed, 12 insertions(+), 8 deletions(-) diff --git a/perf/powerhint-caiman.json b/perf/powerhint-caiman.json index 9f76c720..21dfa891 100644 --- a/perf/powerhint-caiman.json +++ b/perf/powerhint-caiman.json @@ -614,6 +614,7 @@ "Path": "/sys/devices/system/cpu/cpufreq/policy0/sched_pixel/spc_threshold", "Values": [ "70", + "55", "42", "35", "30", @@ -2081,7 +2082,7 @@ "PowerHint": "CAMERA_STREAMING_STANDARD", "Node": "PMU_LIT_SPC_THRESHOLD", "Duration": 0, - "Value": "42" + "Value": "55" }, { "PowerHint": "CAMERA_STREAMING_STANDARD", @@ -2099,7 +2100,7 @@ "PowerHint": "CAMERA_STREAMING_STANDARD", "Node": "PMU_MID_SPC_THRESHOLD", "Duration": 0, - "Value": "18" + "Value": "30" }, { "PowerHint": "CAMERA_STREAMING_STANDARD", diff --git a/perf/powerhint-komodo.json b/perf/powerhint-komodo.json index 3178ba8b..8de64441 100644 --- a/perf/powerhint-komodo.json +++ b/perf/powerhint-komodo.json @@ -614,6 +614,7 @@ "Path": "/sys/devices/system/cpu/cpufreq/policy0/sched_pixel/spc_threshold", "Values": [ "70", + "55", "42", "35", "30", @@ -2081,7 +2082,7 @@ "PowerHint": "CAMERA_STREAMING_STANDARD", "Node": "PMU_LIT_SPC_THRESHOLD", "Duration": 0, - "Value": "42" + "Value": "55" }, { "PowerHint": "CAMERA_STREAMING_STANDARD", @@ -2099,7 +2100,7 @@ "PowerHint": "CAMERA_STREAMING_STANDARD", "Node": "PMU_MID_SPC_THRESHOLD", "Duration": 0, - "Value": "18" + "Value": "30" }, { "PowerHint": "CAMERA_STREAMING_STANDARD", diff --git a/perf/powerhint-ripcurrentpro.json b/perf/powerhint-ripcurrentpro.json index ef57c4ee..d2984619 100644 --- a/perf/powerhint-ripcurrentpro.json +++ b/perf/powerhint-ripcurrentpro.json @@ -697,6 +697,7 @@ "Path": "/sys/devices/system/cpu/cpufreq/policy0/sched_pixel/spc_threshold", "Values": [ "70", + "55", "42", "35", "30", @@ -2070,7 +2071,7 @@ "PowerHint": "CAMERA_STREAMING_STANDARD", "Node": "PMU_LIT_SPC_THRESHOLD", "Duration": 0, - "Value": "42" + "Value": "55" }, { "PowerHint": "CAMERA_STREAMING_STANDARD", @@ -2088,7 +2089,7 @@ "PowerHint": "CAMERA_STREAMING_STANDARD", "Node": "PMU_MID_SPC_THRESHOLD", "Duration": 0, - "Value": "18" + "Value": "30" }, { "PowerHint": "CAMERA_STREAMING_STANDARD", diff --git a/perf/powerhint-tokay.json b/perf/powerhint-tokay.json index 9f76c720..21dfa891 100644 --- a/perf/powerhint-tokay.json +++ b/perf/powerhint-tokay.json @@ -614,6 +614,7 @@ "Path": "/sys/devices/system/cpu/cpufreq/policy0/sched_pixel/spc_threshold", "Values": [ "70", + "55", "42", "35", "30", @@ -2081,7 +2082,7 @@ "PowerHint": "CAMERA_STREAMING_STANDARD", "Node": "PMU_LIT_SPC_THRESHOLD", "Duration": 0, - "Value": "42" + "Value": "55" }, { "PowerHint": "CAMERA_STREAMING_STANDARD", @@ -2099,7 +2100,7 @@ "PowerHint": "CAMERA_STREAMING_STANDARD", "Node": "PMU_MID_SPC_THRESHOLD", "Duration": 0, - "Value": "18" + "Value": "30" }, { "PowerHint": "CAMERA_STREAMING_STANDARD",