Wei Wang
7427169bcb
Merge "Set big core to group_cfs_skip_mask for sys group by default" into main
2024-06-17 17:08:07 +00:00
Lynn Yeh
7ebbdf444d
Merge changes from topic "pmu_fix" into 24D1-dev am: 3a4927f4ec
...
Original change: https://googleplex-android-review.googlesource.com/c/device/google/caimito/+/27765730
Change-Id: Ic8e2ed0f2659a7eebc72448d8d7458910edead3f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-13 03:06:45 +00:00
Ali K. Zadeh
7f98995d82
Update PMU thresholds with PMU ignorance logic disabled am: 8a6924bd35
...
Original change: https://googleplex-android-review.googlesource.com/c/device/google/caimito/+/27702721
Change-Id: If07b24c018a4fab6fea5c0a70718de2546d0ad76
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-13 03:06:41 +00:00
Ali K. Zadeh
f1dfb794d4
Reduce CPUDVFSHeadroom for mid and big core (for 60fps and 240fps)
...
Reducing CPUDVFSHeadroom can help save power in 60fps and 240fps
use-cases once RT threads are enabled. Even without the RT patch
(ag/27725456), we can see savings without any impact to framedrop rate.
Bug: 341495529
Test: https://docs.google.com/document/d/14djeCdDIjDy9wqtYc4C9OPnp7sOx3HfbQz4dIZarvVE
Change-Id: Ib16a52d83669c5e9705d80c48b7097e102cc807f
2024-06-12 23:43:15 +00:00
Ali K. Zadeh
8a6924bd35
Update PMU thresholds with PMU ignorance logic disabled
...
pa/2830448 removes the core ignorance logic in PMU and causes the
behavior of PMU to change. With the new PMU logic, we need to re-tune
all the SPC thresholds for camera use-cases. This CL adjusts SPC
thresholds accordingly, so that we do not have power regression once the
PMU change in the kernel is merged.
Bug: 341495529
Test: https://docs.google.com/document/d/1IZDKtnyEnMZcakaPzQHtF23az6EjCTRGw3SdWt0Up68/edit?usp=sharing&resourcekey=0-ZAvo0M9HA-f-DY42vIatWA
Change-Id: Ifa10ebfa66da90832930487ef2d6b5610a7999bb
2024-06-11 00:06:52 +00:00
Michael Williams
bcd4392974
Merge "Switch Faceauth FACE_UNLOCK_BOOST Power Hint to Mid Cluster" into main
2024-06-06 15:19:29 +00:00
Minchan Kim
09e63f9519
Revert "powerhint: add proactive kill hint for camera launch"
...
Revert submission 27473137-P24_PA_KILL_HINT_24Q4
Reason for revert: will merge after mid of June
Reverted changes: /q/submissionid:27473137-P24_PA_KILL_HINT_24Q4
Change-Id: Ie6fadb9881a00486ff631ab286aca9ff062a7a40
Bug: 322916612
2024-05-30 00:58:50 +00:00
Sam Paradis
cb9eb99be0
Switch Faceauth FACE_UNLOCK_BOOST Power Hint to Mid Cluster
...
Faceauth is pinning to the mid-core for P24. Adjust the power hint to boost the appropriate cluster.
Bug:329893113
Change-Id: Ic13ad468a647c9088c03dd3d92e261f48944710d
2024-05-29 23:57:54 +00:00
Rick Yiu
8f43205282
Set big core to group_cfs_skip_mask for sys group by default
...
Let sys group tasks will run less in big core by default.
Bug: 328210236
Test: build pass
Change-Id: Ic4941e88138c8c836e1189ec89fd027b4d6bff90
2024-05-24 15:06:03 +00:00
Richard Chang
15705aa358
powerhint: add proactive kill hint for camera launch
...
Bug: 322916612
Test: local test
Change-Id: I9f65cbbb7bcb4a85afee50d1a85a753deebd1386
2024-05-23 03:46:22 +00:00
Ali K. Zadeh
c14ec8230a
60fps: change PMU max frequency for CL2 to 1164MHz
...
Bug: 340289125
Test: clock residency
(https://docs.google.com/spreadsheets/d/1TQQU5TGHE6B0xOgd77tyUyGnU-oksXi1X0Bs_vCsENE/edit#gid=1243247080 )
Test: Kibble (https://docs.google.com/spreadsheets/d/1WF9WVVeNvDSawzUtrq-L89jh1vuAootVET3vRXQTJR8/edit#gid=1987296588 )
Change-Id: I18fc6a3ffe535278d95ea32e855d3b8b8ab12b4a
2024-05-16 22:18:54 +00:00
Taeju Park
ef1f5d317a
Merge "powerhint: add PMU_FORCE_LIMIT control knob" into 24D1-dev
2024-05-10 19:07:40 +00:00
Ali K. Zadeh
0508270ad8
Merge "Enable PMU during photo capture" into 24D1-dev
2024-05-09 23:58:52 +00:00
Ali K. Zadeh
730f445f01
Enable PMU during photo capture
...
Bug: 298227152
Test: Kibble 12MP - https://docs.google.com/spreadsheets/d/1Exxzy_7CHu4RQQ_-eR2s16Ob9BpxdQZFn6GIkUmoc4k/edit?resourcekey=0-CrG5HCXn9v7iR0PFk84j2g#gid=328258859
Test: Kibble 50MP - https://docs.google.com/spreadsheets/d/1qIdxci3qRwgM_XD5rRdmQPqDrsf8VHQIqQggDh2rgGY/edit?resourcekey=0-t25YyqKalsLbrCM7ADDHlQ#gid=2134912777
Test: Kibble 12MP - repeated capture - https://docs.google.com/spreadsheets/d/1XTwC5iCaobxwCcj5QH1f_34lJysvFDv53wt4K9l8DAM/edit#gid=1477598242
Test: Kibble 50MP - repeated capture - https://docs.google.com/spreadsheets/d/17wlxE2MsRx56Vhr9IE1iBYLz1Lee1s7Bb7E_GKaBJtc/edit?resourcekey=0-Vh8vf55xZHgYnWqDESm5lA#gid=1630323952
Test: Latency 12MP - https://docs.google.com/spreadsheets/d/1xUmS4H8SmwKzrL-CScIhZABsrlCq1CZsDT9ZSWFAMwU/edit#gid=466916271
Test: Latency 50MP - https://docs.google.com/spreadsheets/d/1GUs1TVCCOD6Bv73ilxrjg99tJVq6wQ5kJfYrJ1djY54/edit#gid=1885938822
Change-Id: I5083184f9e226d42584de5b6910994f1d5d3cc52
2024-05-09 22:44:32 +00:00
Rick Yiu
d8c84c47ff
Set big core to group_cfs_skip_mask for sys group
...
Set big core to group_cfs_skip_mask for sys group when screen is off,
so that sys group tasks will run less in big core.
Bug: 328210236
Test: suspend/resume test
Change-Id: I4868ba0303e981250105b1ff69a6db6458df844a
2024-05-09 16:06:24 +00:00
Rick Yiu
1ae838086c
Merge "Revert^2 "Set big core to cpu skip mask by default"" into 24D1-dev
2024-05-08 09:33:23 +00:00
Rick Yiu
4958f15db0
Revert^2 "Set big core to cpu skip mask by default"
...
This reverts commit b64afc1747
.
Reason for revert: regression fixed
Bug: 248621289
Change-Id: Ia3479262bf7188b2abf35f5b5ec5f18b0fe63aff
Test: build pass
2024-05-07 07:39:47 +00:00
Taeju Park
3cfc93b4f6
powerhint: add PMU_FORCE_LIMIT control knob
...
Bug: 335331630
Change-Id: Idb5f21cdb98611edd07d3edcafca5699515e9bae
Signed-off-by: Taeju Park <taeju@google.com>
2024-05-06 19:33:24 +00:00
Wei Wang
c381116bd3
Merge "Revert "Set big core to cpu skip mask by default"" into 24D1-dev
2024-05-02 21:28:03 +00:00
Wei Wang
b64afc1747
Revert "Set big core to cpu skip mask by default"
...
This reverts commit 2cc7bc7c3d
.
Reason for revert: may get geekbench5/6 regressed
Bug: 338140604
Bug: 338141118
Change-Id: I76b2b98ca233fccc1f9a15c99bbb622bd7869392
2024-05-02 20:26:43 +00:00
Ali K. Zadeh
7563d4d627
Merge "Change PMU_BIG_LIMIT_FREQUENCY of 1298MHz to 1396MHz" into 24D1-dev
2024-05-02 00:49:03 +00:00
Ali K. Zadeh
32364863c3
Merge "Disable CDPreferIdle, set DSUMin to 610MHz for 60fps" into 24D1-dev
2024-04-29 20:22:15 +00:00
Ali K. Zadeh
a4151229c8
Merge "Reduce DVFSHeadroom to 1100 for CAMERA_STREAMING_STANDARD" into 24D1-dev
2024-04-26 22:03:46 +00:00
Taeju Park
635801795b
powerhint: tune default value for PMU limit parameter
...
Bug: 310237445
Change-Id: I0ed334a447afdc420655ca1733125e8ab0ab43f1
Signed-off-by: Taeju Park <taeju@google.com>
2024-04-26 18:32:42 +00:00
Wei Wang
95295f6e14
Merge "powerhint: remove lcpi parameter for PMU limit" into 24D1-dev
2024-04-26 17:49:54 +00:00
Ali K. Zadeh
f81ce08592
Reduce DVFSHeadroom to 1100 for CAMERA_STREAMING_STANDARD
...
With CDPreferIdle enabled, the current DVFSHeadroom pushes the CL0
frequency too high. This CL reduces this value to 1100, resulting in a
lower CPU power while performance remains mostly intact.
Bug: 304536786
Test: 1080p30fps - https://docs.google.com/spreadsheets/d/1A6Ck6Hyhs5su_xhn_6YIrLKSGc-tVIbzMIcGP4ucp-w/edit?resourcekey=0-Tj0KiAgzcejZJAUem9D2Ew#gid=2127971741
Test: 4k30fps - https://docs.google.com/spreadsheets/d/1scT3e3jeAekH6L7vZ3WtLLJsRxyxaq6JxbXKW4_tkH8/edit#gid=1060301792
Test: Photo preview - https://docs.google.com/spreadsheets/d/1W8WhkDqZccYvh4Zd0wXNFaCxWrUY-TOuXoFuBSVkk88/edit?resourcekey=0-i8drOxv0D8QioXYJNhZyGA#gid=380332953
Test: Portrait preview - https://docs.google.com/spreadsheets/d/1g9olzsTKNodKH8o0EtlcYbmLHOSbwnUVLyHAGs89tTE/edit?resourcekey=0-az_TeGJi_aH-B_DGqyTugQ#gid=524055346
Test: Video Bokeh - https://docs.google.com/spreadsheets/d/162XjO8vhbL9JFolzjqDUhaMp40NWWQP7PMr_34JS8PE/edit?resourcekey=0-gtA-l_Z0c_aDK5Y898XnrA#gid=1290026232
Test: 120fps - https://docs.google.com/spreadsheets/d/1nSA2ybed-fu6RqBdsa0JZ4CRM6002HPYiW3dJC_rxvw/edit#gid=961019110
Test: loaded test - https://docs.google.com/spreadsheets/d/1wGlPn_WdX5ZJAhppmZBh_Iih3UcSwGQeDb8R-OG2Jhk/edit?resourcekey=0-NKPtSKHqq1HwPwZDw7OljA#gid=1710307951
Change-Id: I1271c60e669dbf437467f28903254bb95a07beb0
2024-04-26 17:13:32 +00:00
Treehugger Robot
5c92151009
Merge "Set big core to cpu skip mask by default" into 24D1-dev
2024-04-26 04:14:05 +00:00
Ali K. Zadeh
9c39373a33
Disable CDPreferIdle, set DSUMin to 610MHz for 60fps
...
With MulticamRoutingNode on RT, the performance is no longer impacted by
having CDPreferIdle disabled. Additionally, this CL reduces DSUMin to
610MHz, saving overall up to 50mW in CPU power.
Test: 1080p60: https://docs.google.com/spreadsheets/d/1KoMO-hFl8t5KxLOWTn9eGSEXJqMVhDh4PRgn94_aTfk/edit?usp=sharing&resourcekey=0-DnXRxfkqmKNE8Cbh664inA
Test: 4k60: https://docs.google.com/spreadsheets/d/1PntdXFCyBL4H3kswAoIRota-FGbqSHXRZCQP3opnuj8/edit?usp=sharing&resourcekey=0--wdtPAqsz2XbsHQq67rgeg
Bug: 334945465
Bug: 304536786
Change-Id: Ic1d24975c01c65f8495a26ad9b29c97efed85ee1
2024-04-24 22:38:19 +00:00
Taeju Park
04a98d59e4
powerhint: remove lcpi parameter for PMU limit
...
PMU-based soft freq limit no longer use lcpi parameter
Bug: 295054083
Change-Id: I0d4eb0d90934dcd441e7272292c34cffa533ae25
Signed-off-by: Taeju Park <taeju@google.com>
2024-04-23 20:29:56 +00:00
Rick Yiu
2cc7bc7c3d
Set big core to cpu skip mask by default
...
Also reset the mask for launch and other camera streaming modes that
do not use it.
Bug: 248621289
Test: build pass
Change-Id: I752bcf27ac6c9064a464af54200a506fd6db03ff
2024-04-23 05:29:35 +00:00
Ali K. Zadeh
3f30ceb9e1
Change PMU_BIG_LIMIT_FREQUENCY of 1298MHz to 1396MHz
...
1298MHz is no longer in the list of available frequencies of the big
core. This CL replaces this value with the next available one which is
1396MHz.
Bug: 304536786
Test: device boot
Change-Id: I2f58c18c41494e0a0ea4b006f641f55405b72cfd
2024-04-22 21:11:25 +00:00
Ali K. Zadeh
3d27c634c1
Merge "Increase SPC thresholds for 60fps" into 24D1-dev
2024-04-22 21:11:03 +00:00
Ali K. Zadeh
c3a6514d48
Increase SPC thresholds for 60fps
...
This CL increase SPC threshold for little core to 55, and for mid core
to 32. Tests show that in a loaded scenario, framedrop rate can reduce
to almost zero, while not impacting the power in the unloaded (baseline)
scenario.
Bug: 304536786
Test: 1080p60: https://docs.google.com/spreadsheets/d/10g6mWm8q9FgnBDvC1CzYWgVM6DZZJQLdAYqf2zW209U/edit?usp=sharing
Test: 4k60: https://docs.google.com/spreadsheets/d/1Rnz5gkqgoHFz5vwq5uezy8JD1uGkq_52fqDAmBetafY/edit?usp=sharing&resourcekey=0-zAOJ1GPbHWGYdU5QlUaH3Q
Test: Loaded - 1080p60: https://docs.google.com/spreadsheets/d/1Ae1sFdXfHL0R_za3o7tUhws-4Xs3F7XktPld9Eh0xYE/edit?usp=sharing&resourcekey=0-dPQmBCXISNX_GA8s2uzLcw
Test: Loaded - 4k60: https://docs.google.com/spreadsheets/d/1QeSJjTRhyL41Bjm9wF9tKcC8mHpC02vkr6R2qJlNA1w/edit?usp=sharing
Change-Id: I077a42349527721f31eeb10c4521f48c1448374a
2024-04-19 22:02:04 +00:00
Ali K. Zadeh
c2a2ce209d
Make PreferHighcap settings for VideoCall consistent between devices
...
Bug: 323257509
Test: device boot
Change-Id: I3ba16e14c75847ef0bf08dee946ead65d762f63c
2024-04-19 18:10:58 +00:00
Ali K. Zadeh
d5db58d628
Increase SPC threshold for little and mid cores for CAMERA_STREAMING_STANDARD
...
SPC threshold is too low for both Little and Mid cores. This CL increases this
threshold to 55 for Little Core and to 30 for Mid core.
Test results show lower framedrop rate in presence of background load,
without having a negative impact on the power.
Test: 1080p30: https://docs.google.com/spreadsheets/d/1ANQ7hCkvDR03vHVKfy_i8Eh2tyKEw2qpZmFktCACCgI/edit?resourcekey=0-JXymSV8n68bVlqG2B2MVOw#gid=839467803
Test: 4k30: https://docs.google.com/spreadsheets/d/1YBz9TahcF7iMLRC6iPCl-t_-Vx_Lu6qNTdrs_EmOvZk/edit?resourcekey=0-UarnZQ86b6Vt_LBBjeZQQg#gid=586707919
Test: 1080p120: https://docs.google.com/spreadsheets/d/1kgSEqpT24_qmMrIPGjUkxTVsqVZg5gJAWOCu7p2n02c/edit#gid=697949868
Test: Loaded: Spc Lit 55: https://docs.google.com/spreadsheets/d/1j3MBl0uyjQQmeqC-JN6pqDpYd9FI4UfQq8xXfJcwcis/edit?resourcekey=0-BsWXhyH5D6QJGU2nqfoi_Q#gid=1983120744
Test: Loaded: Spc Mid 30: 1080p30 https://docs.google.com/spreadsheets/d/1FeHEOp_XHM_NJdXeTgDi9VZY2Nql_44aJEvEVtCHWUQ/edit#gid=1505208441
Test: Loaded: Spc Mid 30: 4k30: https://docs.google.com/spreadsheets/d/137ltu2nq5aN-5gA7CxwrCVpUC3fLRE94D30hsaH0-SI/edit#gid=17725636
Bug: 304536786
Change-Id: I07c81d6c3297e54202dc8966b4306d77daf34447
2024-04-18 20:46:34 +00:00
Ali K. Zadeh
7af4854125
Increase TAUClampBoost during capture to reduce latency
...
Bug: 298227152
Test: 12mp: https://docs.google.com/spreadsheets/d/1LT4Nxiffr0V63SBEhdD3W7VXtaZGTEWT7vD70yio5Is/edit?resourcekey=0-eE7u5RnJP_E0hBZX8AO7BQ#gid=1777320174
Test: 50mp: https://docs.google.com/spreadsheets/d/1n0nnfl9W_m683SsjJuA5rpvcMVhn1uK1r38P8vgYfbQ/edit?resourcekey=0-nYeECKN1CTDFfsVhNn72cA#gid=1511403903
Change-Id: I632940ec5fe01cdd026c50960657142ea589d155
2024-04-16 18:46:47 +00:00
Jimmy Shiu
b4d0311ea5
powerhint: set ADPF CPU_LOAD_UP CPU_LOAD_RESET values
...
Bug: 329483662
Test: Manual Test
Change-Id: I06d4774d81506080858127a9f992500d92b78ba7
2024-04-10 11:45:05 +00:00
Wei Wang
13d745f1af
Merge "Disable auto prefer idle explictly for some conditions" into 24D1-dev
2024-04-09 16:00:46 +00:00
Rick Yiu
3b22e46ef6
Disable auto prefer idle explictly for some conditions
...
In auto prefer idle mode, a task in top-app will be granted prefer
idle if it satisfied the conditions. So turn auto prefer idle off
if top-app prefer_idle is explictly disabled. Also turn auto prefer
off when other group enables prefer_idle explictly.
Bug: 236868627
Test: build pass
Change-Id: I6e5694dfd9b5ed30bfad31509415027d5bac71cb
2024-04-09 04:12:14 +00:00
Ali K. Zadeh
1bd6e91fec
Thermal Boost for severe thermal state
...
Bug: 299487324
Test: framedrop rates improve in
https://docs.google.com/spreadsheets/d/1XKNwe82bjAqUfEcRTCgMStI6DfSZdjsupi1rcyLynZk/edit#gid=1123570530 , https://docs.google.com/spreadsheets/d/1IHiPRzkSdtn140oaksbO8vRAGfpzUXhKBcdqrMDOFvo/edit?resourcekey=0-qyzlX1XyVmWNSv3SVc04uQ#gid=1703956858
Change-Id: I7ed38eaf28178fbf26404f195a276d72752b5671
2024-04-04 22:33:46 +00:00
Jimmy Shiu
917e155a3b
powerhint: set uclampmin_init value for applying CPU Load boost
...
Bug: 329483662
Change-Id: Ic7c08113b0ebb40ca34f44a8cea837856006517a
Test: Manual Test
2024-04-03 01:04:48 +00:00
Ali K. Zadeh
439a9ad00b
Enable CDPreferIdle for 30 and 60fps, limit CPUset to 0-6, bump up MIF clock
...
This CL enables CDPreferIdle for both 30 and 60fps use-cases. It also
limits the CDCpuset to 0-6 to avoid using the BigCore. For 60fps
use-case, it additionally bumps up the MIF frequency to 1.539GHz which
can help reduce the power regression caused by enabling CDPreferIdle
(limiting it to around 10mW regression in CPU power).
Bug: 325510979
Test: https://buganizer.corp.google.com/issues/325510979#comment23
Change-Id: Ib5312882f5de80a95c6061f636d7f1f9642b6299
2024-04-01 17:26:47 +00:00
Zoy Shen
2078e7548a
Merge "Powerhint: Enable big core reduction feature for GCA video recording CAMERA_STREAMING_HIGH and CAMERA_STREAMING_STANDARD." into 24D1-dev
2024-04-01 16:52:20 +00:00
Yuan-Yuan Wang
efffb24595
Powerhint: Enable big core reduction feature for GCA video recording CAMERA_STREAMING_HIGH and CAMERA_STREAMING_STANDARD.
...
CAMERA_STREAMING_HIGH:
CPUSkipMask to 0x80
CAMERA_STREAMING_STANDARD:
CPUSkipMask to 0x80
TAPreferIdle to 0
Bug: 321322339
Test: kibble power/framedrops (b/321322339#comment50)
Change-Id: Ie2c8dc67f45558c303d210bb0edc7e32220c099f
2024-03-27 00:48:54 +00:00
Ali K. Zadeh
f195af9aa9
Change CPU UtilThreshold, DVFSHeadroom, TAPreferHighCap for Video Call
...
Bug: 323257509
Test: odpm/framedrops (b/323257509#comment7)
Change-Id: Ifdbee11c22e47feb6d45c9d3b14ea3c0de49f92f
2024-03-26 20:23:31 +00:00
Yvonne Yip
f981fa4f81
powerhint: revert dvfs_headroom settings for camera
...
Bug: 329905546
Test: boot
Change-Id: Ieb0869ab6e57a163ead89469f426be2d3e2f76a8
Merged-In: Ieb0869ab6e57a163ead89469f426be2d3e2f76a8
2024-03-16 20:25:52 +00:00
Treehugger Robot
037acd229b
Merge changes from topic "cherrypicker-L29300030002471799:N07500030040648998" into 24D1-dev
...
* changes:
powerhint: port migration margin settings from p23
powerhint: port dvfs_headroom settings from p23
2024-03-14 00:12:06 +00:00
Yvonne Yip
8626e6e6dd
powerhint: port migration margin settings from p23
...
Bug: 316035859
Test: boot
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:62221287956f6123e6bfe761de37ff1f3cb058c6 )
Merged-In: I75a13076c9e388cb1628c80035d3f4f7a0905718
Change-Id: I75a13076c9e388cb1628c80035d3f4f7a0905718
2024-03-13 15:15:15 -07:00
Yvonne Yip
e7c6bf2d35
powerhint: port dvfs_headroom settings from p23
...
Bug: 322000346
Test: boot
Change-Id: I04cbd92a905135664059b338710993250566c9a7
Signed-off-by: Yvonne Yip <ykyyip@google.com>
(cherry picked from commit 5f65d099f0
)
Merged-In: I04cbd92a905135664059b338710993250566c9a7
2024-03-13 17:21:08 +00:00
Sam Paradis
6999cf56b2
Change FACE_UNLOCK_BOOST to Maximize CPU Frequency
...
This is part of an optimization that limits the length and prevelance of
this power hint. Strict, ultra-agression minimizes power and latency
versus always-on mid aggression.
Bug: 297964952
Change-Id: I71cb6ea9296126d576029196da87e5e76ef3ea4c
2024-03-13 17:12:22 +00:00