From 3b7c6596443144c9865caac6452b16fc9bc13d98 Mon Sep 17 00:00:00 2001 From: "Ali K. Zadeh" Date: Fri, 2 Aug 2024 20:18:38 +0000 Subject: [PATCH 01/14] [comet] Define CAMERA_MULTICAM_BOOST Port from ag/28607900 This CL defines CAMERA_MULTICAM_BOOST (with the same settings as the existing CAMERA_ZOOMING_BOOST). Having both definitions is necessary to be able to transition from zooming boost to multicam boost. Once the multicam boost flag is fully rolled out, we can remove the CAMERA_ZOOMING_BOOST. Bug: 347829135 Test: adb logcat Flag: EXEMPT resource file only change Change-Id: I0a240e1b6c82b6b0e4577005c16b589f1865c154 --- powerhint-comet.json | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/powerhint-comet.json b/powerhint-comet.json index d175bf7..cfd5a1e 100644 --- a/powerhint-comet.json +++ b/powerhint-comet.json @@ -1737,6 +1737,24 @@ "Duration": 100, "Value": "0" }, + { + "PowerHint": "CAMERA_MULTICAM_BOOST", + "Node": "CDPreferIdle", + "Duration": 100, + "Value": "1" + }, + { + "PowerHint": "CAMERA_MULTICAM_BOOST", + "Node": "AutoPreferIdle", + "Duration": 100, + "Value": "0" + }, + { + "PowerHint": "CAMERA_MULTICAM_BOOST", + "Node": "PMU_POLL", + "Duration": 100, + "Value": "0" + }, { "PowerHint": "GCA_CAMERA_SHOT_BIGCPU_RANK1", "Node": "TAPreferHighCap", From 6832fe93874c08333b1e2509437baa89a512144e Mon Sep 17 00:00:00 2001 From: Rick Yiu Date: Mon, 16 Sep 2024 08:20:20 +0000 Subject: [PATCH 02/14] Use auto prefer fit for launch Enable auto prefer fit for high prio tasks when app launch, and tune uclmap min settings for different task prio. Bug: 353885521 Flag: NONE powerhint change does not support flags Test: build pass Change-Id: I28d8023d3bc8852d6bcb771c0b2338a15f97ca37 --- powerhint-comet.json | 62 +++++++++++++++++++++++++++++++++++++------- 1 file changed, 53 insertions(+), 9 deletions(-) diff --git a/powerhint-comet.json b/powerhint-comet.json index 13c68ae..4688516 100644 --- a/powerhint-comet.json +++ b/powerhint-comet.json @@ -333,7 +333,6 @@ "Path": "/proc/vendor_sched/groups/ta/uclamp_min", "Values": [ "765", - "600", "1" ], "ResetOnInit": true @@ -347,11 +346,21 @@ ], "ResetOnInit": true }, + { + "Name": "TAUclampMinOnNiceHighValue", + "Path": "/proc/vendor_sched/groups/ta/uclamp_min_on_nice_high_value", + "Values": [ + "765", + "0" + ], + "ResetOnInit": true + }, { "Name": "TAUclampMinOnNiceMidValue", "Path": "/proc/vendor_sched/groups/ta/uclamp_min_on_nice_mid_value", "Values": [ "600", + "590", "0" ], "ResetOnInit": true @@ -360,6 +369,7 @@ "Name": "TAUclampMinOnNiceHighPrio", "Path": "/proc/vendor_sched/groups/ta/uclamp_min_on_nice_high_prio", "Values": [ + "110", "119", "120" ], @@ -370,6 +380,7 @@ "Path": "/proc/vendor_sched/groups/ta/uclamp_min_on_nice_mid_prio", "Values": [ "128", + "139", "130" ], "ResetOnInit": true @@ -484,6 +495,15 @@ ], "ResetOnInit": true }, + { + "Name": "TAAutoPreferFit", + "Path": "/proc/vendor_sched/groups/ta/auto_prefer_fit", + "Values": [ + "1", + "0" + ], + "ResetOnInit": true + }, { "Name": "TAPreferredIdleMaskHigh", "Path": "/proc/vendor_sched/groups/ta/preferred_idle_mask_high", @@ -1035,12 +1055,6 @@ "Duration": 5000, "Value": "512" }, - { - "PowerHint": "LAUNCH", - "Node": "TAUClampBoost", - "Duration": 5000, - "Value": "765" - }, { "PowerHint": "LAUNCH", "Node": "FGUClampBoost", @@ -1224,6 +1238,12 @@ "Duration": 5000, "Value": "1" }, + { + "PowerHint": "LAUNCH", + "Node": "TAAutoPreferFit", + "Duration": 5000, + "Value": "1" + }, { "PowerHint": "LAUNCH", "Node": "TAPreferredIdleMaskHigh", @@ -1232,9 +1252,33 @@ }, { "PowerHint": "LAUNCH", - "Node": "TAPreferredIdleMaskMid", + "Node": "TAUclampMinOnNiceEnable", "Duration": 5000, - "Value": "0xff" + "Value": "1" + }, + { + "PowerHint": "LAUNCH", + "Node": "TAUclampMinOnNiceHighValue", + "Duration": 5000, + "Value": "765" + }, + { + "PowerHint": "LAUNCH", + "Node": "TAUclampMinOnNiceHighPrio", + "Duration": 5000, + "Value": "110" + }, + { + "PowerHint": "LAUNCH", + "Node": "TAUclampMinOnNiceMidValue", + "Duration": 5000, + "Value": "590" + }, + { + "PowerHint": "LAUNCH", + "Node": "TAUclampMinOnNiceMidPrio", + "Duration": 5000, + "Value": "139" }, { "PowerHint": "LAUNCH", From e538262d285b41d25da5cfbb74721ab7009c6f21 Mon Sep 17 00:00:00 2001 From: Wei Li Date: Tue, 8 Oct 2024 21:28:53 +0000 Subject: [PATCH 03/14] Convert device/google/comet/sensors/Android.mk to Android.bp. And remove device/google/comet/Android.mk which is not needed any more with this change. Bug: 372304751 Test: CIs Test: lunch comet-trunk_staging-eng && m sensors.comet Flag: EXEMPT refactor Change-Id: I1d8859d55ee086ca570dc253fb3cc93a754b7442 --- Android.mk | 30 ------------------------------ sensors/Android.bp | 33 +++++++++++++++++++++++++++++++++ sensors/Android.mk | 30 ------------------------------ 3 files changed, 33 insertions(+), 60 deletions(-) delete mode 100644 Android.mk create mode 100644 sensors/Android.bp delete mode 100644 sensors/Android.mk diff --git a/Android.mk b/Android.mk deleted file mode 100644 index 94e9394..0000000 --- a/Android.mk +++ /dev/null @@ -1,30 +0,0 @@ -# -# Copyright (C) 2011 The Android Open-Source Project -# -# Licensed under the Apache License, Version 2.0 (the "License"); -# you may not use this file except in compliance with the License. -# You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. -# - -# WARNING: Everything listed here will be built on ALL platforms, -# including x86, the universal, and the SDK. Modules must be uniquely -# named (liblights.panda), and must build everywhere, or limit themselves -# to only building on ARM if they include assembly. Individual makefiles -# are responsible for having their own logic, for fine-grained control. - -LOCAL_PATH := $(call my-dir) - -# if some modules are built directly from this directory (not subdirectories), -# their rules should be written here. - -ifneq (,$(filter $(TARGET_DEVICE),comet)) - include $(call all-makefiles-under,$(LOCAL_PATH)) -endif diff --git a/sensors/Android.bp b/sensors/Android.bp new file mode 100644 index 0000000..1ff0b9b --- /dev/null +++ b/sensors/Android.bp @@ -0,0 +1,33 @@ +// Copyright (C) 2009 The Android Open Source Project +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +package { + default_applicable_licenses: [ + "device_google_comet_license", + ], +} + +// HAL module implementation stored in +// hw/..so +cc_library_shared { + name: "sensors.comet", + relative_install_path: "hw", + shared_libs: [ + "liblog", + "libcutils", + "libhardware", + ], + srcs: ["sensors_dummy.c"], + proprietary: true, +} diff --git a/sensors/Android.mk b/sensors/Android.mk deleted file mode 100644 index 60bb82d..0000000 --- a/sensors/Android.mk +++ /dev/null @@ -1,30 +0,0 @@ -# Copyright (C) 2009 The Android Open Source Project -# -# Licensed under the Apache License, Version 2.0 (the "License"); -# you may not use this file except in compliance with the License. -# You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. - -LOCAL_PATH := $(call my-dir) - -# HAL module implementation stored in -# hw/..so -include $(CLEAR_VARS) - -LOCAL_MODULE_RELATIVE_PATH := hw -LOCAL_SHARED_LIBRARIES := liblog libcutils libhardware -LOCAL_SRC_FILES := sensors_dummy.c -LOCAL_MODULE := sensors.comet -LOCAL_LICENSE_KINDS := SPDX-license-identifier-Apache-2.0 -LOCAL_LICENSE_CONDITIONS := notice -LOCAL_NOTICE_FILE := $(LOCAL_PATH)/../NOTICE -LOCAL_PROPRIETARY_MODULE := true - -include $(BUILD_SHARED_LIBRARY) From dcc77598de87159d6605b70838c8862e14231412 Mon Sep 17 00:00:00 2001 From: Yvonne Yip Date: Wed, 9 Oct 2024 12:53:03 -0700 Subject: [PATCH 04/14] powerhint: enable auto_prefer_idle in games Bug: 353987938 Test: manual testing Flag: NONE powerhint Change-Id: I70bf789a476553f05ee016daec24592076daf283 --- powerhint-comet.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/powerhint-comet.json b/powerhint-comet.json index 2695060..22a479b 100644 --- a/powerhint-comet.json +++ b/powerhint-comet.json @@ -3309,7 +3309,7 @@ "PowerHint": "GAME", "Node": "AutoPreferIdle", "Duration": 0, - "Value": "0" + "Value": "1" }, { "PowerHint": "GAME", From f1815b79fba078f34a961c06f5825304befd67dc Mon Sep 17 00:00:00 2001 From: Rick Yiu Date: Thu, 10 Oct 2024 12:53:44 +0000 Subject: [PATCH 05/14] Enable TA and FG prefer idle for some camera streams These streams do not disable TA or FG prefer idle, so restore it. Bug: 236868627 Flag: NONE powerhint change does not support flags Test: build pass Change-Id: Ia98132e94c6572165687cb4437492ab0669f9427 --- powerhint-comet.json | 42 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 42 insertions(+) diff --git a/powerhint-comet.json b/powerhint-comet.json index 22a479b..6f2e0e7 100644 --- a/powerhint-comet.json +++ b/powerhint-comet.json @@ -2116,6 +2116,12 @@ "Duration": 0, "Value": "0" }, + { + "PowerHint": "CAMERA_STREAMING_EXTREME", + "Node": "FGPreferIdle", + "Duration": 0, + "Value": "1" + }, { "PowerHint": "CAMERA_STREAMING_EXTREME", "Node": "AutoPreferIdle", @@ -2302,6 +2308,12 @@ "Duration": 0, "Value": "0" }, + { + "PowerHint": "CAMERA_STREAMING_HIGH", + "Node": "FGPreferIdle", + "Duration": 0, + "Value": "1" + }, { "PowerHint": "CAMERA_STREAMING_HIGH", "Node": "CDPreferIdle", @@ -2494,6 +2506,12 @@ "Duration": 0, "Value": "0" }, + { + "PowerHint": "CAMERA_STREAMING_STANDARD", + "Node": "FGPreferIdle", + "Duration": 0, + "Value": "1" + }, { "PowerHint": "CAMERA_STREAMING_STANDARD", "Node": "MemFreq", @@ -2548,6 +2566,18 @@ "Duration": 0, "Value": "4" }, + { + "PowerHint": "CAMERA_STREAMING_LOW", + "Node": "TAPreferIdle", + "Duration": 0, + "Value": "1" + }, + { + "PowerHint": "CAMERA_STREAMING_LOW", + "Node": "FGPreferIdle", + "Duration": 0, + "Value": "1" + }, { "PowerHint": "CAMERA_STREAMING_LOW", "Node": "AutoPreferIdle", @@ -2710,6 +2740,12 @@ "Duration": 0, "Value": "0" }, + { + "PowerHint": "CAMERA_STREAMING_VIDEO_CALL", + "Node": "FGPreferIdle", + "Duration": 0, + "Value": "1" + }, { "PowerHint": "CAMERA_STREAMING_VIDEO_CALL", "Node": "AutoPreferIdle", @@ -3575,6 +3611,12 @@ "Duration": 0, "Value": "0" }, + { + "PowerHint": "CAMERA_PROJECT11", + "Node": "FGPreferIdle", + "Duration": 0, + "Value": "1" + }, { "PowerHint": "CAMERA_PROJECT11", "Node": "MemFreq", From 4b523ba99ba514863a50a6fe3eefe54e38ab89d4 Mon Sep 17 00:00:00 2001 From: Wei Li Date: Fri, 11 Oct 2024 19:42:36 +0000 Subject: [PATCH 06/14] Convert device/google/comet/sensors/Android.mk to Android.bp. And remove device/google/comet/Android.mk which is not needed any more with this change. Bug: 372304751 Test: CIs Test: lunch comet-trunk_staging-eng && m sensors.comet Flag: EXEMPT refactor (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:e538262d285b41d25da5cfbb74721ab7009c6f21) Merged-In: I1d8859d55ee086ca570dc253fb3cc93a754b7442 Change-Id: I1d8859d55ee086ca570dc253fb3cc93a754b7442 --- Android.mk | 30 ------------------------------ sensors/Android.bp | 33 +++++++++++++++++++++++++++++++++ sensors/Android.mk | 30 ------------------------------ 3 files changed, 33 insertions(+), 60 deletions(-) delete mode 100644 Android.mk create mode 100644 sensors/Android.bp delete mode 100644 sensors/Android.mk diff --git a/Android.mk b/Android.mk deleted file mode 100644 index 94e9394..0000000 --- a/Android.mk +++ /dev/null @@ -1,30 +0,0 @@ -# -# Copyright (C) 2011 The Android Open-Source Project -# -# Licensed under the Apache License, Version 2.0 (the "License"); -# you may not use this file except in compliance with the License. -# You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. -# - -# WARNING: Everything listed here will be built on ALL platforms, -# including x86, the universal, and the SDK. Modules must be uniquely -# named (liblights.panda), and must build everywhere, or limit themselves -# to only building on ARM if they include assembly. Individual makefiles -# are responsible for having their own logic, for fine-grained control. - -LOCAL_PATH := $(call my-dir) - -# if some modules are built directly from this directory (not subdirectories), -# their rules should be written here. - -ifneq (,$(filter $(TARGET_DEVICE),comet)) - include $(call all-makefiles-under,$(LOCAL_PATH)) -endif diff --git a/sensors/Android.bp b/sensors/Android.bp new file mode 100644 index 0000000..1ff0b9b --- /dev/null +++ b/sensors/Android.bp @@ -0,0 +1,33 @@ +// Copyright (C) 2009 The Android Open Source Project +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +package { + default_applicable_licenses: [ + "device_google_comet_license", + ], +} + +// HAL module implementation stored in +// hw/..so +cc_library_shared { + name: "sensors.comet", + relative_install_path: "hw", + shared_libs: [ + "liblog", + "libcutils", + "libhardware", + ], + srcs: ["sensors_dummy.c"], + proprietary: true, +} diff --git a/sensors/Android.mk b/sensors/Android.mk deleted file mode 100644 index 60bb82d..0000000 --- a/sensors/Android.mk +++ /dev/null @@ -1,30 +0,0 @@ -# Copyright (C) 2009 The Android Open Source Project -# -# Licensed under the Apache License, Version 2.0 (the "License"); -# you may not use this file except in compliance with the License. -# You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. - -LOCAL_PATH := $(call my-dir) - -# HAL module implementation stored in -# hw/..so -include $(CLEAR_VARS) - -LOCAL_MODULE_RELATIVE_PATH := hw -LOCAL_SHARED_LIBRARIES := liblog libcutils libhardware -LOCAL_SRC_FILES := sensors_dummy.c -LOCAL_MODULE := sensors.comet -LOCAL_LICENSE_KINDS := SPDX-license-identifier-Apache-2.0 -LOCAL_LICENSE_CONDITIONS := notice -LOCAL_NOTICE_FILE := $(LOCAL_PATH)/../NOTICE -LOCAL_PROPRIETARY_MODULE := true - -include $(BUILD_SHARED_LIBRARY) From e227bcf57ad5b3928d2fd52954d763a0e7c5db74 Mon Sep 17 00:00:00 2001 From: Jimi Chen Date: Tue, 15 Oct 2024 20:42:10 +0800 Subject: [PATCH 07/14] add fatp_camera_eeprom_inspector for comet Bug: 356518766 Test: adb shell vendor/bin/camera_eeprom_inspector Flag: NONE new tool Change-Id: Icc4a29c24f5e534ca6750df4b9251ba69e3b735e --- factory_comet.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/factory_comet.mk b/factory_comet.mk index 6797bfd..c72079b 100644 --- a/factory_comet.mk +++ b/factory_comet.mk @@ -45,6 +45,7 @@ PRODUCT_PACKAGES += \ # Factory binary of camera PRODUCT_PACKAGES += fatp_ct3_wide_hat_tool fatp_ct3_tele_hat_tool fatp_ct3_ultrawide_hat_tool +PRODUCT_PACKAGES += fatp_camera_eeprom_inspector PRODUCT_WITHOUT_TTS_VOICE_PACKS := true From 552f4d3457cdef154ca8b99982beef81d0b62c98 Mon Sep 17 00:00:00 2001 From: Wen Chang Liu Date: Wed, 16 Oct 2024 01:39:53 +0000 Subject: [PATCH 08/14] Revert "ct3: upgrade to media performance class 15" This reverts commit 55d224f15800eac3973d6d7be8518615acc52504. Reason for revert: Fallback to MPC 14, since CT3 does not support JPEG_R on front facing cameras. Bug: 372355690 Change-Id: I9abc4cf69997e8ac0b5693d504a2a3f86c264589 Flag: EXEMPT config change Test: android.hardware.camera2.cts.ExtendedCameraCharacteristicsTest --- device-comet.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/device-comet.mk b/device-comet.mk index fb2d288..df07be3 100644 --- a/device-comet.mk +++ b/device-comet.mk @@ -402,8 +402,8 @@ PRODUCT_VENDOR_PROPERTIES += \ PRODUCT_VENDOR_PROPERTIES += \ persist.vendor.camera.exif_reveal_make_model=true -# Media Performance Class 15 -PRODUCT_PRODUCT_PROPERTIES += ro.odm.build.media_performance_class=35 +# Media Performance Class 14 +PRODUCT_PRODUCT_PROPERTIES += ro.odm.build.media_performance_class=34 # OIS with system imu PRODUCT_VENDOR_PROPERTIES += \ From fc13cf0d5b40ea020c9e564ed9f035da9232c356 Mon Sep 17 00:00:00 2001 From: Megha Patil Date: Mon, 7 Oct 2024 06:03:15 +0000 Subject: [PATCH 09/14] VSS to be included only in P24 devices Add VSS ctag for comet device BUG: 369721391 Flag: EXEMPT refactor(SUPPORT_VENDOR_SATELLITE_SERVICE) Test: Manual Test(Satellite Basic Testing) Change-Id: I1044603cd264efeb8ed440b0fd8c88e4a1eb7a04 --- device-comet.mk | 2 ++ 1 file changed, 2 insertions(+) diff --git a/device-comet.mk b/device-comet.mk index 8173734..12c8f5b 100644 --- a/device-comet.mk +++ b/device-comet.mk @@ -489,6 +489,8 @@ PRODUCT_PRODUCT_PROPERTIES += \ PRODUCT_PRODUCT_PROPERTIES += \ persist.bluetooth.leaudio.allow_list=SM-R510,WF-1000XM5 +SUPPORT_VENDOR_SATELLITE_SERVICE := true + # Telephony Satellite Feature PRODUCT_COPY_FILES += \ frameworks/native/data/etc/android.hardware.telephony.satellite.xml:$(TARGET_COPY_OUT_PRODUCT)/etc/permissions/android.hardware.telephony.satellite.xml From 6893af62537d4d6f28a06626a534850b010ad02b Mon Sep 17 00:00:00 2001 From: James Huang Date: Sun, 20 Oct 2024 21:17:06 +0800 Subject: [PATCH 10/14] gps: Update official release 4.15.3_7_241024_R1 config on CT3 Add Chip_Configuration_ntn_option=2 bug: 369951938 Test: NTN test Change-Id: Id4c40653d9ac2329a2d673830755e5620ff90223 --- location/user/gps.cfg | 1 + location/userdebug/gps.cfg | 7 ++++++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/location/user/gps.cfg b/location/user/gps.cfg index 859944c..d41a982 100644 --- a/location/user/gps.cfg +++ b/location/user/gps.cfg @@ -29,6 +29,7 @@ Chip_Configuration_DCXO_CrystalType=0x11 Chip_Configuration_GNSSConstConstraintDef = 0x60FF LocTech_Constraints = 0x60FF Chip_Configuration_RfMiscCtrl = 0x80008001 +Chip_Configuration_ntn_option=2 bdsUsedInUSPolicy=2 sbasUsedInUSPolicy=2 qzssUsedInUSPolicy=2 diff --git a/location/userdebug/gps.cfg b/location/userdebug/gps.cfg index 26d28a7..0641d1f 100644 --- a/location/userdebug/gps.cfg +++ b/location/userdebug/gps.cfg @@ -115,6 +115,11 @@ Chip_Configuration_RfMiscCtrl = 0x80008001 #Chip_Configuration_RfMiscCtrl=0x8001 #Chip_Configuration_IspTestConfig=0x22242822 +#Chip_Configuration_ntn_option=0 means no NTN blackout IPC handling +#Chip_Configuration_ntn_option=1 means L1 blanking during NTN blackout period. +#Chip_Configuration_ntn_option=2 means turning GNSS off during NTN blackout period. +Chip_Configuration_ntn_option=2 + # Disable BDS in the U.S. # 0-enabled (default), 1-disabled, 2-auto(disabled in US) #gloUsedInUSPolicy=2 @@ -127,7 +132,7 @@ navicUsedInUSPolicy=2 # DFS: 0 = Disabled, 1 = Enabled (default) Chip_Configuration_FeatureCfg_DVS = 1 Chip_Configuration_FeatureCfg_DFS = 1 -# Disable MTPL +# MTPL: 0 = Disabled, 1 = Enabled Chip_Configuration_FeatureCfg_MTPL = 1 # MCW Link failure behavior: 0 = SW Assert (default), 1 = GNSS restart (hot start) Chip_Configuration_FeatureCfg_SDL_BYASS = 1 From f4b90143bb3bd676157b79ae912f319889ea3c45 Mon Sep 17 00:00:00 2001 From: Nina Chen Date: Fri, 18 Oct 2024 22:02:18 +0800 Subject: [PATCH 11/14] Modify TARGET_LINUX_KERNEL_VERSION according to build flags Bug: 374029508 Bug: 357775261 Flag: build.RELEASE_KERNEL_COMET_VERSION Change-Id: Ib2e9b2978b86ed968deeccaa4e8b55b5d27aa14b --- device-comet.mk | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/device-comet.mk b/device-comet.mk index 8173734..93c0e81 100644 --- a/device-comet.mk +++ b/device-comet.mk @@ -26,7 +26,12 @@ RELEASE_GOOGLE_BOOTLOADER_COMET_DIR ?= 24D1# Keep this for pdk TODO: b/327119000 RELEASE_GOOGLE_PRODUCT_BOOTLOADER_DIR := bootloader/$(RELEASE_GOOGLE_BOOTLOADER_COMET_DIR) $(call soong_config_set,comet_bootloader,prebuilt_dir,$(RELEASE_GOOGLE_BOOTLOADER_COMET_DIR)) +ifdef RELEASE_KERNEL_COMET_VERSION +TARGET_LINUX_KERNEL_VERSION := $(RELEASE_KERNEL_COMET_VERSION) +else TARGET_LINUX_KERNEL_VERSION ?= 6.1 +endif + ifdef RELEASE_KERNEL_COMET_DIR TARGET_KERNEL_DIR ?= $(RELEASE_KERNEL_COMET_DIR) TARGET_BOARD_KERNEL_HEADERS ?= $(RELEASE_KERNEL_COMET_DIR)/kernel-headers From 61589cef5b6cf2f0e5121a29ae0373e69a059d38 Mon Sep 17 00:00:00 2001 From: Richard Chang Date: Tue, 29 Oct 2024 08:29:08 +0000 Subject: [PATCH 12/14] powerhint: Add WriteOnly flag for PA_KILL to avoid SELinux error The node "/sys/kernel/vendor_mm/pa_kill/reclaim_kb" is write-only. So we need to add WriteOnly flag to prevent powerhal to read the node. SELinux errors: avc: denied { dac_read_search } for comm="android.hardwar" capability=2 scontext=u:r:hal_power_default:s0 tcontext=u:r:hal_power_default:s0 tclass=capability permissive=0 avc: denied { dac_override } for comm="android.hardwar" capability=1 scontext=u:r:hal_power_default:s0 tcontext=u:r:hal_power_default:s0 tclass=capability permissive=0 Bug: 350830411 Change-Id: I649e263a5371782184ce712fef3e8d42941806d7 Test: adb shell dumpsys android.hardware.power.IPower/default, check if any avc denied messages Flag: EXEMPT config json change --- powerhint-comet.json | 1 + 1 file changed, 1 insertion(+) diff --git a/powerhint-comet.json b/powerhint-comet.json index 11e9447..6877507 100644 --- a/powerhint-comet.json +++ b/powerhint-comet.json @@ -958,6 +958,7 @@ "102400", "0" ], + "WriteOnly": true, "ResetOnInit": false }, { From c9afc817e54b98452e2462c91ecd3fd1d80ecd0e Mon Sep 17 00:00:00 2001 From: silens Date: Tue, 29 Oct 2024 10:55:40 +0800 Subject: [PATCH 13/14] Remove 'RELEASE_PIXEL_BROADCAST_ENABLED'. This build flag is not used now. Test: build Bug: 376153497 Flag: EXEMPT only modify device config file Change-Id: Id007001ece60174da2c15254d3f7a1df0bc4cf2e --- device-comet.mk | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/device-comet.mk b/device-comet.mk index 394cbd9..2fa5a34 100644 --- a/device-comet.mk +++ b/device-comet.mk @@ -453,11 +453,10 @@ PRODUCT_PRODUCT_PROPERTIES += \ bluetooth.profile.ccp.server.enabled=true \ bluetooth.profile.vcp.controller.enabled=true -ifeq ($(RELEASE_PIXEL_BROADCAST_ENABLED), true) +# Bluetooth LE Audio Broadcast PRODUCT_PRODUCT_PROPERTIES += \ bluetooth.profile.bap.broadcast.assist.enabled=true \ bluetooth.profile.bap.broadcast.source.enabled=true -endif # LE Audio switcher in developer options PRODUCT_PRODUCT_PROPERTIES += \ From 6e1a6c06bc06ce87e925ae982909c2dd1bc5712f Mon Sep 17 00:00:00 2001 From: Ted Wang Date: Mon, 4 Nov 2024 06:44:11 +0000 Subject: [PATCH 14/14] [Bluetooth] Set default LDAC quality mode to ABR Bug: 351769212 Test: build and check LDAC quality mode Flag: EXEMPT Config update Change-Id: I06cebea95498b70741fe4004da15413883e17b90 --- bluetooth/bt_vendor_overlay.conf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bluetooth/bt_vendor_overlay.conf b/bluetooth/bt_vendor_overlay.conf index e593d7e..6f823bc 100644 --- a/bluetooth/bt_vendor_overlay.conf +++ b/bluetooth/bt_vendor_overlay.conf @@ -45,4 +45,4 @@ ThreadDispatcherEnabled = true # A2DP_LDAC_QUALITY_MID 1 // Equal to 660/606(kbps) # A2DP_LDAC_QUALITY_LOW 2 // Equal to 330/303(kbps) # A2DP_LDAC_QUALITY_ABR 3 // ABR mode, range: 990,660,492,396,330(kbps) -LdacDefaultQualityMode = 1 +LdacDefaultQualityMode = 3