From 6eafa43ef19c3016bc450199b1a1c03137164869 Mon Sep 17 00:00:00 2001 From: Richard Chang Date: Thu, 9 May 2024 11:02:11 +0000 Subject: [PATCH 1/3] powerhint: add proactive kill hint for camera launch Bug: 322916612 Test: local test Change-Id: I14a0aa55aeb0be55521b95f857906bbd26928e75 --- powerhint-comet.json | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/powerhint-comet.json b/powerhint-comet.json index f35315c..5e9284a 100644 --- a/powerhint-comet.json +++ b/powerhint-comet.json @@ -476,6 +476,16 @@ "Type": "Property", "ResetOnInit": true }, + { + "Name": "PowerHALLaunch", + "Path": "vendor.powerhal.is_launch", + "Values": [ + "1", + "0" + ], + "Type": "Property", + "ResetOnInit": true + }, { "Name": "BigTjOffset", "Path": "/sys/devices/platform/100a0000.BIG/offset_enabled", @@ -840,6 +850,15 @@ "67000" ], "ResetOnInit": true + }, + { + "Name": "PA_KILL", + "Path": "/sys/kernel/vendor_mm/pa_kill/reclaim_kb", + "Values": [ + "102400", + "0" + ], + "ResetOnInit": false } ], "Actions": [ @@ -1133,6 +1152,12 @@ "Duration": 5000, "Value": "1" }, + { + "PowerHint": "LAUNCH", + "Node": "PowerHALLaunch", + "Duration": 5000, + "Value": "1" + }, { "PowerHint": "LAUNCH_EXTEND", "Node": "CPUSkipMask", @@ -1306,6 +1331,13 @@ "Duration": 0, "Value": "0x80" }, + { + "PowerHint": "CAMERA_LAUNCH", + "Node": "PA_KILL", + "EnableProperty": "vendor.powerhal.is_launch", + "Duration": 0, + "Value": "102400" + }, { "PowerHint": "CAMERA_LAUNCH", "Node": "CPUSkipMask", From 37033c37c692b229913a37c8eba41ec7805f4a6a Mon Sep 17 00:00:00 2001 From: Pointer Kung Date: Mon, 27 May 2024 03:29:37 +0000 Subject: [PATCH 2/3] [Camera] Update CPU DVFSHeadroom for CAMERA_STREAMING_STANDARD/PROJECT11 and CDPreferHighCap for Video Call sync from ag/27120048 and ag/26555645 Bug: 343101802 Test: Build pass Test: Save photo preview ~38mW and 30fps/120fps recording ~12mW without frame drop impact. (https://docs.google.com/spreadsheets/d/1ibQabthI6kUL6mOxGpxDKS__1tcbRBoUUDgi2Urf6H8/edit?usp=sharing) Test: Save Meet front video call ~7mW (https://docs.google.com/spreadsheets/d/1rfDGESnMuT2KfGjtYrE7rLAJ5qt-F4DYWUYAB8anKbY/edit?usp=sharing) Change-Id: I5c5e255a035ab0c42fa8d3441051a4856fa12a7f --- powerhint-comet.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/powerhint-comet.json b/powerhint-comet.json index f66f60a..360b12f 100644 --- a/powerhint-comet.json +++ b/powerhint-comet.json @@ -2156,7 +2156,7 @@ "PowerHint": "CAMERA_STREAMING_STANDARD", "Node": "CPUDVFSHeadroom", "Duration": 0, - "Value": "1280 1100 1055" + "Value": "1100" }, { "PowerHint": "CAMERA_STREAMING_STANDARD", @@ -2336,7 +2336,7 @@ "PowerHint": "CAMERA_STREAMING_VIDEO_CALL", "Node": "CDPreferHighCap", "Duration": 0, - "Value": "1" + "Value": "0" }, { "PowerHint": "CAMERA_STREAMING_VIDEO_CALL", @@ -3135,7 +3135,7 @@ "PowerHint": "CAMERA_PROJECT11", "Node": "CPUDVFSHeadroom", "Duration": 0, - "Value": "1280 1100 1055" + "Value": "1100" }, { "PowerHint": "CAMERA_PROJECT11", From d6eb9033bddd30c32745d7cb2bf482f29844f8f4 Mon Sep 17 00:00:00 2001 From: Massimo Carli Date: Mon, 27 May 2024 15:45:24 +0000 Subject: [PATCH 3/3] Increase thin letterbox width Increase to 150px = 62dp for a better heuristic Bug: 334077350 Test: manual Change-Id: I21f2392f56789d41d7f4c7e8110c9320684fb77a --- comet/overlay/frameworks/base/core/res/res/values/config.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/comet/overlay/frameworks/base/core/res/res/values/config.xml b/comet/overlay/frameworks/base/core/res/res/values/config.xml index 81aeacc..161eff9 100644 --- a/comet/overlay/frameworks/base/core/res/res/values/config.xml +++ b/comet/overlay/frameworks/base/core/res/res/values/config.xml @@ -294,7 +294,7 @@ If W is the available width and w is the letterbox width, an app is thin letterboxed if the value here is < (W - w) / 2 If the value is < 0 the thin letterboxing policy is disabled --> - 28dp + 62dp