From 628167f508a4dcbd68249aac9a51fcd0564d6518 Mon Sep 17 00:00:00 2001 From: Nicolo' Mazzucato Date: Fri, 10 Mar 2023 08:26:16 +0000 Subject: [PATCH 1/2] Increase keyguardDrawnTimeout to reduce fold->AOD flickers This is a temporary measure to decrease the chances of flickers when folding to aod, while we work in parallel to decrease latency. According to ww metrics, Fold to AoD takes: p50: 714ms p89: 1020ms p95: 1147ms p99: 1577ms Once we hit the keyguard drawn timeout, the screen is turned on . However, in some cases sysui and launcher are not ready, and this results with the screen on while showing the unfolded layout, with a rapid transition to the folded one (according to pitot data[1], this happens in 11% of the fold->aod). This cl sets the timeout to 1700ms (slightly higher than p99). In this way, the chances to have flicker are greatly reduced, but the underlying latency problem remains. In parallel, we're looking to decrease this latency (see bug). [1] https://screenshot.googleplex.com/9gV9nEfpstkJmCt Bug: 243015678 Test: fold->aod many times, no flicker. Change-Id: I0738901279136dd7577016a3ba46dc4c5b9a86f1 --- felix/overlay/frameworks/base/core/res/res/values/config.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/felix/overlay/frameworks/base/core/res/res/values/config.xml b/felix/overlay/frameworks/base/core/res/res/values/config.xml index ad85056..7b3f23d 100644 --- a/felix/overlay/frameworks/base/core/res/res/values/config.xml +++ b/felix/overlay/frameworks/base/core/res/res/values/config.xml @@ -216,6 +216,9 @@ true + + 1700 + true From 200dfcc1295760d1bdec9bab2b8cdcc81055fe43 Mon Sep 17 00:00:00 2001 From: Bill Yi Date: Fri, 10 Mar 2023 14:46:43 -0800 Subject: [PATCH 2/2] Add UwbVendorService blobs to Felix TEST: make and flash BUG: 268260164 Change-Id: I430748e8c96d7f06cf1f86425fdb93ed3c5bcf9e --- self-extractors/extract-lists.txt | 2 ++ .../google_devices/staging/Android.mk | 16 ++++++++++++++++ .../google_devices/staging/device-partial.mk | 2 ++ 3 files changed, 20 insertions(+) diff --git a/self-extractors/extract-lists.txt b/self-extractors/extract-lists.txt index e09731b..255e82e 100644 --- a/self-extractors/extract-lists.txt +++ b/self-extractors/extract-lists.txt @@ -7,10 +7,12 @@ RADIO/radio.img \ system_ext/etc/permissions/com.shannon.imsservice.xml \ system_ext/etc/permissions/com.shannon.rcsservice.xml \ + system_ext/etc/permissions/privapp-permissions-qorvo.xml \ system_ext/lib64/libmediaadaptor.so \ system_ext/priv-app/ShannonRcs/ShannonRcs.apk \ system_ext/priv-app/ShannonIms/ShannonIms.apk \ system_ext/priv-app/QualifiedNetworksService/QualifiedNetworksService.apk \ + system_ext/priv-app/UwbVendorService/UwbVendorService.apk \ " ;; diff --git a/self-extractors/google_devices/staging/Android.mk b/self-extractors/google_devices/staging/Android.mk index 462653b..fac7172 100644 --- a/self-extractors/google_devices/staging/Android.mk +++ b/self-extractors/google_devices/staging/Android.mk @@ -70,4 +70,20 @@ LOCAL_LICENSE_CONDITIONS := notice LOCAL_NOTICE_FILE := $(LOCAL_PATH)/../COPYRIGHT $(LOCAL_PATH)/../LICENSE include $(BUILD_PREBUILT) +include $(CLEAR_VARS) +LOCAL_MODULE_SUFFIX := $(COMMON_ANDROID_PACKAGE_SUFFIX) +LOCAL_MODULE := UwbVendorService +LOCAL_MODULE_TAGS := optional +LOCAL_BUILT_MODULE_STEM := package.apk +LOCAL_SYSTEM_EXT_MODULE := true +LOCAL_PRIVILEGED_MODULE := true +LOCAL_MODULE_OWNER := qorvo +LOCAL_MODULE_CLASS := APPS +LOCAL_SRC_FILES := $(LOCAL_MODULE).apk +LOCAL_CERTIFICATE := platform +LOCAL_LICENSE_KINDS := SPDX-license-identifier-Apache-2.0 +LOCAL_LICENSE_CONDITIONS := notice +LOCAL_NOTICE_FILE := $(LOCAL_PATH)/../COPYRIGHT $(LOCAL_PATH)/../LICENSE +include $(BUILD_PREBUILT) + endif diff --git a/self-extractors/google_devices/staging/device-partial.mk b/self-extractors/google_devices/staging/device-partial.mk index 4d3d453..736b944 100644 --- a/self-extractors/google_devices/staging/device-partial.mk +++ b/self-extractors/google_devices/staging/device-partial.mk @@ -20,6 +20,7 @@ PRODUCT_PACKAGES := \ QualifiedNetworksService \ ShannonIms \ ShannonRcs \ + UwbVendorService \ PRODUCT_PACKAGES += \ libmediaadaptor \ @@ -28,4 +29,5 @@ PRODUCT_PACKAGES += \ PRODUCT_COPY_FILES := \ vendor/google_devices/felix/proprietary/com.shannon.imsservice.xml:system_ext/etc/permissions/com.shannon.imsservice.xml:samsung \ vendor/google_devices/felix/proprietary/com.shannon.rcsservice.xml:system_ext/etc/permissions/com.shannon.rcsservice.xml:samsung \ + vendor/google_devices/felix/proprietary/privapp-permissions-qorvo.xml:system_ext/etc/permissions/privapp-permissions-qorvo.xml:qorvo \