Commit graph

43 commits

Author SHA1 Message Date
Xiaofan Jiang
da6c722022 Merge "modem_uart: add modem uart log to bugreport" into main 2024-12-14 00:08:31 -08:00
kierancyphus
9a52810bab pms: Create mk file in gs-common
Bug: 382192979

Test: ran abtd test with both git_main and git_main-without-vendor
Flag: EXEMPT Cannot flag mk file changes
Change-Id: Ic7fc13ad191abb1147f35d8d4bd1fd02dc56e772
2024-12-13 10:27:37 +08:00
Xiaofan Jiang
e319e6c3e4 modem_uart: add modem uart log to bugreport
Bug: 353397822

Flag: NONE, config
Change-Id: I9668f70859796ca4475dfa0456a955ac3a7ada5d
2024-12-11 18:40:52 -08:00
Eileen Lai
8112ee64cc modem_svc: add modem_svc_sit to solve sepolicy conflicts arising from different device versions
Add modem_svc_sit to gs-common. modem_svc_sit will support devices from gs101 to zuma_pro. The shared_modem_platform will be updated to support devices after zumapro (not include).

Bug: 372400955

Flag: NONE local testing only
Change-Id: I0bcc9baf69045327e6fcca92ab8003e303db2649
2024-12-06 12:49:05 +00:00
Eileen Lai
2833eecc49 modem_svc: move shared_modem_platform related sepolicy to gs-common
Bug: 372400955

Change-Id: I8b08e5b7789a5b2bf027deed0afc97f87ca25f3f
Flag: NONE local testing only
2024-12-06 10:15:18 +00:00
Liana Kazanova (xWF)
74283c5cbe Revert "modem_svc: move shared_modem_platform related sepolicy t..."
Revert submission 30519089-move_modem_sepolicy

Reason for revert: DroidMonitor: Potential culprit for http://b/380274930 - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.

Reverted changes: /q/submissionid:30519089-move_modem_sepolicy

Change-Id: I241b3aba370f77c705ca3890151e760b4764beca
2024-11-21 17:54:12 +00:00
Eileen Lai
20bb32819d modem_svc: move shared_modem_platform related sepolicy to gs-common
Bug: 372400955


Flag: NONE local testing only
Change-Id: Ia23ff9f43ee855c2a758714d025123c071e9c288
2024-11-21 08:27:55 +00:00
Priyanka Advani (xWF)
dc8c2ed6b3 Merge "Revert^2 "Allow devices that use HIDL to find AIDL radio_ext_service"" into main 2024-09-16 21:10:24 +00:00
Priyanka Advani (xWF)
d43a6e1c5a Revert^2 "Allow devices that use HIDL to find AIDL radio_ext_service"
This reverts commit 1685969e60.

Reason for revert: Droidmonitor created revert due to b/367330939.

Change-Id: Idd70cf3d846fad1a25060ebfb6ae6a99599fd861
2024-09-16 16:58:16 +00:00
Treehugger Robot
2440c2fe6f Merge "Revert "Allow devices that use HIDL to find AIDL radio_ext_service"" into main 2024-09-16 10:30:03 +00:00
Charlie Yang
1685969e60 Revert "Allow devices that use HIDL to find AIDL radio_ext_service"
Revert submission 29238469-gril-selinux

Reason for revert: b/367183524 - build break

Reverted changes: /q/submissionid:29238469-gril-selinux

Change-Id: Ica10c6ee500389223256e328d182c9495a826b06
2024-09-16 07:41:26 +00:00
Charlie Yang
275b9c66d5 Merge "Allow devices that use HIDL to find AIDL radio_ext_service" into main 2024-09-16 06:22:22 +00:00
cey
1331d97c92 Allow devices that use HIDL to find AIDL radio_ext_service
Move the type to a common sepolicy so it can be shared.

avc:  denied  { find } for pid=6493 uid=10256 name=vendor.google.radio_ext.IRadioExt/default scontext=u:r:grilservice_app:s0:c0,c257,c512,c768 tcontext=u:object_r:default_android_service:s0 tclass=service_manager permissive=0

NO_AVC_EVIDENCE_CHECK=default_android_service not supported

Bug: 365099058
Test: manual
Flag: EXEMPT mk file
Change-Id: I9c2471792c2a423e19f1472bd7923a5284f9127e
2024-09-12 16:17:33 +08:00
danhtn
116b9d5ec1 shamp: Update shared_modem_platform HAL version to 3
Bug: 322731425

ag/29120584 provides a new V3 version

Test: `atest vts_treble_vintf_vendor_test:DeviceManifest/SingleAidlTest#HalIsServed/com_google_pixel_shared_modem_platform_ISharedModemPlatform_default_V1_84`
Flag: EXEMPT can't flag manifest changes

Change-Id: Ia91d7499f218a733906173e388a287cd591b8c01
2024-09-05 20:51:22 +00:00
Kieran Cyphus
94ef296dae shamp: Update shared_modem_platform HAL version to 2
Bug: 364363838

ag/28965951 accidentally started providing a V2 when the manifests only said V1 which broke some VTS tests.

Test: `atest vts_treble_vintf_vendor_test:DeviceManifest/SingleAidlTest#HalIsServed/com_google_pixel_shared_modem_platform_ISharedModemPlatform_default_V1_84`
Flag: EXEMPT can't flag manifest changes

Change-Id: I17113f86e9bceaa3efe2f0d4d76e8349fe2c456e
2024-09-04 21:29:37 +00:00
Frank Yu
e6358c91de Move hal_radio_ext_service related policy of grilservice_app to gs-common.
Related avc error:

avc:  denied  { find } for pid=2227 uid=10259 name=vendor.google.radio_ext.IRadioExt/default scontext=u:r:grilservice_app:s0:c3,c257,c512,c768 tcontext=u:object_r:hal_radio_ext_service:s0 tclass=service_manager permissive=0

avc:  denied  { call } for  comm="oid.grilservice" scontext=u:r:grilservice_app:s0:c3,c257,c512,c768 tcontext=u:r:hal_radioext_default:s0 tclass=binder permissive=0 app=com.google.android.grilservice

Bug: 361210953
Change-Id: Ibb8a341847b0772668b52bc01f2d087bf1874fe9
Test: Verify with test ROM
Flag: EXEMPT sepolicy refactor
2024-08-27 12:10:52 +00:00
Mahesh Kallelil
9e2bbf3257 modem: Migrate dump_modem.sh to rust
Test: adb bugreport
Bug: 286755695
Flag: EXEMPT refactor
Change-Id: I69b147263d423594a51904970ce5af05eff3b03b
Signed-off-by: Mahesh Kallelil <kallelil@google.com>
2024-08-19 14:41:29 -07:00
kierancyphus
d26d8270ff shamp: Add SEPolicy and compat matrix for shamp
Bug: 329367768

This is the basic SELinux setup for a HAL. Since this lives in
gs-common and not all pixel devices will have the corresponding vendor
manifest, this hal will have to be marked as optional.

Test: If this was configured incorrectly, then the build should fail
Doc: go/shared-modem-platform-cpp-backend
Change-Id: I6dd0ee3d68ff226e14e3bdffe2e828c1184c1a01
2024-03-14 01:50:33 +00:00
kierancyphus
c14a6a75cc shamp: Create soong config variable for vendors
Bug: 328704096

The soong config variable should be defined for all pixel products to
enforce backwards compatability (ensure that this is never built for non
enabled devices). In the case where `SHARED_MODEM_PLATFORM` is not
defined, then the soong config variable will choose the default
placeholder implmentation.

Doc: go/shared-modem-platform-cpp-backend
Test: Build for enabled and disabled targets and ensure that the
correct version of `shared_modem_platform` is being built.

Change-Id: I06ebdada2324fdd86cbb7718fd66602dd52070ea
2024-03-13 18:48:01 +08:00
kierancyphus
c6fce083cd owners: give apps and services team ownership am: dff1155fa2 am: 27366c3935 am: 537b3e88e7
Original change: https://android-review.googlesource.com/c/device/google/gs-common/+/2855244

Change-Id: Ibcc32385f0612e62b0219d94edfcdd686a625b96
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-12-01 09:01:11 +00:00
kierancyphus
537b3e88e7 owners: give apps and services team ownership am: dff1155fa2 am: 27366c3935
Original change: https://android-review.googlesource.com/c/device/google/gs-common/+/2855244

Change-Id: I9bc2ae208841dcc63705a6900871761f7b3ceb1e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-12-01 08:28:50 +00:00
kierancyphus
27366c3935 owners: give apps and services team ownership am: dff1155fa2
Original change: https://android-review.googlesource.com/c/device/google/gs-common/+/2855244

Change-Id: I96f8d8da1169f0a428112eb27f97d215282af92e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-12-01 07:57:48 +00:00
kierancyphus
dff1155fa2 owners: give apps and services team ownership
Since we have a lot of code for modem apps and services that is shared
across a lot of different devices and will live in gs-common, it would
be nice to have ownership of these files so that we can push code
without having to involve the gs-common team.

Test: N/A
Bug: N/A
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:3cf675e1f557d5dcc2358457820177a3fa6d7335)
Merged-In: I909392864ee9e0aa29f415d13869ba0083449094
Change-Id: I909392864ee9e0aa29f415d13869ba0083449094
2023-12-01 06:33:57 +00:00
kierancyphus
c7da8aa098 dump_modemlog: always move modem logs
Dynamic log mask events can occur without leaving the logging status
property as enabled, which means when dumpstate should always try to
stop modem logging so that the new logs can be copied over.

Having the copying of logs and stopping of modem logging combined in
one command is no longer an ideal design, so b/289435256 was created
to find a better solution to this.

Test: build, flash, trigger log mask event, check logs in bugreport.
Bug: 302435001
Change-Id: I56358d3f08ac1f2a6099ede14c5e17b5ebffabbd
2023-12-01 05:30:02 +00:00
kierancyphus
da3ebae5ad modem_log_constants: System props for logging
Several different services need to be able to set the output directory
for copying modem logs, as well as how many files should be copied.

Test: N/A just defining constants
Bug: 302435001
Change-Id: I3e9f2462a42e3b074810e6fb0a925a8ca026f89d
2023-12-01 05:29:52 +00:00
kierancyphus
93c22b6672 modem/modem_log_constants: create common folder
A lot of different modem related processes require reading / writing to
the same android system properties. This CL solifies them all into
one place to avoid duplication.

Test: build
Bug: 302435001
Change-Id: I113f43bb68833224f45ad91668cd327587e1649b
2023-12-01 13:27:15 +08:00
kierancyphus
0944a8db52 gs-common/modem: clock manager interface
A lot of modem code requires sleeping while vendor services do some
background processing. Since we don't want to actually sleep for unit
tests, an interface is provided here so that a fake sleep can be
injected.

Test: N/A. Directly forwards methods or does nothing.
Bug: 302435001
Change-Id: I3bcf0307156d93756d69cd9f749c88b508ba9466
2023-11-21 05:51:56 +00:00
kierancyphus
047f0aca49 dump_modemlog: move android_property_manager
android_property_manager is moved to its own folder in the root of the
modem folder. This is so that libeomservice proxy has a specific build
target to include.

Test: build, flash, check modem logs in bugreport
Bug: 302435001
Change-Id: Ifc4a0c888717f5c28cf9b642d0b978b495be29d0
2023-11-21 05:51:56 +00:00
kierancyphus
3ed60cec02 dump_modemlog: move all files to subdirectory
Since radioext has already moved to this folder, it doesn't make sense
for the base folder to be dump_modemlog. This change moves it to its
own subfolder so that we can also add more in the future.

Test: build and flash, trigger bugreport and check modem logs are there
Bug: 302435001
Change-Id: Ia83378074068526023f591d63b1e5ac4700b8103
2023-11-21 05:51:30 +00:00
Alan Chen
79e230a05b Create radio_ext aidl service declaration
Note: This is copy of the reverted commit
cbc4b64bd1 (ag/24799507) plus the fix to
the problem that caused the revert which is to mark the radio_ext
service as optional in the compatibility matrix.

Bug: 285459428
Test: manually verified dumpsys and logs that service starts without
errors
Change-Id: Ibcd427c501633a95e74e392837b41b0ef513a4a8
Merged-In: Ibcd427c501633a95e74e392837b41b0ef513a4a8
2023-10-19 07:39:05 +00:00
Alan Chen
b7f9b4a306 Create radio_ext aidl service declaration
Note: This is copy of the reverted commit
cbc4b64bd1 (ag/24799507) plus the fix to
the problem that caused the revert which is to mark the radio_ext
service as optional in the compatibility matrix.

Bug: 285459428
Test: manually verified dumpsys and logs that service starts without
errors
Change-Id: Ibcd427c501633a95e74e392837b41b0ef513a4a8
2023-10-17 02:19:40 +00:00
Sam Dubey
e5988c99b7 Revert "Add radio_ext aidl to compatibility matrix"
Reason for revert: Broke next target, b/303392497

Reverted changes: /q/submissionid:24799507-ak3_ssc_aidl

Change-Id: I20c5834b71d0695f2fd4e7bc55785895410951d1
2023-10-04 13:14:08 +00:00
Alan Chen
cbc4b64bd1 Add radio_ext aidl to compatibility matrix
Test: manual
Bug: 285459428
Change-Id: Ic07926b2af7ea980575f4909ebe742efeb39ef82
2023-10-03 03:57:42 +00:00
kierancyphus
52d632cbe7 dump_modemlog: include log mask history files in dumpstate
This was missed in the porting over from gs201/.../dumpstate.cpp.

Test: Manually trigger bugreport and ensure that LoggingHistory.csv and
LoggingMaskHistory.csv are included
Bug:284275049

Change-Id: Ia630f3f1883b338fa879cfd6ea6bdd4c2a00437c
2023-07-24 16:41:53 +08:00
Mahesh Kallelil
cf91a07183 modem: Add PCIe event stats into bugreport.
We have a new syfs file to track the retries for PCIe linkdowns
and CPL timeouts. We are adding it to the dump_modem script to
export it as part of the bugreport.

Bug: 284947288
Change-Id: I42d06ab1e479db0a7cf7b553191bf8407b3bd32f
Signed-off-by: Mahesh Kallelil <kallelil@google.com>
2023-06-06 11:35:07 -07:00
Treehugger Robot
5723261ad0 Merge "Allow dump modem log on user build" into udc-dev am: e091d0258e
Original change: https://googleplex-android-review.googlesource.com/c/device/google/gs-common/+/23510925

Change-Id: Ibbcfc0dc6d0e84f349510e63e090bcc37631765f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-02 10:00:01 +00:00
Nicole Lee
29428309f9 Allow dump modem log on user build
Bug: 285434493
Test: Trigger bugreport on user build
Change-Id: I28571f6d6e185aa32d44a71ccdae8c2f167d5e34
2023-06-02 01:35:05 +00:00
Mahesh Kallelil
f896811b34 Fix SELinux error from dump_modem
The dump_modem script requires access to wakeup_events sysfs file.
Fixing a typo that caused permission error on accessing that file.

Bug: 281815537
Change-Id: I2f225e73b8515a478b597308b8726bffe6db3a76
Signed-off-by: Mahesh Kallelil <kallelil@google.com>
2023-05-11 00:48:47 -07:00
Mahesh Kallelil
dca837f2be Add wakeup_events and logbuffer to dump_modem
Adding /dev/logbuffer_cpif and wakeup_events sysfs attribute
under cpif to the modem bugreport.

Test: Tested bugreport on P23
Bug: 278501642
Change-Id: Ic4fcc5d637a59245f966442294e180d19de27f00
Signed-off-by: Mahesh Kallelil <kallelil@google.com>
2023-05-09 00:19:26 -07:00
kadirpili
17da3cede0 dumpstate: Add radio/sim folder to bugreport
Bug: 258408885
Change-Id: I66e384aadec0005b7e6bba98d650c288192e8407
2023-03-17 02:52:15 +00:00
Adam Shih
ad76e7c24e move modem operation to dump_modemlog
Bug: 240530709
Test: adb bugreport
Change-Id: Ib1076164cdd766433d0e78068396040a6e34c774
2023-03-08 11:15:24 +08:00
Adam Shih
2a520ebbae Move modem dump log to gs-common
Bug: 240530709
Test: adb bugreport
and the following file got to dumpstate_board.bin:
extended_log_uim.txt
extended_log_os.txt
nv_normal.bin
nv_protected.bin

Change-Id: Ie6439c7487b11c564cd6c0d1266928e6b9b384ee
2023-03-06 02:37:14 +00:00
Adam Shih
e301fa20c6 move modem dump to gs-common
Bug: 250475732
Test: adb bugreport
Change-Id: Id6dc2ef02d5e32b71de1b618e5588c202a2b6243
2022-10-05 10:36:26 +08:00