From 9247e99d14904e061b7b350b016057cfd3ef333d Mon Sep 17 00:00:00 2001 From: Kelly Rossmoyer Date: Sun, 24 Apr 2022 23:22:49 +0000 Subject: [PATCH] Revert "powerstats: set time limit as timeout for AoC" Revert "powerstats: set time limit as timeout for AoC" Revert "powerstats: timeout mechanism for AoC data provider" Revert submission 17800080-power-stats-aoc-timeout Reason for revert: Causing crashes due to improper thread sync Reverted Changes: I71a9e6817:powerstats: timeout mechanism for AoC data provide... I725c00745:powerstats: set time limit as timeout for AoC I5b290a53d:powerstats: set time limit as timeout for AoC Change-Id: Iac058ba7f0984bb86c505738c1eb20b7b6ddff83 --- powerstats/Gs101CommonDataProviders.cpp | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/powerstats/Gs101CommonDataProviders.cpp b/powerstats/Gs101CommonDataProviders.cpp index 124177ca..13e6b71f 100644 --- a/powerstats/Gs101CommonDataProviders.cpp +++ b/powerstats/Gs101CommonDataProviders.cpp @@ -45,7 +45,6 @@ using aidl::android::hardware::power::stats::PowerStatsEnergyConsumer; constexpr char kBootHwSoCRev[] = "ro.boot.hw.soc.rev"; void addAoC(std::shared_ptr p) { - static const uint64_t TIMEOUT_MILLIS = 120; std::string prefix = "/sys/devices/platform/19000000.aoc/control/"; // Add AoC cores (a32, ff1, hf0, and hf1) @@ -58,7 +57,7 @@ void addAoC(std::shared_ptr p) { std::vector> coreStates = { {"DWN", "off"}, {"RET", "retention"}, {"WFI", "wfi"}}; p->addStateResidencyDataProvider(std::make_unique(coreIds, - coreStates, TIMEOUT_MILLIS)); + coreStates)); // Add AoC voltage stats std::vector> voltageIds = { @@ -69,8 +68,7 @@ void addAoC(std::shared_ptr p) { {"UUD", "ultra_underdrive"}, {"UD", "underdrive"}}; p->addStateResidencyDataProvider( - std::make_unique(voltageIds, voltageStates, - TIMEOUT_MILLIS)); + std::make_unique(voltageIds, voltageStates)); // Add AoC monitor mode std::vector> monitorIds = { @@ -80,8 +78,7 @@ void addAoC(std::shared_ptr p) { {"MON", "mode"}, }; p->addStateResidencyDataProvider( - std::make_unique(monitorIds, monitorStates, - TIMEOUT_MILLIS)); + std::make_unique(monitorIds, monitorStates)); // Add AoC restart count const GenericStateResidencyDataProvider::StateResidencyConfig restartCountConfig = {