From 050a62c778ffe5d13526c13e320f5ccabfb0d4c0 Mon Sep 17 00:00:00 2001 From: Jinyoung Jeong Date: Tue, 29 Nov 2022 11:01:39 +0000 Subject: [PATCH 1/5] [LPA][gs101] Add notification pregrant refer to b/237497128 Bug: 251705860 Test: manual Change-Id: I4c6609c0e36d7404adc4da23f91f0d0cf47285ad --- default-permissions.xml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/default-permissions.xml b/default-permissions.xml index d65d7aaf..425b93f8 100644 --- a/default-permissions.xml +++ b/default-permissions.xml @@ -162,5 +162,9 @@ + + + + - From 19f686ee479c3ce89b6cba5a18ab26fc1e7db86a Mon Sep 17 00:00:00 2001 From: Ziyi Cui Date: Thu, 17 Nov 2022 18:52:10 +0000 Subject: [PATCH 2/5] gs101: pixelstats: add pixel temperature residency stats paths Add pixel temperature residency metrics paths in sysfs paths list for gs101 Bug: 246799997 Test: Verified the existence of atom and correctness of atom stats Change-Id: I7fbf563aa3da258f72ddac2e4383af732de1c6d8 Signed-off-by: Ziyi Cui --- pixelstats/service.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/pixelstats/service.cpp b/pixelstats/service.cpp index a1fe772b..fd62a70b 100644 --- a/pixelstats/service.cpp +++ b/pixelstats/service.cpp @@ -55,6 +55,7 @@ const struct SysfsCollector::SysfsPaths sysfs_paths = { UFS_ERR_PATH(auto_hibern8_err_count) }, .AmsRatePath = "/sys/devices/platform/audiometrics/ams_rate_read_once", + .TempResidencyPath = "/sys/kernel/metrics/temp_residency/temp_residency_all/stats", }; const struct UeventListener::UeventPaths ueventPaths = { From b7b91cdb144b632f28e7c584cc5eadba02aff360 Mon Sep 17 00:00:00 2001 From: Ziyi Cui Date: Tue, 29 Nov 2022 00:13:44 +0000 Subject: [PATCH 3/5] [ DO NOT MERGE ] gs101: dumpstate: Dump Temperature Residency at bugreport At the bugreport, capture Temperature Residency metrics Bug: 246799997 Test: Test: "adb bugreport" includes temp residency metrics capture. Change-Id: I7dcc42e88c3e24506298b9dc46e0728a3eaba518 Signed-off-by: Ziyi Cui --- dumpstate/DumpstateDevice.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/dumpstate/DumpstateDevice.cpp b/dumpstate/DumpstateDevice.cpp index 631513b6..c3703d4b 100644 --- a/dumpstate/DumpstateDevice.cpp +++ b/dumpstate/DumpstateDevice.cpp @@ -520,6 +520,7 @@ void DumpstateDevice::dumpThermalSection(int fd) { DumpFileToFd(fd, "TMU_TOP fall thresholds:", "/sys/module/gs101_thermal/parameters/tmu_top_reg_dump_fall_thres"); DumpFileToFd(fd, "TMU_SUB rise thresholds:", "/sys/module/gs101_thermal/parameters/tmu_sub_reg_dump_rise_thres"); DumpFileToFd(fd, "TMU_SUB fall thresholds:", "/sys/module/gs101_thermal/parameters/tmu_sub_reg_dump_fall_thres"); + DumpFileToFd(fd, "Temperature Residency Metrics:", "/sys/kernel/metrics/temp_residency/temp_residency_all/stats"); } // Dump items related to touch From f57fca197df5d5842af39b206f39f3a2165789a3 Mon Sep 17 00:00:00 2001 From: Ziyi Cui Date: Mon, 24 Oct 2022 11:48:16 -0700 Subject: [PATCH 4/5] gs101: pixelstats: add pixel perf stats paths Add pixel perf metrics paths in sysfs paths list for gs101 Bug: 232541623 Test: Verified the existence of atom and correctness of resume latency, irq stats Signed-off-by: Ziyi Cui Change-Id: I0c4b363e93a9ee651cedc35e2e1e09a691244828 --- pixelstats/service.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pixelstats/service.cpp b/pixelstats/service.cpp index fd62a70b..eb71d45e 100644 --- a/pixelstats/service.cpp +++ b/pixelstats/service.cpp @@ -45,6 +45,8 @@ const struct SysfsCollector::SysfsPaths sysfs_paths = { .SpeakerTemperaturePath = "/sys/devices/platform/audiometrics/speaker_temp", .SpeakerExcursionPath = "/sys/devices/platform/audiometrics/speaker_excursion", .SpeakerHeartBeatPath = "/sys/devices/platform/audiometrics/speaker_heartbeat", + .ResumeLatencyMetricsPath = "/sys/kernel/metrics/resume_latency/resume_latency_metrics", + .LongIRQMetricsPath = "/sys/kernel/metrics/irq/long_irq_metrics", .UFSErrStatsPath = { UFS_ERR_PATH(pa_err_count), UFS_ERR_PATH(dl_err_count), From b9fd6571c14fb95143f011dac9e8a5128d2042ab Mon Sep 17 00:00:00 2001 From: Ziyi Cui Date: Tue, 29 Nov 2022 12:04:12 -0800 Subject: [PATCH 5/5] [DO NOT MERGE] gs101:dumpstate: Dump long irq metrics, resume latency metrics at bugreport At the bugreport, capture long irq metrics and resume latency metrics Bug: 227809911 Bug: 232541623 Test: "adb bugreport" includes metrics capture. Change-Id: Ic60cb29b4e58996e7db1dc8fa406b46840ccd446 Signed-off-by: Ziyi Cui --- dumpstate/DumpstateDevice.cpp | 6 ++++++ dumpstate/DumpstateDevice.h | 1 + 2 files changed, 7 insertions(+) diff --git a/dumpstate/DumpstateDevice.cpp b/dumpstate/DumpstateDevice.cpp index c3703d4b..2f6f1b75 100644 --- a/dumpstate/DumpstateDevice.cpp +++ b/dumpstate/DumpstateDevice.cpp @@ -270,6 +270,7 @@ DumpstateDevice::DumpstateDevice() { "camera", [this](int fd) { dumpCameraSection(fd); } }, { "trusty", [this](int fd) { dumpTrustySection(fd); } }, { "modem", [this](int fd) { dumpModemSection(fd); } }, + { "perf-metrics", [this](int fd) { dumpPerfMetricsSection(fd); } }, } { } @@ -1192,6 +1193,11 @@ static void *dumpModemThread(void *data) { return NULL; } +void DumpstateDevice::dumpPerfMetricsSection(int fd) { + DumpFileToFd(fd, "Long running IRQ metrics", "/sys/kernel/metrics/irq/long_irq_metrics"); + DumpFileToFd(fd, "Resume latency metrics", "/sys/kernel/metrics/resume_latency/resume_latency_metrics"); +} + // Methods from ::android::hardware::dumpstate::V1_0::IDumpstateDevice follow. Return DumpstateDevice::dumpstateBoard(const hidl_handle &handle) { // Ignore return value, just return an empty status. diff --git a/dumpstate/DumpstateDevice.h b/dumpstate/DumpstateDevice.h index a6be31b9..f42ec198 100644 --- a/dumpstate/DumpstateDevice.h +++ b/dumpstate/DumpstateDevice.h @@ -79,6 +79,7 @@ struct DumpstateDevice : public IDumpstateDevice { void dumpCameraSection(int fd); void dumpTrustySection(int fd); void dumpModemSection(int fd); + void dumpPerfMetricsSection(int fd); }; } // namespace implementation