From fe6dbce8df82470c754038fe7ad312434d1deaaf Mon Sep 17 00:00:00 2001 From: Michael Eastwood Date: Tue, 3 Aug 2021 12:51:15 -0700 Subject: [PATCH] Attach more CPA traces to bug reports. These are small, usually <1MB. Attaching more CPA traces gives us some buffer to ensure that the relevant trace is actually included in the bug report. Previously if the user opens one or two more camera sessions after they observe the performance issue, the trace will be missing. Bug: 191169822 Test: Build Change-Id: I4c10217c39991e80f25a7fd90eee9e8b8c5b6cdb --- dumpstate/DumpstateDevice.cpp | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/dumpstate/DumpstateDevice.cpp b/dumpstate/DumpstateDevice.cpp index 93e175a1..bac539b3 100644 --- a/dumpstate/DumpstateDevice.cpp +++ b/dumpstate/DumpstateDevice.cpp @@ -210,9 +210,10 @@ void dumpCameraLogs(int fd, const std::string &destDir) { const std::string cameraDestDir = destDir + "/camera"; RunCommandToFd(fd, "MKDIR CAMERA LOG", {"/vendor/bin/mkdir", "-p", cameraDestDir.c_str()}, CommandOptions::WithTimeout(2).Build()); - // Attach 2 latest sessions (in case the user is running concurrent sessions). - dumpLogs(fd, kCameraLogDir, cameraDestDir, 2, "session-ended-"); - dumpLogs(fd, kCameraLogDir, cameraDestDir, 2, "high-drop-rate-"); + // Attach multiple latest sessions (in case the user is running concurrent + // sessions or starts a new session after the one with performance issues). + dumpLogs(fd, kCameraLogDir, cameraDestDir, 10, "session-ended-"); + dumpLogs(fd, kCameraLogDir, cameraDestDir, 5, "high-drop-rate-"); } timepoint_t startSection(int fd, const std::string §ionName) {