From 083ba629028b15373d54f1338b1236bc3f0e8272 Mon Sep 17 00:00:00 2001 From: George Lee Date: Thu, 13 Oct 2022 12:52:20 -0700 Subject: [PATCH 1/3] bcl: Remove unused brownout boot reason sepolicy vendor_brownout_boot_reason was added under previous change. It should be added as part of follow on change to enable metric collection. Bug: 246817058 Test: Confirm brownout_boot_reason non existent Signed-off-by: George Lee Change-Id: I1fed12e851750314f53a0d6517a9eff92c44e247 --- whitechapel_pro/property.te | 1 - whitechapel_pro/property_contexts | 1 - whitechapel_pro/vendor_init.te | 1 - 3 files changed, 3 deletions(-) diff --git a/whitechapel_pro/property.te b/whitechapel_pro/property.te index 151cefc3..1bca1a73 100644 --- a/whitechapel_pro/property.te +++ b/whitechapel_pro/property.te @@ -39,5 +39,4 @@ vendor_internal_prop(vendor_telephony_app_prop) # Battery Mitigation vendor_internal_prop(vendor_mitigation_ready_prop) -vendor_internal_prop(vendor_brownout_boot_reason_prop) vendor_internal_prop(vendor_startup_bugreport_requested_prop) diff --git a/whitechapel_pro/property_contexts b/whitechapel_pro/property_contexts index 02b9ce80..814d0184 100644 --- a/whitechapel_pro/property_contexts +++ b/whitechapel_pro/property_contexts @@ -109,5 +109,4 @@ vendor.config.debug. u:object_r:vendor_telephony_app_prop: # Battery Mitigation vendor.brownout.mitigation.ready u:object_r:vendor_mitigation_ready_prop:s0 -vendor.brownout_boot_reason u:object_r:vendor_brownout_boot_reason_prop:s0 vendor.startup_bugreport_requested u:object_r:vendor_startup_bugreport_requested_prop:s0 diff --git a/whitechapel_pro/vendor_init.te b/whitechapel_pro/vendor_init.te index 0dedd097..a82ad9f1 100644 --- a/whitechapel_pro/vendor_init.te +++ b/whitechapel_pro/vendor_init.te @@ -37,5 +37,4 @@ set_prop(vendor_init, vendor_battery_defender_prop) set_prop(vendor_init, vendor_display_prop) # Battery Mitigation -set_prop(vendor_init, vendor_brownout_boot_reason_prop) set_prop(vendor_init, vendor_startup_bugreport_requested_prop) From 39ffb227b33c85dfb09cd5efd19b4177988f946e Mon Sep 17 00:00:00 2001 From: George Lee Date: Thu, 13 Oct 2022 09:19:07 -0700 Subject: [PATCH 2/3] betterbug: Add selinux policy for betterbug Enable Betterbug to read reboot reason such that Betterbug can file bugreport when *uvlo* or *ocp* is found within reboot reason. Bug: 237287659 Test: Load Betterbug for accessing boot reason property Signed-off-by: George Lee Change-Id: Id699be34d2e060ee7827737982403fd58f133c4a --- whitechapel_pro/better_bug_app.te | 6 ++++++ whitechapel_pro/seapp_contexts | 3 +++ 2 files changed, 9 insertions(+) create mode 100644 whitechapel_pro/better_bug_app.te diff --git a/whitechapel_pro/better_bug_app.te b/whitechapel_pro/better_bug_app.te new file mode 100644 index 00000000..7a8c3818 --- /dev/null +++ b/whitechapel_pro/better_bug_app.te @@ -0,0 +1,6 @@ +type better_bug_app, domain; + +userdebug_or_eng(` + app_domain(better_bug_app) + get_prop(better_bug_app, vendor_startup_bugreport_requested_prop) +') diff --git a/whitechapel_pro/seapp_contexts b/whitechapel_pro/seapp_contexts index 0fbe0333..7a908751 100644 --- a/whitechapel_pro/seapp_contexts +++ b/whitechapel_pro/seapp_contexts @@ -71,3 +71,6 @@ user=system seinfo=platform name=com.google.android.CatEngine domain=cat_engine_ # CccDkTimeSyncService user=_app isPrivApp=true name=com.google.pixel.digitalkey.timesync domain=vendor_cccdktimesync_app type=app_data_file levelFrom=all + +# BetterBug +user=_app seinfo=platform name=com.google.android.apps.internal.betterbug domain=better_bug_app type=app_data_file levelFrom=user From 5c48a9028512d067de0b4add8ce30f27a7a9203a Mon Sep 17 00:00:00 2001 From: George Lee Date: Thu, 13 Oct 2022 18:43:09 -0700 Subject: [PATCH 3/3] pixelstats: add bcl directory permission Bug: 253522156 Test: Local test $>cmd stats print-logs $>logcat | grep Signed-off-by: George Lee Change-Id: I934f6efb043893666dac88257619556e30d82751 --- whitechapel_pro/pixelstats_vendor.te | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/whitechapel_pro/pixelstats_vendor.te b/whitechapel_pro/pixelstats_vendor.te index 371bef41..d327a30d 100644 --- a/whitechapel_pro/pixelstats_vendor.te +++ b/whitechapel_pro/pixelstats_vendor.te @@ -26,3 +26,7 @@ allow pixelstats_vendor sysfs_pca:file rw_file_perms; #Thermal r_dir_file(pixelstats_vendor, sysfs_thermal) allow pixelstats_vendor sysfs_thermal:lnk_file r_file_perms; + +# BCL +allow pixelstats_vendor sysfs_bcl:dir search; +allow pixelstats_vendor sysfs_bcl:file r_file_perms;