From 617251a80a389acd7cc84ca6b106d3684e15c0cf Mon Sep 17 00:00:00 2001 From: Jim Tang Date: Fri, 4 Oct 2024 15:48:16 +0800 Subject: [PATCH 01/10] Relocate modem_svc_sit to proper places Flag: EXEMPT refactor Bug: 358485346 Test: m modem_svc_sit Change-Id: Ib47ac55c504eafd32340e66a7286be48f2ea7b48 --- device.mk | 3 --- 1 file changed, 3 deletions(-) diff --git a/device.mk b/device.mk index d20b5520..fd0eccfb 100644 --- a/device.mk +++ b/device.mk @@ -959,9 +959,6 @@ USE_EARLY_SEND_DEVICE_INFO := true ifneq ($(BOARD_WITHOUT_RADIO),true) $(call inherit-product-if-exists, vendor/samsung_slsi/telephony/$(BOARD_USES_SHARED_VENDOR_TELEPHONY)/common/device-vendor.mk) -# modem_svc_sit daemon -PRODUCT_PACKAGES += modem_svc_sit - # modem logging binary/configs PRODUCT_PACKAGES += modem_logging_control From f22f21191bc9b9c6fe6e9e0e99b91b43d20c6010 Mon Sep 17 00:00:00 2001 From: Kuen-Han Tsai Date: Wed, 9 Oct 2024 15:15:56 +0800 Subject: [PATCH 02/10] Usb: Add status check to prevent NPE This patch prevents a Null Pointer Exception in queryMoistureDetectionStatus() when getPortStatusHelper() fails to open the /sys/class/typec file. The failure results in an empty currentPortStatus vector, causing the NPE when accessing its first element. Bug: 361097811 Flag: EXEMPT bugfix Test: NPE does not occur when getPortStatusHelper() fails Change-Id: I61c9f7647aafca28b777e53f170764ddd02c060f Signed-off-by: Kuen-Han Tsai --- usb/usb/Usb.cpp | 24 ++++++++++++++---------- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/usb/usb/Usb.cpp b/usb/usb/Usb.cpp index 5b38729b..530abb8c 100644 --- a/usb/usb/Usb.cpp +++ b/usb/usb/Usb.cpp @@ -990,17 +990,21 @@ void queryVersionHelper(android::hardware::usb::Usb *usb, Status status; pthread_mutex_lock(&usb->mLock); status = getPortStatusHelper(usb, currentPortStatus); - queryMoistureDetectionStatus(usb, currentPortStatus); - queryPowerTransferStatus(usb, currentPortStatus); - queryNonCompliantChargerStatus(currentPortStatus); - queryUsbDataSession(usb, currentPortStatus); - if (usb->mCallback != NULL) { - ScopedAStatus ret = usb->mCallback->notifyPortStatusChange(*currentPortStatus, - status); - if (!ret.isOk()) - ALOGE("queryPortStatus error %s", ret.getDescription().c_str()); + if (status == Status::SUCCESS && currentPortStatus->size() > 0) { + queryMoistureDetectionStatus(usb, currentPortStatus); + queryPowerTransferStatus(usb, currentPortStatus); + queryNonCompliantChargerStatus(currentPortStatus); + queryUsbDataSession(usb, currentPortStatus); + if (usb->mCallback != NULL) { + ScopedAStatus ret = usb->mCallback->notifyPortStatusChange(*currentPortStatus, + status); + if (!ret.isOk()) + ALOGE("queryPortStatus error %s", ret.getDescription().c_str()); + } else { + ALOGI("Notifying userspace skipped. Callback is NULL"); + } } else { - ALOGI("Notifying userspace skipped. Callback is NULL"); + ALOGI("%s skipped. currentPortStatus is empty", __func__); } pthread_mutex_unlock(&usb->mLock); } From 0bfc85475d5c16b7a1aa16a5ebc1cca7d68d060e Mon Sep 17 00:00:00 2001 From: Robin Hsu Date: Wed, 2 Oct 2024 07:40:17 +0000 Subject: [PATCH 03/10] gs201: Disable kmem cgroup accounting Disable cgroup kernel memory accounting to avoid unnecessary overhead similar change ag/22891292 but now back-port to gs201 Flag: NONE kernel config Bug: 373232814 Test: pts-tradefed run commandAndExit pts -m PtsPerfWbsTestCases -t com.google.android.perfwbs.pts.KernelModuleTest and alternative tests on forrest. Change-Id: I306b3e608655dc9e5f868a1f1a79e60e5b9b40fd --- BoardConfig-common.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/BoardConfig-common.mk b/BoardConfig-common.mk index 681bb146..3783e9f6 100644 --- a/BoardConfig-common.mk +++ b/BoardConfig-common.mk @@ -49,6 +49,7 @@ BOARD_KERNEL_CMDLINE += cgroup_disable=memory BOARD_KERNEL_CMDLINE += rcupdate.rcu_expedited=1 rcu_nocbs=all rcutree.enable_rcu_lazy BOARD_KERNEL_CMDLINE += stack_depot_disable=off page_pinner=on BOARD_KERNEL_CMDLINE += swiotlb=1024 +BOARD_KERNEL_CMDLINE += cgroup.memory=nokmem BOARD_KERNEL_CMDLINE += disable_dma32=on BOARD_BOOTCONFIG += androidboot.boot_devices=14700000.ufs From c40d53b69bd9968585d1cce0a16c202798281f3c Mon Sep 17 00:00:00 2001 From: Robert Luo Date: Fri, 11 Oct 2024 12:51:54 +0800 Subject: [PATCH 04/10] [Pixel RR] Apply reviewed default permissions Pregrantting below permission(s): CALL_PHONE Flag: EXEMPT add pregranted permission in b/371912006 Bug: 336203918 Test: presubmit Change-Id: I6ef16e5571706cd865d9083ebc363a181473eea9 --- default-permissions.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/default-permissions.xml b/default-permissions.xml index afe5bc4d..45a2d303 100644 --- a/default-permissions.xml +++ b/default-permissions.xml @@ -180,7 +180,7 @@ - + From 08cc782e85fc9c4bea5c3e27a43252a60568997b Mon Sep 17 00:00:00 2001 From: Richard Chang Date: Wed, 23 Oct 2024 04:10:13 +0000 Subject: [PATCH 05/10] gs201: MCP: Set the vendor customized max cached processes to 1024. Bug: 374891496 Change-Id: I657ea431a33003b0cc3310589e9b8fa359a66fae Test: adb shell dumpsys activity | grep CUR_MAX_CACHED_PROCESSES Flag: EXEMPT config XML change --- overlay/frameworks/base/core/res/res/values/config.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/overlay/frameworks/base/core/res/res/values/config.xml b/overlay/frameworks/base/core/res/res/values/config.xml index d266ccd3..21bc5321 100644 --- a/overlay/frameworks/base/core/res/res/values/config.xml +++ b/overlay/frameworks/base/core/res/res/values/config.xml @@ -284,6 +284,9 @@ true + + 1024 +