From 3846f25d8ddcd0526b5f339ac4bfb5fa2fd91ea8 Mon Sep 17 00:00:00 2001 From: Minchan Kim Date: Wed, 27 Apr 2022 13:58:48 -0700 Subject: [PATCH 1/6] dumpstate: change page_pinner output file name Change konb name to "buffer" Bug: 230651222 Test: check dumpstate_board.txt from adb bugreport Signed-off-by: Minchan Kim Change-Id: If4a07b2b40ec078f9c4553227020aff802781919 --- dumpstate/DumpstateDevice.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/dumpstate/DumpstateDevice.cpp b/dumpstate/DumpstateDevice.cpp index a531385d..12a9f6ef 100644 --- a/dumpstate/DumpstateDevice.cpp +++ b/dumpstate/DumpstateDevice.cpp @@ -887,8 +887,7 @@ void DumpstateDevice::dumpMemorySection(int fd) { "fi; " "done"}); DumpFileToFd(fd, "dmabuf info", "/d/dma_buf/bufinfo"); - DumpFileToFd(fd, "Page Pinner - longterm pin", "/sys/kernel/debug/page_pinner/longterm_pinner"); - DumpFileToFd(fd, "Page Pinner - alloc_contig_failed", "/sys/kernel/debug/page_pinner/alloc_contig_failed"); + DumpFileToFd(fd, "Page Pinner - longterm pin", "/sys/kernel/debug/page_pinner/buffer"); } static void DumpF2FS(int fd) { From 365111bf97303e0b7d409131f4c3dabae5d203a3 Mon Sep 17 00:00:00 2001 From: Sal Savage Date: Wed, 27 Apr 2022 13:30:20 -0700 Subject: [PATCH 2/6] Use the ?= operator so BT properties can be overridden System properties set with the "=" operator cannot be overriden. This device is used elsewhere in the system and some of the properties need to be overridden. The "?=" operator will use the assigned value if no other values are assigned elsewhere, allowing for overrides. Bug: 230638462 Test: adb shell getprop | grep bluetooth Change-Id: I0e33816b9d2572d26ddd2ee8b623e0c1733accd0 --- device.mk | 42 +++++++++++++++++++++--------------------- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/device.mk b/device.mk index c30debab..d2317b9d 100644 --- a/device.mk +++ b/device.mk @@ -122,27 +122,27 @@ PRODUCT_PRODUCT_PROPERTIES += \ # Set supported Bluetooth profiles to enabled PRODUCT_PRODUCT_PROPERTIES += \ - bluetooth.profile.asha.central.enabled=true \ - bluetooth.profile.a2dp.source.enabled=true \ - bluetooth.profile.avrcp.target.enabled=true \ - bluetooth.profile.bap.broadcast.assist.enabled=true \ - bluetooth.profile.bap.unicast.client.enabled=true \ - bluetooth.profile.bas.client.enabled=true \ - bluetooth.profile.csip.set_coordinator.enabled=true \ - bluetooth.profile.gatt.enabled=true \ - bluetooth.profile.hap.client.enabled=true \ - bluetooth.profile.hfp.ag.enabled=true \ - bluetooth.profile.hid.device.enabled=true \ - bluetooth.profile.hid.host.enabled=true \ - bluetooth.profile.map.server.enabled=true \ - bluetooth.profile.mcp.server.enabled=true \ - bluetooth.profile.opp.enabled=true \ - bluetooth.profile.pan.nap.enabled=true \ - bluetooth.profile.pan.panu.enabled=true \ - bluetooth.profile.pbap.server.enabled=true \ - bluetooth.profile.sap.server.enabled=true \ - bluetooth.profile.ccp.server.enabled=true \ - bluetooth.profile.vcp.controller.enabled=true + bluetooth.profile.asha.central.enabled?=true \ + bluetooth.profile.a2dp.source.enabled?=true \ + bluetooth.profile.avrcp.target.enabled?=true \ + bluetooth.profile.bap.broadcast.assist.enabled?=true \ + bluetooth.profile.bap.unicast.client.enabled?=true \ + bluetooth.profile.bas.client.enabled?=true \ + bluetooth.profile.csip.set_coordinator.enabled?=true \ + bluetooth.profile.gatt.enabled?=true \ + bluetooth.profile.hap.client.enabled?=true \ + bluetooth.profile.hfp.ag.enabled?=true \ + bluetooth.profile.hid.device.enabled?=true \ + bluetooth.profile.hid.host.enabled?=true \ + bluetooth.profile.map.server.enabled?=true \ + bluetooth.profile.mcp.server.enabled?=true \ + bluetooth.profile.opp.enabled?=true \ + bluetooth.profile.pan.nap.enabled?=true \ + bluetooth.profile.pan.panu.enabled?=true \ + bluetooth.profile.pbap.server.enabled?=true \ + bluetooth.profile.sap.server.enabled?=true \ + bluetooth.profile.ccp.server.enabled?=true \ + bluetooth.profile.vcp.controller.enabled?=true # Carrier configuration default location PRODUCT_PROPERTY_OVERRIDES += \ From 4291e02212832b1c197f9e16172da3da98b1ab4d Mon Sep 17 00:00:00 2001 From: Alec Mouri Date: Mon, 25 Apr 2022 23:23:29 +0000 Subject: [PATCH 3/6] Force some devices to treat 170M as sRGB in SF Bug: 229442032 Test: builds, boots Change-Id: If144724a342be4a74f823aa25ff8a74fe3d2843a --- device.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/device.mk b/device.mk index d2317b9d..7dcbaec2 100644 --- a/device.mk +++ b/device.mk @@ -618,6 +618,7 @@ PRODUCT_DEFAULT_PROPERTY_OVERRIDES += debug.sf.early.app.duration=16600000 PRODUCT_DEFAULT_PROPERTY_OVERRIDES += debug.sf.earlyGl.sf.duration=16600000 PRODUCT_DEFAULT_PROPERTY_OVERRIDES += debug.sf.earlyGl.app.duration=16600000 PRODUCT_DEFAULT_PROPERTY_OVERRIDES += debug.sf.frame_rate_multiple_threshold=120 +PRODUCT_DEFAULT_PROPERTY_OVERRIDES += debug.sf.treat_170m_as_sRGB=1 PRODUCT_DEFAULT_PROPERTY_OVERRIDES += ro.surface_flinger.enable_layer_caching=true PRODUCT_DEFAULT_PROPERTY_OVERRIDES += ro.surface_flinger.set_idle_timer_ms?=80 From ebec6a203ca779b7cb52b6c25fb87067145dea82 Mon Sep 17 00:00:00 2001 From: Yichi Chen Date: Fri, 29 Apr 2022 05:09:13 +0800 Subject: [PATCH 4/6] SF: set debug.sf.layer_caching_active_layer_timeout_ms to 1000 Avoid SF cache thrashing in some cases. Bug: 189928400 Bug: 226447218 Test: no flicking issue with the testbuld (removed displaycolor fix) and flicking happens after set the prop to 0 Change-Id: I24aa79001ec21cff18ae5ac8ff988f70ed121061 --- device.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/device.mk b/device.mk index 7dcbaec2..3efa035a 100644 --- a/device.mk +++ b/device.mk @@ -618,6 +618,7 @@ PRODUCT_DEFAULT_PROPERTY_OVERRIDES += debug.sf.early.app.duration=16600000 PRODUCT_DEFAULT_PROPERTY_OVERRIDES += debug.sf.earlyGl.sf.duration=16600000 PRODUCT_DEFAULT_PROPERTY_OVERRIDES += debug.sf.earlyGl.app.duration=16600000 PRODUCT_DEFAULT_PROPERTY_OVERRIDES += debug.sf.frame_rate_multiple_threshold=120 +PRODUCT_DEFAULT_PROPERTY_OVERRIDES += debug.sf.layer_caching_active_layer_timeout_ms=1000 PRODUCT_DEFAULT_PROPERTY_OVERRIDES += debug.sf.treat_170m_as_sRGB=1 PRODUCT_DEFAULT_PROPERTY_OVERRIDES += ro.surface_flinger.enable_layer_caching=true From 4a4cb90798cd09a4e2086e7ce698cfee51b7f471 Mon Sep 17 00:00:00 2001 From: Sal Savage Date: Mon, 25 Apr 2022 16:42:52 -0700 Subject: [PATCH 5/6] Set default the Bluetooth class of device The class of device is a string with a list of uint8t values: 90,2,12 The meaning is as follows: {Service Field, Major class, Minor class} Service Field: 0x5A -> 90 Bit 17: Networking Bit 19: Capturing Bit 20: Object Transfer Bit 22: Telephony MAJOR_CLASS: 0x02 -> 2 (Phone) MINOR_CLASS: 0x0C -> 12 (Smart Phone) Bug: 217452259 Test: make -j; -- check that bluetooth.device.class_of_device is correct Change-Id: I3f5bb98159ee5c3f01ba51d7064e262aa9da457f --- device.mk | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/device.mk b/device.mk index 3efa035a..f3083467 100644 --- a/device.mk +++ b/device.mk @@ -120,6 +120,17 @@ PRODUCT_PRODUCT_PROPERTIES += \ PRODUCT_PRODUCT_PROPERTIES += \ persist.vendor.ril.camp_on_earlier=1 +# Set the Bluetooth Class of Device +# Service Field: 0x5A -> 90 +# Bit 17: Networking +# Bit 19: Capturing +# Bit 20: Object Transfer +# Bit 22: Telephony +# MAJOR_CLASS: 0x02 -> 2 (Phone) +# MINOR_CLASS: 0x0C -> 12 (Smart Phone) +PRODUCT_PRODUCT_PROPERTIES += \ + bluetooth.device.class_of_device=90,2,12 + # Set supported Bluetooth profiles to enabled PRODUCT_PRODUCT_PROPERTIES += \ bluetooth.profile.asha.central.enabled?=true \ From 520ebd6475f9da82361d4e34f6b3e8a9cb327639 Mon Sep 17 00:00:00 2001 From: Minchan Kim Date: Wed, 27 Apr 2022 13:58:48 -0700 Subject: [PATCH 6/6] dumpstate: change page_pinner output file name Change konb name to "buffer" Bug: 230651222 Test: check dumpstate_board.txt from adb bugreport Signed-off-by: Minchan Kim Change-Id: I80674d8728bab322ae2acdb3a8cd0ffaff39c977 --- dumpstate/Dumpstate.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/dumpstate/Dumpstate.cpp b/dumpstate/Dumpstate.cpp index aaec2521..3f95f6a2 100644 --- a/dumpstate/Dumpstate.cpp +++ b/dumpstate/Dumpstate.cpp @@ -885,8 +885,7 @@ void Dumpstate::dumpMemorySection(int fd) { "fi; " "done"}); DumpFileToFd(fd, "dmabuf info", "/d/dma_buf/bufinfo"); - DumpFileToFd(fd, "Page Pinner - longterm pin", "/sys/kernel/debug/page_pinner/longterm_pinner"); - DumpFileToFd(fd, "Page Pinner - alloc_contig_failed", "/sys/kernel/debug/page_pinner/alloc_contig_failed"); + DumpFileToFd(fd, "Page Pinner - longterm pin", "/sys/kernel/debug/page_pinner/buffer"); } static void DumpF2FS(int fd) {