From f2fa5042d82955f4729f2f9bf9ad4d0d6ad3de9c Mon Sep 17 00:00:00 2001 From: Kelly Rossmoyer Date: Sun, 24 Apr 2022 23:22:49 +0000 Subject: [PATCH] Revert "powerstats: set time limit as timeout for AoC" Revert "powerstats: timeout mechanism for AoC data provider" Revert submission 17800080-power-stats-aoc-timeout Reason for revert: Causing crashes due to improper thread sync Reverted Changes: I71a9e6817:powerstats: timeout mechanism for AoC data provide... I725c00745:powerstats: set time limit as timeout for AoC I5b290a53d:powerstats: set time limit as timeout for AoC Change-Id: I84f5173aada0539d8c91d18d36a841bc9f3e3c9a --- powerstats/Gs201CommonDataProviders.cpp | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/powerstats/Gs201CommonDataProviders.cpp b/powerstats/Gs201CommonDataProviders.cpp index 599874d1..6232a6e0 100644 --- a/powerstats/Gs201CommonDataProviders.cpp +++ b/powerstats/Gs201CommonDataProviders.cpp @@ -102,7 +102,6 @@ void addPlaceholderEnergyConsumers(std::shared_ptr p) { } void addAoC(std::shared_ptr p) { - static const uint64_t TIMEOUT_MILLIS = 120; std::string prefix = "/sys/devices/platform/19000000.aoc/control/"; // Add AoC cores (a32, ff1, hf0, and hf1) @@ -115,7 +114,7 @@ void addAoC(std::shared_ptr p) { std::vector> coreStates = { {"DWN", "off"}, {"RET", "retention"}, {"WFI", "wfi"}}; p->addStateResidencyDataProvider(std::make_unique(coreIds, - coreStates, TIMEOUT_MILLIS)); + coreStates)); // Add AoC voltage stats std::vector> voltageIds = { @@ -126,8 +125,7 @@ void addAoC(std::shared_ptr p) { {"UUD", "ultra_underdrive"}, {"UD", "underdrive"}}; p->addStateResidencyDataProvider( - std::make_unique(voltageIds, voltageStates, - TIMEOUT_MILLIS)); + std::make_unique(voltageIds, voltageStates)); // Add AoC monitor mode std::vector> monitorIds = { @@ -137,8 +135,7 @@ void addAoC(std::shared_ptr p) { {"MON", "mode"}, }; p->addStateResidencyDataProvider( - std::make_unique(monitorIds, monitorStates, - TIMEOUT_MILLIS)); + std::make_unique(monitorIds, monitorStates)); // Add AoC restart count const GenericStateResidencyDataProvider::StateResidencyConfig restartCountConfig = {