Commit graph

143 commits

Author SHA1 Message Date
Dmitry Skiba
7571b12f0e Add a way to disable auto prefer fit for launch.
This change introduces "is APF enabled" system properties, and
uses them as trigger conditions for APF nodes / pre-APF nodes.

By default APF nodes are active, and pre-APF nodes are inactive,
which maintains the situation before this change.

A future experiment will flip "is APF enabled" system properties,
deactivating APF nodes and activating pre-APF nodes. For more
info see go/pixel-perf-apf-experiment.

Bug: 365855872
Test: set vendor.powerhal.apf_enabled=false, vendor.powerhal.apf_disabled=true, observe auto_prefer_fit
procfs value staying "false" and instead preferred_idle_mask_mid
changing to 0x1ff during app launches
Flag: NONE powerhint change does not support flags
Change-Id: I85b5dc812132f229c2cc8583aaadd31d7eedc178
Signed-off-by: Dmitry Skiba <dskiba@google.com>
2024-12-06 07:23:40 +00:00
Jimmy Shiu
eb79ff9e68 PowerHint: Refine FIXED_PERFORMANCE mode CPU Frequencies
Set the CPU frequencies of FIXED_PERFORMANCE to align with Thermal CPU Light level.

Bug: 327070837
Test: Boot to home
Flag: NONE powerhal doesn't have a flag yet
Change-Id: Ibb698b608c21c2a4f81354f852cb077345907947
2024-12-02 08:14:22 +00:00
Treehugger Robot
b76898c5cd Merge "Revert "powerhint: enable auto_prefer_idle in games"" into main 2024-11-21 19:47:31 +00:00
Kame(TeYuan) Wang
758dd12700 Revert "powerhint: enable auto_prefer_idle in games"
Revert submission 29817358-p23_auto_prefer_idle

Reason for revert: Power efficiency regression

Reverted changes: /q/submissionid:29817358-p23_auto_prefer_idle

Bug: 372961087
Test: manual testing
Change-Id: I4b24954cb37a469c2d6835e6f01e6abc655ce0b2
2024-11-21 18:23:40 +00:00
Treehugger Robot
e494c690f1 Merge "Enable CDPreferHighCap for CAMERA_STREAMING_HIGH" into main 2024-10-21 23:04:00 +00:00
Vince Chiu
e0635d2ad8 Enable CDPreferHighCap for CAMERA_STREAMING_HIGH
Test: 1080p60 power and perf, 4k60 power
Bug: 371210260
Flag: EXEMPT resource file only change
Change-Id: I71d6af9baab500ae6a37bda75a371747263e41c5
2024-10-18 05:41:17 +00:00
Ali K. Zadeh
ae8f5d5f10 Merge "[shusky] Define CAMERA_MULTICAM_BOOST" into main 2024-10-15 23:10:57 +00:00
TeYuan Wang
c12042d741 powerhint: enable auto_prefer_idle in games
Bug: 372961087
Test: manual testing
Flag: NONE powerhint config change
Change-Id: Ifc9a90073931fdb6cd1e6563fd9240f25d318b69
2024-10-11 22:00:45 +00:00
Rick Yiu
efa15cc3b3 Enable TA and FG prefer idle for some camera streams
These streams do not disable TA or FG prefer idle, so restore it.

Bug: 236868627
Flag: NONE powerhint change does not support flags
Test: build pass
Change-Id: Ia0f12911110856b82b858bed11fb5d120388285a
2024-10-10 13:00:54 +00:00
Rick Yiu
2b1c430517 Use auto prefer fit for launch
Enable auto prefer fit for high prio tasks when app launch, and tune
uclmap min settings for different task prio.

Bug: 353885521
Flag: NONE powerhint change does not support flags
Test: build pass
Change-Id: I1b65a1543085dc3244a36d90c01ccb3ad9211604
2024-09-16 15:02:52 +00:00
Treehugger Robot
96d91001b0 Merge "Enable auto prefer idle" into main 2024-09-06 09:30:43 +00:00
Rick Yiu
da53d20798 Fix cpu mask for big core
The big core mask on zuma should be 0x100.

Bug: 248621289
Test: build pass
Flag: NONE powerhint change does not support flags
Change-Id: Id9dbd933505d3eaa2553ed1851883a3042028f16
2024-09-03 09:16:21 +00:00
Paulsu Su
d576c70006 Merge changes I1adc41ac,I0242977f into main
* changes:
  powerhint: Update not available frequency to reflect its actual behavior
  Update mismatched frequency for husky and shiba
2024-08-31 07:35:44 +00:00
Paulsu Su
e2a796691d powerhint: Update not available frequency to reflect its actual behavior
Some frequencies uses unavailable frequency other soc ex: ag/22293847, the patch update them to explicitly show the actual actions of driver.

Bug: 361294204
Change-Id: I1adc41aca636650b4eaad179d73bde030146347c
FLAG: NONE powerhint do not need flag
2024-08-31 05:20:01 +00:00
Jay Wang
97fa59f0ab Merge "powerhint: Lower CAM uclamp min" into main 2024-08-30 23:29:31 +00:00
Rick Yiu
a2b661cfc1 Enable auto prefer idle
Also disable prefer idle for TA and FG by default.

Bug: 236868627
Flag: NONE powerhint change does not support flags
Test: build pass
Change-Id: I0d06e707900ec9a85decbdecbd184532743c7de0
2024-08-27 15:04:37 +00:00
Rick Yiu
54c0accb7f Set big core to group_cfs_skip_mask for sys group by default
Let sys group tasks will run less in big core by default.

Bug: 328210236
Test: build pass
Change-Id: I0092c5d32091894750287fb1fb0c5756158d37b1
2024-08-27 14:50:20 +00:00
Paulsu Su
70363dbbfa Update mismatched frequency for husky and shiba
- Update freq for legacy mismatched frequency with the rule of scaling_max_freq will automatically round down, scaling_min_freq will round up. All powerhint behavior should not change.
- Remove some min/max frequency not used in any nodes.

Bug: 361294204
FLAG: NONE powerhint do not need flag
Change-Id: I0242977f05f859ad5c3c38673579e296e74c78ca
2024-08-22 02:35:18 +00:00
Jay
0dd1ab91a9 powerhint: Lower CAM uclamp min
Current CAM uclamp min is beyond MID clusters capacity when
CAM2 energy model is used. This causes most of camera HAL threads
scheduled on big cluster only with CAM2 EM profile.

Lowering CAM uclamp min so it is within MID clusters capacity for
both energe model

Flag: EXEMPT tuning changes
Test: check camera trace with proper uclamp value
Bug: 350629738

Change-Id: I40ce59d0a0d99ea6ba016a24245f44713485bc52
2024-08-12 22:57:41 +00:00
Sam Ou
625b03b77f Merge "thermal: Remove bcl related tzones" into main 2024-08-12 12:32:35 +00:00
samou
cd69a5a885 thermal: Remove bcl related tzones
Flag: EXEMPT tuning changes
Bug: 349935208
Test: Confirm boot
Change-Id: I5091b906604fe5dec3b7e8ac6631fcd3acb0989d
Signed-off-by: samou <samou@google.com>
2024-08-06 04:03:22 +00:00
Ali K. Zadeh
d5729b0d0a [shusky] Define CAMERA_MULTICAM_BOOST
Port from ag/28607900

This CL defines CAMERA_MULTICAM_BOOST (with the same settings as the
existing CAMERA_ZOOMING_BOOST). Having both definitions is necessary to
be able to transition from zooming boost to multicam boost. Once the
multicam boost flag is fully rolled out, we can remove the
CAMERA_ZOOMING_BOOST.

Bug: 347829135
Test: adb logcat
Flag: EXEMPT resource file only change
Change-Id: I66f82dec5733a147ecbf073beb5b6c36f4860bb4
2024-08-02 20:21:36 +00:00
Treehugger Robot
0fe25ca786 Merge "Adpf:shusky: switch to multitier heuristic boost." into main 2024-07-27 00:58:16 +00:00
guibing
fab7721b14 Adpf:shusky: switch to multitier heuristic boost.
Bug: 344685639
Test: Checked the trace file running on the device.
Flag: NONE powerhal doesn't have a flag yet
Change-Id: I8b3918ee11a34315155561bfd0b0a7e9a8f9f32d
2024-07-26 23:20:43 +00:00
Rick Yiu
55021e0056 Merge "Revert^2 "Set big core to cpu skip mask by default"" into main 2024-07-26 01:11:58 +00:00
Rick Yiu
df6fafe03a Revert^2 "Set big core to cpu skip mask by default"
This reverts commit 5d7958215d.

Reason for revert: 24Q4 kernel prebuilt ready

Bug: 248621289
Change-Id: Ia9fbfb2ead5c42fa849758ffba9210cf45b6396f
Test: build pass
2024-07-25 15:05:59 +00:00
lukechang
d6240b116e powerhint: adjust cpd target residency when interaction
Modify default BC (husky) / BC/MC(shiba) CPD target residency to 10ms.
Increase to 750ms during interaction.

Bug: 283233731
Bug: 350508026

Flag: EXEMPT bugfix

Test: power & perf cuj test

Change-Id: I02ef4cf1174f6b49cbc4734257d9dbe43b74b86e
Signed-off-by: lukechang <lukechang@google.com>
2024-07-11 04:39:35 +00:00
Ali K. Zadeh
bcafadef9c Increase PMU_MID_SPC_THRESHOLD to 23 for 60fps
Test results show that increasing Spc threshold for mid core to 23 can
help with framedrop rate without affecting the power.

Bug: 317052150
Test: https://docs.google.com/spreadsheets/d/1bpSfVptz8nolSPfeYfkbjnP9pIK3l-U1JyqPNCwOwLc/edit?resourcekey=0-oiFKaxI6PtSGR6yXed327w&gid=430808958#gid=430808958
Change-Id: I9d5efbc0b7465825b36bff0dc70671121198b8c3
2024-06-07 16:20:50 +00:00
Rick Yiu
5d7958215d Revert "Set big core to cpu skip mask by default"
This reverts commit c6609a4bb9.

Reason for revert: 24Q3 kernel prebuilt not ready

Bug: 248621289
Change-Id: I53abd0932443fa437a487255b74e06dad18f7b9f
Test: build pass
2024-06-06 03:02:13 +00:00
Rick Yiu
d6c3e07eb4 Revert "Set big core to group_cfs_skip_mask for sys group"
This reverts commit 83bdd31a60.

Reason for revert: 2dQ3 kernel prebuilt not ready

Bug: 248621289
Change-Id: I34c8616bc6b39e178c665a77c266c2a60438a651
Test: build pass
2024-06-06 03:01:52 +00:00
Rick Yiu
c6609a4bb9 Set big core to cpu skip mask by default
Also reset the mask for launch and other camera streaming modes that
do not use it.

Bug: 248621289
Test: build pass
Change-Id: Id2f8f203359d4551d17f9b6ba02ee1c8e805fa3c
2024-06-04 14:00:14 +00:00
Rick Yiu
83bdd31a60 Set big core to group_cfs_skip_mask for sys group
Set big core to group_cfs_skip_mask for sys group when screen is off,
so that sys group tasks will run less in big core.

Bug: 328210236
Test: build pass
Change-Id: I9ccb3035a480e88960951222c45d0ca8352082d9
2024-05-24 13:50:26 +00:00
Matt Buckley
58ab0d9afb Merge "Add POWER_EFFICIENCY uclamp max to adpf config" into main 2024-04-29 19:42:14 +00:00
guibing
340d8f1f91 Adpf:shusky: revert heuristic boost triggering condition.
This reverts previous JankCheckTimeFactor from 1.43 to 1.2.

Since the current reported duration doesn't include the GPU
part, the JankCheckTimeFactor needs to be smaller for matching
jank frame detection.

Bug: 204204746
Test: adb shell dumpsys android.hardware.power.Ipower/default;
      check adpf sessions' traces.
Change-Id: I9c7587b6b1507fae685561fcf008c5ab9ae73532
2024-04-25 22:52:15 +00:00
Treehugger Robot
6358b83b19 Merge "adpf:shusky: update hboost jank check time factor." into main 2024-04-19 02:32:32 +00:00
guibing
01660ca736 adpf:shusky: update hboost jank check time factor.
Update it to align with the HWUI target duration scale factor,
so the adjusted jank check time duration is same as expected frame
timeline's duration.

HWUI target duration scale factor is 70%, and its inverse value is
approximately 1.43.

Bug: 204204746
Test: adb shell dumpsys android.hardware.power.IPower/default;
      Check the device adpf sessions' traces.
Change-Id: I8565fa1352769e6f879ea5fc12412d00f254da3b
2024-04-18 22:52:12 +00:00
Wei Wang
6ae60dd4b7 Merge "adpf:shusky: add hboost junk detection time factor into power hint json files." into main 2024-04-16 03:50:58 +00:00
guibing
e6fe682d22 adpf:shusky: add hboost junk detection time factor into power hint json files.
Bug: 204204746
Test: adb shell dumpsys android.hardware.power.IPower/default;
      Check the device adpf sessions' traces.
Change-Id: If4c116e172b101eebe8a8b9b539f3a55e4299ca8
2024-04-16 00:17:11 +00:00
Treehugger Robot
6fdf23cbf2 Merge "shusky: Add heuristic boost configs in power hint json files." into main 2024-04-13 01:33:50 +00:00
guibing
97c7f4861e shusky: Add heuristic boost configs in power hint json files.
Bug: 204204746
Test: Power hal launches in device without configuration parsing issue.
Change-Id: I5f85f88699b468f2c5e0af05dcea0bfa3fba56d2
2024-04-12 23:29:12 +00:00
Rick Yiu
bfb341fb00 Disable auto prefer idle explictly for some conditions
In auto prefer idle mode, a task in top-app will be granted prefer
idle if it satisfied the conditions. So turn auto prefer idle off
if top-app prefer_idle is explictly disabled. Also turn auto prefer
off when other group enables prefer_idle explictly.

Bug: 236868627
Test: build pass
Change-Id: Id0dc5bda64686826f72aad4549b8edcb1ceb4502
2024-04-11 14:05:00 +00:00
Treehugger Robot
745091a821 Merge "powerhint.json: enable gpu capacity signalling." into main 2024-04-10 19:31:11 +00:00
Jimmy Shiu
d51ff23214 powerhint: set ADPF CPU_LOAD_UP CPU_LOAD_RESET values am: a928cbb681
Original change: https://googleplex-android-review.googlesource.com/c/device/google/shusky/+/26902700

Change-Id: I3edaf8ffc84231ec5c188ce1ed07791c04f087f7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-10 16:37:22 +00:00
Jimmy Shiu
a928cbb681 powerhint: set ADPF CPU_LOAD_UP CPU_LOAD_RESET values
Bug: 329483662
Test: Manual Test
Change-Id: I2b4be8ee1d4f8a91196478d7b3c898f236365dff
2024-04-10 11:45:10 +00:00
Kevin DuBois
fe02aeed6d powerhint.json: enable gpu capacity signalling.
Enables a signal indicating that the app has janked as
detected by the ADPF API.

Bug: 290625326
Test: perf / power tests

Change-Id: Iaf0f131cab90e4225642af243303473f56a34320
2024-04-08 11:27:12 -07:00
Jimmy Shiu
88db876244 powerhint: set uclampmin_init value for applying CPU Load boost am: f4d3c1bd4b
Original change: https://googleplex-android-review.googlesource.com/c/device/google/shusky/+/26809487

Change-Id: I8e5faa45469ab1ab4cfc2ad1a828ee970041195b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-03 04:19:42 +00:00
Jimmy Shiu
f4d3c1bd4b powerhint: set uclampmin_init value for applying CPU Load boost
Bug: 329483662
Test: Manual Test
Change-Id: Id844e1f5d05d207e668c1ff151361bece37ee2c4
2024-04-03 01:04:41 +00:00
Rick Yiu
024418b3a2 Change set preferred idle mask to top-app
Set default value to 0xff to exclude big core for all priorities, but
restore high and mid to 0x1ff when app launch.

Bug: 248621289
Test: value set correctly
Change-Id: If9696e02f2a54f07d5acb974ff0301ea936c53e0
2024-03-25 15:56:01 +00:00
Sam Paradis
693daacfbe Change FACE_UNLOCK_BOOST to Maximize CPU Frequency
This is part of an optimization that limits the length and prevelance of
this power hint. Strict, ultra-agression minimizes power and latency
versus always-on mid aggression.

Bug: 297964952
Change-Id: I384f2e04f69d570e10c8e52f2818c1ecde6be1a0
2024-03-13 17:12:19 +00:00
Sam Paradis
dbbb0c62ea Change FACE_UNLOCK_BOOST to Maximize CPU Frequency
This is part of an optimization that limits the length and prevelance of
this power hint. Strict, ultra-agression minimizes power and latency
versus always-on mid aggression.

Bug: 297964952
Change-Id: I384f2e04f69d570e10c8e52f2818c1ecde6be1a0
2024-03-09 01:56:27 +00:00