From 0873a888581f82453c8f84d5f4665cc92b3c21f1 Mon Sep 17 00:00:00 2001 From: Mike McTernan Date: Mon, 3 Jul 2023 11:20:27 +0100 Subject: [PATCH 01/26] tangorpro: revert "set metadata_init_delete_all_keys to false" Reverts ag/18876019 now that the underlying problem is fixed. Additionally setting this property can cause devices to fill up with keys and Cts tests to start failing. Bug: 262212842 Test: boot & factory reset on device Change-Id: Ieb5e0f68557c3f888a46275387c71e4f15181dfa --- device-tangorpro.mk | 3 --- 1 file changed, 3 deletions(-) diff --git a/device-tangorpro.mk b/device-tangorpro.mk index 0c526e7..b352574 100644 --- a/device-tangorpro.mk +++ b/device-tangorpro.mk @@ -148,9 +148,6 @@ PRODUCT_SOONG_NAMESPACES += vendor/google_devices/tangorpro/prebuilts PRODUCT_PROPERTY_OVERRIDES += \ ro.vendor.wifi.sap.interface=wlan1 -# Set ro.crypto.metadata_init_delete_all_keys.enabled to false to unblock boot -PRODUCT_PROPERTY_OVERRIDES += ro.crypto.metadata_init_delete_all_keys.enabled=false - # Assistant minimum volume PRODUCT_PROPERTY_OVERRIDES += \ ro.config.assistant_vol_min=1 From e94e0e840ada9f16a3eea927174670dc2bee451b Mon Sep 17 00:00:00 2001 From: Fiona Campbell Date: Wed, 16 Aug 2023 18:27:24 +0000 Subject: [PATCH 02/26] Add Strong mode configs for dwbc - Add configs for strong mode. Bug: 265233091 Test: adb shell dumpsys color_display | grep mTemperatureMin -A10 && adb shell dumpsys display | grep mLowLightAmbientBrightnessToBiasSpline -A2 Change-Id: I9e36f690ba9c79252475dc10e6c5f4fb70932b1c --- .../base/core/res/res/values/config.xml | 49 +++++++++++++++++++ 1 file changed, 49 insertions(+) diff --git a/tangorpro/overlay/frameworks/base/core/res/res/values/config.xml b/tangorpro/overlay/frameworks/base/core/res/res/values/config.xml index 15b02f6..678a216 100644 --- a/tangorpro/overlay/frameworks/base/core/res/res/values/config.xml +++ b/tangorpro/overlay/frameworks/base/core/res/res/values/config.xml @@ -249,6 +249,21 @@ 10.0 + + + 3.0 + 10.0 + + + + 0.0 + 1.0 + + + + + 130000.0 + 150000.0 + + + + 0.0 + 1.0 + + - 4000.0 + 5250.0 + + + 4000.0 @@ -1318,6 +1406,10 @@ + + + + From 21ee858b3c0fb1ec70c9418262852a0b8af1007b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Maciej=20=C5=BBenczykowski?= Date: Thu, 28 Sep 2023 00:29:51 +0000 Subject: [PATCH 07/26] OWNERS: master -> main Change-Id: Ie7a5ea46e808ee7e51b2b4fa8f76816f713f0ccf --- OWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/OWNERS b/OWNERS index 79003ba..7eed0c3 100644 --- a/OWNERS +++ b/OWNERS @@ -1,4 +1,4 @@ per-file powerhint.json = jychen@google.com,jenhaochen@google.com,wvw@google.com,joaodias@google.com # per-file for Pixel device makefiles, see go/pixel-device-mk-owner-checklist for details. -per-file *.mk,*/BoardConfig.mk=file:device/google/gs-common:master:/OWNERS +per-file *.mk,*/BoardConfig.mk=file:device/google/gs-common:main:/OWNERS From 6763ef499885766e3cc8c64c59c98d3825f10b50 Mon Sep 17 00:00:00 2001 From: Garfield Tan Date: Fri, 29 Sep 2023 21:53:11 +0000 Subject: [PATCH 08/26] Revert "Add freeform management feature to tangorpro" This reverts commit 172904aa41bcc97855fb94e836eb0f7451f9554a. Reason for revert: Remove this configuration to common configurations for both virtual and real Tangors. Change-Id: I6256ed65419d6b0e3e70b7ab5adcc7ab6f67a4b5 --- device-tangorpro.mk | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/device-tangorpro.mk b/device-tangorpro.mk index 0b734b9..57dd148 100644 --- a/device-tangorpro.mk +++ b/device-tangorpro.mk @@ -219,9 +219,7 @@ PRODUCT_COPY_FILES += \ # Device features PRODUCT_COPY_FILES += \ - frameworks/native/data/etc/tablet_core_hardware.xml:$(TARGET_COPY_OUT_VENDOR)/etc/permissions/tablet_core_hardware.xml \ - frameworks/native/data/etc/android.software.freeform_window_management.xml:$(TARGET_COPY_OUT_VENDOR)/etc/permissions/android.software.freeform_window_management.xml - + frameworks/native/data/etc/tablet_core_hardware.xml:$(TARGET_COPY_OUT_VENDOR)/etc/permissions/tablet_core_hardware.xml # Display Config PRODUCT_COPY_FILES += \ From 7f9b49f89de32ad176d5efa6070f687d4f242855 Mon Sep 17 00:00:00 2001 From: normanwhl Date: Sun, 1 Oct 2023 16:55:25 +0000 Subject: [PATCH 09/26] Disable firmware roaming in idle mode Add a configurable overlay to control a whether to disable firmware roaming when the device goes into idle mode. When the feature is enabled, all STA ifaces will disable firmware roaming upon entering idle mode. Upon exiting idle mode, all STAs except ones being used for the local-only use-case will re-enable firmware roaming. Bug: 291349183 Test: atest com.android.server.wifi Change-Id: Id77fdb65844c8f57d25dbb24576f27ff7d2157df --- rro_overlays/WifiOverlay/res/values/config.xml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/rro_overlays/WifiOverlay/res/values/config.xml b/rro_overlays/WifiOverlay/res/values/config.xml index 497a962..98a4f2f 100644 --- a/rro_overlays/WifiOverlay/res/values/config.xml +++ b/rro_overlays/WifiOverlay/res/values/config.xml @@ -134,4 +134,10 @@ regulatory approval (for example, FCC pre-approval is required according to "594280 D01 Software Configuration Control v02r01").--> true + + + true From 7d8b7fe3c934d2dd0b044ec11c3aaecbbc027802 Mon Sep 17 00:00:00 2001 From: sergiuferentz Date: Mon, 25 Sep 2023 15:04:30 +0000 Subject: [PATCH 10/26] Bump android.hardware.graphics.common V4->V5 Test: Build Bug: 291142745 Change-Id: Ib5ca50de4eac7420a721d59e17070332854f649f --- lights/Android.bp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lights/Android.bp b/lights/Android.bp index 9544e19..fb2d8ff 100644 --- a/lights/Android.bp +++ b/lights/Android.bp @@ -22,7 +22,7 @@ cc_binary { static_libs: [ "//hardware/google/interfaces:com.google.hardware.pixel.display-V7-ndk", "android.hardware.common-V2-ndk", - "android.hardware.graphics.common-V4-ndk", + "android.hardware.graphics.common-V5-ndk", ], srcs: ["Lights.cpp", "led_lut_calibrator.cpp"], From 5730faa268faab5cffd0acebd42af9827d4819bf Mon Sep 17 00:00:00 2001 From: Sally Qi Date: Mon, 9 Oct 2023 17:39:52 +0000 Subject: [PATCH 11/26] Use android.hardware.graphics.common wrap. Bug: 291745893 Change-Id: Ie038262255ab5621c7b8ce3cec2b8343ef68f6dd Test: builds --- lights/Android.bp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lights/Android.bp b/lights/Android.bp index fb2d8ff..c6fbd12 100644 --- a/lights/Android.bp +++ b/lights/Android.bp @@ -9,6 +9,7 @@ package { cc_binary { name: "android.hardware.lights-service.tangorpro", + defaults: ["android.hardware.graphics.common-ndk_static"], relative_install_path: "hw", init_rc: ["android.hardware.lights-service.tangorpro.rc"], vintf_fragments: ["android.hardware.lights-service.tangorpro.xml"], @@ -22,7 +23,6 @@ cc_binary { static_libs: [ "//hardware/google/interfaces:com.google.hardware.pixel.display-V7-ndk", "android.hardware.common-V2-ndk", - "android.hardware.graphics.common-V5-ndk", ], srcs: ["Lights.cpp", "led_lut_calibrator.cpp"], From d887dc78301e066d54b03a6440322fd2abeb9132 Mon Sep 17 00:00:00 2001 From: guibing Date: Wed, 2 Aug 2023 18:20:26 +0000 Subject: [PATCH 12/26] powerhint: tangorpro: update vendor_sched procfs paths Vendor sched procfs path hierarchy gets updated in kernel. Update the paths in powerhint json file to match the change. Bug: 289151587 Test: UIbench ab test. Change-Id: I85dc5530c25c505fe97738e30c892c4965f3a6ac --- powerhint.json | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/powerhint.json b/powerhint.json index 3b47f68..da50d2b 100644 --- a/powerhint.json +++ b/powerhint.json @@ -156,7 +156,7 @@ }, { "Name": "CAMUClampBoost", - "Path": "/proc/vendor_sched/cam_uclamp_min", + "Path": "/proc/vendor_sched/groups/cam/uclamp_min", "Values": [ "764", "0" @@ -165,7 +165,7 @@ }, { "Name": "TAUClampBoost", - "Path": "/proc/vendor_sched/ta_uclamp_min", + "Path": "/proc/vendor_sched/groups/ta/uclamp_min", "Values": [ "764", "1" @@ -174,7 +174,7 @@ }, { "Name": "FGUClampBoost", - "Path": "/proc/vendor_sched/fg_uclamp_min", + "Path": "/proc/vendor_sched/groups/fg/uclamp_min", "Values": [ "159", "0" @@ -183,7 +183,7 @@ }, { "Name": "MLUclampBoost", - "Path": "/proc/vendor_sched/nnapi_uclamp_min", + "Path": "/proc/vendor_sched/groups/nnapi/uclamp_min", "Values": [ "225", "813" @@ -202,7 +202,7 @@ }, { "Name": "CDPreferIdle", - "Path": "/proc/vendor_sched/cam_prefer_idle", + "Path": "/proc/vendor_sched/groups/cam/prefer_idle", "Values": [ "0", "1" @@ -248,7 +248,7 @@ }, { "Name": "TAPreferHighCap", - "Path": "/proc/vendor_sched/ta_prefer_high_cap", + "Path": "/proc/vendor_sched/groups/ta/prefer_high_cap", "Values": [ "1", "0" @@ -257,7 +257,7 @@ }, { "Name": "TAPreferIdle", - "Path": "/proc/vendor_sched/ta_prefer_idle", + "Path": "/proc/vendor_sched/groups/ta/prefer_idle", "Values": [ "0", "1" @@ -266,7 +266,7 @@ }, { "Name": "FGPreferIdle", - "Path": "/proc/vendor_sched/fg_prefer_idle", + "Path": "/proc/vendor_sched/groups/fg/prefer_idle", "Values": [ "1", "0" @@ -276,7 +276,7 @@ }, { "Name": "CDPreferHighCap", - "Path": "/proc/vendor_sched/cam_prefer_high_cap", + "Path": "/proc/vendor_sched/groups/cam/prefer_high_cap", "Values": [ "1", "0" @@ -605,7 +605,7 @@ }, { "Name": "Dex2oatGroup", - "Path": "/proc/vendor_sched/dex2oat_ug", + "Path": "/proc/vendor_sched/groups/dex2oat/ug", "Values": [ "1", "0" From 13f0733d7c9593d1629a1f2bf8601d062ac617fd Mon Sep 17 00:00:00 2001 From: Alice Kuo Date: Wed, 11 Oct 2023 15:41:39 +0800 Subject: [PATCH 13/26] Use classic connection by default with LE audio device for T6pro Bug: 300012501 Test: manual Change-Id: I32502d1e9ca4ea14bc70ba469e3ffb2d1e106c7c --- bluetooth/syna_default.mk | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/bluetooth/syna_default.mk b/bluetooth/syna_default.mk index 53a04b1..a389ffd 100644 --- a/bluetooth/syna_default.mk +++ b/bluetooth/syna_default.mk @@ -46,6 +46,10 @@ PRODUCT_PRODUCT_PROPERTIES += \ PRODUCT_PRODUCT_PROPERTIES += \ persist.bluetooth.leaudio.toggle_visible=false +# LE Audio use classic connection by default +PRODUCT_PRODUCT_PROPERTIES += \ + ro.bluetooth.leaudio.le_audio_connection_by_default=false + # Bluetooth HAL and Pixel extension DEVICE_MANIFEST_FILE += \ device/google/tangorpro/bluetooth/manifest_bluetooth.xml From 45e117b89052482423345f4b64bd37a4d3e5ce06 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Per=20=C3=85hgren?= Date: Thu, 12 Oct 2023 06:41:55 +0000 Subject: [PATCH 14/26] Extend the APMg3 tunings to also handling turning AEC off This CL extends APMg3 tunings for the tablet, dock and headset usecases with counterparts where the AEC is off. Bug: 301568974 Test: Running CTS test suite verification. Manual testing in calls on Tangor. Change-Id: I87fd24ba084691c238f5c07272208049acaf2e5d --- audio/tangorpro/audio-tables.mk | 3 +++ .../tuning/apmg3/uplink_dock_aec_off_config.pb | Bin 0 -> 2078 bytes .../apmg3/uplink_headset_aec_off_config.pb | Bin 0 -> 2069 bytes .../apmg3/uplink_tablet_stereo_aec_off_config.pb | Bin 0 -> 2833 bytes 4 files changed, 3 insertions(+) create mode 100644 audio/tangorpro/tuning/apmg3/uplink_dock_aec_off_config.pb create mode 100644 audio/tangorpro/tuning/apmg3/uplink_headset_aec_off_config.pb create mode 100644 audio/tangorpro/tuning/apmg3/uplink_tablet_stereo_aec_off_config.pb diff --git a/audio/tangorpro/audio-tables.mk b/audio/tangorpro/audio-tables.mk index da4490b..b7e383a 100644 --- a/audio/tangorpro/audio-tables.mk +++ b/audio/tangorpro/audio-tables.mk @@ -65,6 +65,9 @@ PRODUCT_COPY_FILES += \ device/google/tangorpro/audio/$(AUDIO_TABLE_FOLDER)/tuning/apmg3/uplink_headset_config.pb:$(TARGET_COPY_OUT_VENDOR)/etc/aoc/uplink_headset_config.pb \ device/google/tangorpro/audio/$(AUDIO_TABLE_FOLDER)/tuning/apmg3/uplink_dock_config.pb:$(TARGET_COPY_OUT_VENDOR)/etc/aoc/uplink_dock_config.pb \ device/google/tangorpro/audio/$(AUDIO_TABLE_FOLDER)/tuning/apmg3/uplink_tablet_stereo_config.pb:$(TARGET_COPY_OUT_VENDOR)/etc/aoc/uplink_tablet_stereo_config.pb \ + device/google/tangorpro/audio/$(AUDIO_TABLE_FOLDER)/tuning/apmg3/uplink_headset_aec_off_config.pb:$(TARGET_COPY_OUT_VENDOR)/etc/aoc/uplink_headset_aec_off_config.pb \ + device/google/tangorpro/audio/$(AUDIO_TABLE_FOLDER)/tuning/apmg3/uplink_dock_aec_off_config.pb:$(TARGET_COPY_OUT_VENDOR)/etc/aoc/uplink_dock_aec_off_config.pb \ + device/google/tangorpro/audio/$(AUDIO_TABLE_FOLDER)/tuning/apmg3/uplink_tablet_stereo_aec_off_config.pb:$(TARGET_COPY_OUT_VENDOR)/etc/aoc/uplink_tablet_stereo_aec_off_config.pb \ device/google/tangorpro/audio/$(AUDIO_TABLE_FOLDER)/tuning/apmg3/downlink_headset_config.pb:$(TARGET_COPY_OUT_VENDOR)/etc/aoc/downlink_headset_config.pb \ device/google/tangorpro/audio/$(AUDIO_TABLE_FOLDER)/tuning/apmg3/downlink_dock_config.pb:$(TARGET_COPY_OUT_VENDOR)/etc/aoc/downlink_dock_config.pb \ device/google/tangorpro/audio/$(AUDIO_TABLE_FOLDER)/tuning/apmg3/downlink_tablet_stereo_config.pb:$(TARGET_COPY_OUT_VENDOR)/etc/aoc/downlink_tablet_stereo_config.pb diff --git a/audio/tangorpro/tuning/apmg3/uplink_dock_aec_off_config.pb b/audio/tangorpro/tuning/apmg3/uplink_dock_aec_off_config.pb new file mode 100644 index 0000000000000000000000000000000000000000..bd8b7201345389eaefd40eb5f0ba4c1c1e7155a1 GIT binary patch literal 2078 zcmds&O=uHQ5XWcI#J+B`G~H%xns)0W5=@JMkPy1mCi^!1u+|o8@lc9FEm))=Lj5W| z1w=0jinkO&LA;3<54|XsqEMs-1yS^*2QQv_5uq2I*(9_TR20GDVQ1gR|Gk}=o!@)f zJ=8Q&{Nf8?1SJ|i0nu6kCP2}NH3{T~vTi*ss#rik=qq;m1f~TwAp#P+EdfT0zz{?m zbzVby%6iKk$; zo<5Hjs5biQ{FV+B5u6%67iPQqypb<@N?`t(Y!D7O^76Xz}k zgElH00hsUGVP>U34*gRjUGm`Prs$BQVn%TsJDYVc%?}Qqcw&8+Kk7)}g0UeTSnA#qKnCB8bshS)&&fkBwuWJsb2qXFsF#a&3kxs~_j>SD9G)PIldw>!E&UaEGbc?i1 zs8n{#{{!fbJ28Ic&{ja1%}qdY8=zd!&`YH#UHbLX&9eCmfG#ahyr=@o?9%DJ$|#l? zP>&`)3A_RFfR5-)=3(9gbkF6h4yms>RW%DuURhOxVs!En6Oann0VRgKlPFKzNSAh7 zcV#*eq|*X^1I`srLecTy3{~N@QgyjaIPr&Y#?pLl(G9P4?(%N?nsnveU4CPs@}?UL L#*waFw4dWQ8rY?a literal 0 HcmV?d00001 diff --git a/audio/tangorpro/tuning/apmg3/uplink_headset_aec_off_config.pb b/audio/tangorpro/tuning/apmg3/uplink_headset_aec_off_config.pb new file mode 100644 index 0000000000000000000000000000000000000000..03f757496217664b6e857e43cb326c3c81e1f346 GIT binary patch literal 2069 zcmeHIL1+^}6#YNVn&~#7>6(~y+r?!exD5tELUD;CJDaqnRtq(FC_%9V3{nuGqC!p! z;z>d9WIPqbn>P==hJq3>5xnTxgBMS|iM{Cmn-)S(f(I@1Fn|8ce}CrxKl5hP*Qlz( z{}GB~8cozf0`!Q0B!KT)rv;L-Esgg-Z%RuM5dVeQkidc<71Cg0$q=ATi%=Z&sTlhZ zUV3TFq;@_zCe#xFaLgRHu_^?T(~^meEIBCz2he8(%mZ{~8DP&_q#5r9tsrj!Ebm$r zOq1FcHSI-2jfj1Wi*!g^5K26pR!p!l-zXQ0MR$?K>Y#t6QV)|cu?`z}8@48Bdo)1K z(yr~10r-geLv=>PlBu1mjzNy)%w6qKDMt~=`R8+;%UYC-ysE(?iZhy2zr4C=5WqbG zwW4HfwOT`{y^oZUDV=Ev%eaOcaEE+Gg!L_SSSnxAdR;fem7`qHL5ZsX?S&KZcQsgp zb^`;6f8E>=&JfvKF=D}-}G`U_~bkXB$N__=~W4Hrbd`;k1zn$ zFyH5uSy3QE?-ChIFEjZ5c`5g@)2R&4udc)%Om%k~A5nz0^Xg=bP02yOUolwICS!Bg zpOtx{987Qol5apoXY|>}Ph2uSbq~=DOtR+@bdZhWC{nBhiB>2i)1%e)JhNa&DHy1y z1!`fU9qNG$?iuCjyX(;81OvYME;;qM2)?_?gpCt_d0-p)@iHs--@H3_p-KFqEr59s zn<^KAH5>GQK+OrF=Dk0o<_PqJn*YJWa=fTXk8`p3_PA2hDiBTiV^_1Mf=_;|aL|{A SJys8T`l;y2q~8{u5BM9ZU6)({ literal 0 HcmV?d00001 diff --git a/audio/tangorpro/tuning/apmg3/uplink_tablet_stereo_aec_off_config.pb b/audio/tangorpro/tuning/apmg3/uplink_tablet_stereo_aec_off_config.pb new file mode 100644 index 0000000000000000000000000000000000000000..eb615ce7b45a462e651fef26a260e9973943e5c5 GIT binary patch literal 2833 zcmeH|YfMx}6vt;^SFV>GSyzrAx_Y~Yx}r2>cki-AcJH|$6sQkGObBX&S_z>VUr`B- z$y%#5zOc47LLZuHA3m@jY9myQhE#(FjU-m$qiMAvT4Ss=)>mTfnG05IYFgV5O_P4O z=iZt5pP6&c%=1?-yKd%Dk2#fQz?qB{w0J0(>GaH}$F(_5jZ^M%r;;4w8cnm>lI@!2 zZA_%Zrr4c{Wvqf%vH9^NH2rf) zv&E!6Vl2ldPgKz$#YY3Jh273qPUojL)YnHcxZJ-IyI9osY)knmuGm~7)dX>MLQ@#z zyl%B)Yql#v$b$rB&j+%t4tGQS8F>Pjks{Ue!mA?CP(Q$Ug4#MSa-6b>&9H~!(NQ!| zP)9_DltUqXhgz|>mrN9U6*x%uJg(+jxWs+S7(ICg#(bizKq&7Y| z#;S^Ua7JQSiWcrVJS?+@PbZ9MAtv!>)ha2iFE2~k^aq5>g8zL&7ZahP2cdIZ%d#kP zB6P#>`WK1Ncp`Lx;g&5T)Io%99YuK%p^r<6&>qq*LNyExcxphc4IV2i^}qRNH7I6} z0F`WZ0m{9MAnFOIJkTtc&ZTD3)@!CN&7T0u{sN$fTFOs61XQvs0gVuf^$`Me_>{VC zVr2(KK)-0e|MQ3i=#b^B4N|W$9;zkUL@Wur)eI#^5lv=e57|*Evi?L8P|c*-uA7?A z>yU{)1)Qz22vNg=(@8h1YSEY};!HJBY&>|{FJ?GPgJKq2t&8ot zmZ=UFv|X%+vBsC2y%Z3IiKBw#C4VEL|A*%TU9Mj**sa6le(#J^_s6JSvFWfQTbQ1E zA#rI(Ql_|>zFrr1a7$1;xP34vuwuS0>gsM~szb%JmU-DCJ$+qJ#A&%f;i$Q+i>7{8 zbdm0RPZzmqOM*1rwKWg2MAoPiAu-n*pb(pu286ul#oFt~{i3t{P(aK%dP=A1tgx-v zI_I_r#M}N*`}+$ z9!ksSoAh^sU43`M_jNIJ#{2s3B#%`t9Cu9@J2p=W2wM%U{+chO(^foM-THc?`F_Ca zgSAsPj)&?aU*_~MeaAaXfslQ14#KhM zQUu$!a|r8xx`=RV%zcCd7;D0`#xn>DFYQFA+}DioRr_ZMe8Lw9?);4ijpt4y{4(hT zLZY(`p(tjh30Ep-n$YLfYY3%B+7aSw_aUe^KSdZfuMVN&ZVkeI=VXMaJ`kaBqyxd; zGz4L>FNAP)MK;1)-zx~O2YMq+j5-m%Eh#{7e)0;!%7pa@b35z^#YayX(0;2w!t91J zgxe#k5KdmWjPUFbhY5P~FcUV Date: Wed, 18 Oct 2023 09:08:26 +0000 Subject: [PATCH 15/26] update idle brightness curve Bug: 304655186 Test: check dumpsys display Change-Id: I5b95328c993b15c9f68d15fb6f8c0439e41e7e5d --- .../base/core/res/res/values/config.xml | 58 ++++++++++++------- 1 file changed, 36 insertions(+), 22 deletions(-) diff --git a/tangorpro/overlay/frameworks/base/core/res/res/values/config.xml b/tangorpro/overlay/frameworks/base/core/res/res/values/config.xml index f7f9037..b914fdc 100644 --- a/tangorpro/overlay/frameworks/base/core/res/res/values/config.xml +++ b/tangorpro/overlay/frameworks/base/core/res/res/values/config.xml @@ -462,17 +462,24 @@ Must be overridden in platform specific overlays --> + 1 + 2 3 - 6 - 11 - 31 - 64 - 113 - 180 - 264 - 364 - 451 - 885 + 4 + 8 + 12 + 20 + 33 + 55 + 90 + 148 + 245 + 403 + 665 + 1097 + 1808 + 2981 + 4915 - 0.400000001 - 2.424401926 - 4.016322573 - 6.924331831 - 18.21836204 - 36.9199795 - 65.40219962 - 104.0902078 - 152.5833029 - 210.1432982 - 260.2204941 - 500.2693058 + 5.139055 + 9.962018965 + 18.34822964 + 21.55068128 + 24.0167788 + 30.62162162 + 35.09486396 + 45.38057825 + 62.187656 + 88.01503 + 118.924484 + 147.89162 + 175.12471 + 191.33968 + 226.19489 + 295.24768 + 396.007 + 440.62778 + 600.0 + true + true false From 30acd7ccadbb029867061ece3fbf400f7b9e74d3 Mon Sep 17 00:00:00 2001 From: Peter Lin Date: Mon, 20 Nov 2023 13:06:25 +0000 Subject: [PATCH 21/26] update idle brightness curve Changed the brightness from 5 nits to 2 nits at 0 lux. Bug: 304655186 Test: check dumpsys display Change-Id: Ie3aa91f5867e2ec5181b69f10ec27eff67c424e6 --- .../overlay/frameworks/base/core/res/res/values/config.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tangorpro/overlay/frameworks/base/core/res/res/values/config.xml b/tangorpro/overlay/frameworks/base/core/res/res/values/config.xml index b54cbb5..03950c0 100644 --- a/tangorpro/overlay/frameworks/base/core/res/res/values/config.xml +++ b/tangorpro/overlay/frameworks/base/core/res/res/values/config.xml @@ -522,7 +522,7 @@ This array also corresponds to the lux values given in config_autoBrightnessLevelsIdle. In order to activate this mode, config_enableIdleScreenBrightnessMode must be true. --> - 5.139055 + 2.0 9.962018965 18.34822964 21.55068128 From 6423f901ed953ab009ed3bc69faff2496d3a249c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Per=20=C3=85hgren?= Date: Tue, 28 Nov 2023 23:13:43 +0000 Subject: [PATCH 22/26] Update APMg3 and tuning configs to version 11 This CL updates the APMg3 tunings to version 11. The changes performed is to remove any signal level gains applied in APMg3 in AOC for the headset usecase when the AEC is off. This eliminates the issue of 25 dB gain being applied when headsets are used causing some headset audio signals to be saturated. This is a correction of the CL https://googleplex-android-review.git.corp.google.com/c/device/google/tangorpro/+/25019613 which both included an active gain for headsets when the AEC is off. As a safety precaution, and to allow easier spotting of such issues, the CL also explicitly sets the gains to 0 dB also for the other headset tuning (before it was just deactivating the gain application for that) Bug: 309517292 Test: Manual test calls on Tangor using Meet. Change-Id: I4f29cd780fa6ca52df543387546d2a4b4b161139 --- .../apmg3/uplink_headset_aec_off_config.pb | Bin 2069 -> 2069 bytes .../tuning/apmg3/uplink_headset_config.pb | Bin 2069 -> 2069 bytes 2 files changed, 0 insertions(+), 0 deletions(-) diff --git a/audio/tangorpro/tuning/apmg3/uplink_headset_aec_off_config.pb b/audio/tangorpro/tuning/apmg3/uplink_headset_aec_off_config.pb index 03f757496217664b6e857e43cb326c3c81e1f346..5daa2d1c1a4a35246310d1848a2663c33cf29141 100644 GIT binary patch delta 22 bcmbO#FjZiJJU4?V14DzoEQr{s^_m?3J7NWb delta 22 ecmbO#FjZiJJU62#1H%Fb*<(NB9X4vcW(NRC83#iE diff --git a/audio/tangorpro/tuning/apmg3/uplink_headset_config.pb b/audio/tangorpro/tuning/apmg3/uplink_headset_config.pb index b2c4aa61a3d8323778026dd9dcd1dd9cbfe67c09..936bb398c11f764f1415cf70d5d1107ef74ff6cf 100644 GIT binary patch delta 18 ZcmbO#FjZiJGJAu)ECWM>{YI_V>;N(>1#JKT delta 18 acmbO#FjZiJGW!At*<(NB9X4vcW(NR2)CVm9 From cabd89d9138b97a6cc1ab9d6d00758df300f4ab7 Mon Sep 17 00:00:00 2001 From: Yvonne Yip Date: Mon, 11 Sep 2023 20:55:32 -0700 Subject: [PATCH 23/26] powerhint: add game mode tuning nodes Add down_rate_limit_us nodes, tapered_dvfs_headroom nodes. Test: build Bug: 295636226 (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:cdf834206df344a704f7f6f21e503f0e3abd4bbb) Merged-In: Iae9629e0f69d437f7444022d81a478d0c12f2bbe Change-Id: Iae9629e0f69d437f7444022d81a478d0c12f2bbe Change-Id: I0491f1e956686025cd4903b4356f36c0682baf6f --- powerhint.json | 42 +++++++++++++++++++++++++++++++++++++++++- 1 file changed, 41 insertions(+), 1 deletion(-) diff --git a/powerhint.json b/powerhint.json index da50d2b..57fb6eb 100644 --- a/powerhint.json +++ b/powerhint.json @@ -59,6 +59,16 @@ ], "ResetOnInit": true }, + { + "Name": "CPULittleClusterDownRateLimitUs", + "Path": "/sys/devices/system/cpu/cpu0/cpufreq/sched_pixel/down_rate_limit_us", + "Values": [ + "5000", + "500" + ], + "DefaultIndex": 0, + "ResetOnInit": true + }, { "Name": "CPUMidClusterMaxFreq", "Path": "/sys/devices/system/cpu/cpu4/cpufreq/scaling_max_freq", @@ -87,6 +97,16 @@ ], "ResetOnInit": true }, + { + "Name": "CPUMidClusterDownRateLimitUs", + "Path": "/sys/devices/system/cpu/cpu4/cpufreq/sched_pixel/down_rate_limit_us", + "Values": [ + "20000", + "3000" + ], + "DefaultIndex": 0, + "ResetOnInit": true + }, { "Name": "CPUBigClusterMaxFreq", "Path": "/sys/devices/system/cpu/cpu6/cpufreq/scaling_max_freq", @@ -115,6 +135,16 @@ ], "ResetOnInit": true }, + { + "Name": "CPUBigClusterDownRateLimitUs", + "Path": "/sys/devices/system/cpu/cpu6/cpufreq/sched_pixel/down_rate_limit_us", + "Values": [ + "20000", + "3000" + ], + "DefaultIndex": 0, + "ResetOnInit": true + }, { "Name": "ReducePreferIdle", "Path": "/proc/vendor_sched/reduce_prefer_idle", @@ -144,6 +174,16 @@ "DefaultIndex": 0, "ResetOnInit": true }, + { + "Name": "CPUTaperedDVFSHeadroomEnable", + "Path": "/proc/vendor_sched/tapered_dvfs_headroom_enable", + "Values": [ + "0", + "1" + ], + "DefaultIndex": 0, + "ResetOnInit": true + }, { "Name": "MIFTargetLoad", "Path": "/sys/class/devfreq/17000010.devfreq_mif/interactive/target_load", @@ -298,7 +338,7 @@ "Values": [ "0", "1" - ], + ] }, { "Name": "DisplayWakeup", From deb5fb62d84c30ce56a2a736825b896c97da915d Mon Sep 17 00:00:00 2001 From: Yvonne Yip Date: Mon, 11 Sep 2023 20:56:18 -0700 Subject: [PATCH 24/26] powerhint: game mode tuning Test: test build Bug: 295636226 (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:00d94318d492669c6c132d702ee73ccd515fa5bf) Merged-In: Ie1c7672d9950630ee868538e49937580d3aece4d Change-Id: Ie1c7672d9950630ee868538e49937580d3aece4d --- powerhint.json | 60 ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 60 insertions(+) diff --git a/powerhint.json b/powerhint.json index 57fb6eb..45d5de6 100644 --- a/powerhint.json +++ b/powerhint.json @@ -691,6 +691,36 @@ "Duration": 5000, "Value": "1" }, + { + "PowerHint": "LAUNCH", + "Node": "CPUDVFSHeadroom", + "Duration": 5000, + "Value": "1280" + }, + { + "PowerHint": "LAUNCH", + "Node": "CPUTaperedDVFSHeadroomEnable", + "Duration": 5000, + "Value": "0" + }, + { + "PowerHint": "LAUNCH", + "Node": "CPULittleClusterDownRateLimitUs", + "Duration": 5000, + "Value": "5000" + }, + { + "PowerHint": "LAUNCH", + "Node": "CPUMidClusterDownRateLimitUs", + "Duration": 5000, + "Value": "20000" + }, + { + "PowerHint": "LAUNCH", + "Node": "CPUBigClusterDownRateLimitUs", + "Duration": 5000, + "Value": "20000" + }, { "PowerHint": "LAUNCH", "Node": "CPUBigClusterMaxFreq", @@ -1626,6 +1656,36 @@ "Duration": 0, "Value": "572000" }, + { + "PowerHint": "GAME", + "Node": "CPUDVFSHeadroom", + "Duration": 0, + "Value": "1100" + }, + { + "PowerHint": "GAME", + "Node": "CPUTaperedDVFSHeadroomEnable", + "Duration": 0, + "Value": "1" + }, + { + "PowerHint": "GAME", + "Node": "CPULittleClusterDownRateLimitUs", + "Duration": 0, + "Value": "500" + }, + { + "PowerHint": "GAME", + "Node": "CPUMidClusterDownRateLimitUs", + "Duration": 0, + "Value": "3000" + }, + { + "PowerHint": "GAME", + "Node": "CPUBigClusterDownRateLimitUs", + "Duration": 0, + "Value": "3000" + }, { "PowerHint": "THERMAL_VIRTUAL-SKIN-HINT_LIGHT", "Node": "PMU_POLL", From 79cc4d6fe73bd65d5cef3ba7dc70c2929f0922df Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Per=20=C3=85hgren?= Date: Fri, 8 Dec 2023 00:03:57 +0000 Subject: [PATCH 25/26] Update APMg3 and tuning configs for the tablet and dock mode to version 12 This CL updates the APMg3 tunings to version 12. The changes performed is to increase the AEC transparency as well as increase the robustness to echoes. The tunings have been verified by audio labs in TPE and STO and documented in https://docs.google.com/spreadsheets/d/1kL9XqE406CGI_LaggCmI9mJ1DUuelmvFMI4FksYEKJA/edit?pli=1#gid=674561254 https://docs.google.com/document/d/17FBTzIA7fuGnkS_fPvE4MN2sB_FKM2EPelPeBvTamzE/edit?tab=t.0#heading=h.h0idgem10n71 The sha256 checksums for the tuning files are uplink_tablet_stereo_config.pb: e7c4b95c28f87b4f62bbf320a244df7bd26f2075c3646a3ba962c746d409fa33 uplink_dock_config.pb: 7ac91df3386dd26c8bafec4bb5a52917507b4baf13934aec4262aa2fc2be2123 The tuning files are also available in the google3 folder third_party/apmg3/rtc_tools/dsp/tunings/tangorpro (being landed as part of google3 cl/588934009) Bug: 295551854 Test: Manual test calls on Tangor using Meet. Lab test performed by both STO and TPE labs Change-Id: Id6bf7439a6c02c866a06f47fad239c0fb3cef632 --- .../tuning/apmg3/uplink_dock_config.pb | Bin 2078 -> 2082 bytes .../apmg3/uplink_tablet_stereo_config.pb | Bin 2833 -> 2842 bytes 2 files changed, 0 insertions(+), 0 deletions(-) diff --git a/audio/tangorpro/tuning/apmg3/uplink_dock_config.pb b/audio/tangorpro/tuning/apmg3/uplink_dock_config.pb index 7996795fe7ce0c9c8dca52c4ca3b55a5d30dfe4a..2598ca2cad50c48c98f716880edf4623e25c1d5e 100644 GIT binary patch delta 151 zcmbOyut;FSO2)+-S9vfoGEV-?lp%DDk%L7@hl`&#U#Qti^nvaKtI4^{szI}6MmmTx zFeEt0o;~AZC&bTdZ2Z|CD8K*_kY!*vV6SRyY;3QRNDA#pmo5{J%ssU+fY4)NF z3=Q_OXV3W93Gwry3dk}r9I#iNHB-`FfkA`GfWv~*fy+ypS2L#H7O3ll6Hwm4K|xM~ h!+^np!GY03WbzZ{0B&v$2B0hhg9L-ZW=EEX%mDn(B8LC~ diff --git a/audio/tangorpro/tuning/apmg3/uplink_tablet_stereo_config.pb b/audio/tangorpro/tuning/apmg3/uplink_tablet_stereo_config.pb index 4c8a821bb6edac1518f3bcd12768b0af17eebde9..341b6e71b126eb0268af42c695551aad7ebcdd8c 100644 GIT binary patch delta 233 zcmbOzHcM>6O2!o%R~a+O%J4EUG}w!-b5Gna`>-m+UV%Y_(SXr{!S(E!Gj@}|GNmzI zn;gR|S^p+*hpi}3%vP4``eGZ|Su=0it1>V!*h}ef@$(uRZ?+d@U^rk8mK5UWO-oAy z2{b?ifU0NOtAfOUrZXF`T5vh=dCBsEOcP~rka3e`V0hr55TLTL4rYn M!GLkI9m{1l0HFFizyJUM delta 222 zcmbOwHc@QCO2+vcR~a)&i1RWqG}w!-b5Gna`>-m+UV%Y_(SX5%Ve&7gG{!5F6PYFJ zxvneQh(=hN*vN8SUu+{gYvxURRR#tIdnp|*e%?acE<4d#GbQc8l0y8vXsQ_)4%n-L zU-PILR_FJaAA5&|m}E>A>b85G29DD8$0SD8MKMCRG_G x|7KQI<(6PlJ$vSit%jU|h%Ly)rE89=n^!O Date: Wed, 13 Dec 2023 16:42:04 +0800 Subject: [PATCH 26/26] Branch bootloader prebuilts for 24Q2 release Bug: 313350495 Change-Id: I4383678c9071149b295be82924de451002803cae --- device-tangorpro.mk | 2 ++ tangorpro/BoardConfig.mk | 2 ++ 2 files changed, 4 insertions(+) diff --git a/device-tangorpro.mk b/device-tangorpro.mk index b6aa43c..54002a6 100644 --- a/device-tangorpro.mk +++ b/device-tangorpro.mk @@ -164,6 +164,8 @@ include device/google/tangorpro/fingerprint_config.mk PRODUCT_SOONG_NAMESPACES += vendor/google_devices/tangorpro/prebuilts ifneq (,$(filter AP1%,$(RELEASE_PLATFORM_VERSION))) PRODUCT_SOONG_NAMESPACES += vendor/google_devices/tangorpro/prebuilts/trusty/24Q1 +else ifneq (,$(filter AP2%,$(RELEASE_PLATFORM_VERSION))) +PRODUCT_SOONG_NAMESPACES += vendor/google_devices/tangorpro/prebuilts/trusty/24Q2 else PRODUCT_SOONG_NAMESPACES += vendor/google_devices/tangorpro/prebuilts/trusty/trunk endif diff --git a/tangorpro/BoardConfig.mk b/tangorpro/BoardConfig.mk index 7998f22..65d4c33 100644 --- a/tangorpro/BoardConfig.mk +++ b/tangorpro/BoardConfig.mk @@ -17,6 +17,8 @@ TARGET_BOARD_INFO_FILE := device/google/tangorpro/board-info.txt TARGET_BOOTLOADER_BOARD_NAME := tangorpro ifneq (,$(filter AP1%,$(RELEASE_PLATFORM_VERSION))) RELEASE_GOOGLE_PRODUCT_BOOTLOADER_DIR := bootloader/24Q1 +else ifneq (,$(filter AP2%,$(RELEASE_PLATFORM_VERSION))) +RELEASE_GOOGLE_PRODUCT_BOOTLOADER_DIR := bootloader/24Q2 else RELEASE_GOOGLE_PRODUCT_BOOTLOADER_DIR := bootloader/trunk endif