Commit graph

11 commits

Author SHA1 Message Date
Per Åhgren
f69dfd5994 Adjust Tangor VoIP tuning for code changes in AOC
This CL adjusts the Tangor tuning to handle recent
code changes in the counterpart in AOC. With the
tunings, the behavior is identical to prior to
the changes in AOC.

Bug: 295551854
Test: Manual testing in calls on TangorPro.
Change-Id: I59f5753e972241e3f24f3e142daad8cbe81c5cf2
2024-02-22 23:17:34 +00:00
Per Åhgren
ef78469515 Extend the APMg3 AOC control to handle more profiles
This CL extends the APMg3 AOC control to handle more profiles
to a scheme which is tailored to also handle phones

Bug: 295551854
Test: Manual testing in calls on TangorPro.
Change-Id: I17046fb373f8c1e7c21d52bc016487f6714603b7
2024-02-01 13:01:41 +00:00
Per Åhgren
79cc4d6fe7 Update APMg3 and tuning configs for the tablet and dock mode to version 12
This CL updates the APMg3 tunings to version 12.
The changes performed is to increase the AEC transparency as well as
increase the robustness to echoes.

The tunings have been verified by audio labs in TPE and STO and documented in
https://docs.google.com/spreadsheets/d/1kL9XqE406CGI_LaggCmI9mJ1DUuelmvFMI4FksYEKJA/edit?pli=1#gid=674561254
https://docs.google.com/document/d/17FBTzIA7fuGnkS_fPvE4MN2sB_FKM2EPelPeBvTamzE/edit?tab=t.0#heading=h.h0idgem10n71

The sha256 checksums for the tuning files are
uplink_tablet_stereo_config.pb: e7c4b95c28f87b4f62bbf320a244df7bd26f2075c3646a3ba962c746d409fa33
uplink_dock_config.pb: 7ac91df3386dd26c8bafec4bb5a52917507b4baf13934aec4262aa2fc2be2123

The tuning files are also available in the google3 folder
third_party/apmg3/rtc_tools/dsp/tunings/tangorpro
(being landed as part of google3 cl/588934009)

Bug: 295551854
Test: Manual test calls on Tangor using Meet. Lab test performed by both STO and TPE labs
Change-Id: Id6bf7439a6c02c866a06f47fad239c0fb3cef632
2023-12-08 00:05:06 +00:00
Per Åhgren
6423f901ed Update APMg3 and tuning configs to version 11
This CL updates the APMg3 tunings to version 11.
The changes performed is to remove any signal level gains applied in APMg3 in AOC
for the headset usecase when the AEC is off. This eliminates the issue of 25 dB
gain being applied when headsets are used causing some headset audio signals to be
saturated.

This is a correction of the CL
https://googleplex-android-review.git.corp.google.com/c/device/google/tangorpro/+/25019613
which both included an active gain for headsets when the AEC is off.

As a safety precaution, and to allow easier spotting of such issues, the CL also
explicitly sets the gains to 0 dB also for the other headset tuning (before it was
just deactivating the gain application for that)

Bug: 309517292
Test: Manual test calls on Tangor using Meet.
Change-Id: I4f29cd780fa6ca52df543387546d2a4b4b161139
2023-11-29 08:07:10 +00:00
Per Åhgren
45e117b890 Extend the APMg3 tunings to also handling turning AEC off
This CL extends APMg3 tunings for the tablet, dock and headset usecases with counterparts where the AEC is off.

Bug: 301568974
Test: Running CTS test suite verification. Manual testing in calls on Tangor.
Change-Id: I87fd24ba084691c238f5c07272208049acaf2e5d
2023-10-12 07:10:22 +00:00
Per Åhgren
84beed357e Update APMg3 and tuning configs to version 9
This CL updates the APMg3 tunings to version 9. The changes performed is to reduce the post-AEC gain to the level that was in the v4 tunings (a 7 dB reduction), as the gain in v8 has been shown to sometimes saturate the nearend.

The tunings are available at
https://drive.google.com/drive/folders/11dKj-dpkNUlcci8kTsxi3lN5Ht5FEzXu?usp=drive_link
Complexity and memory figures are basically the same (slightly lower) as for https://docs.google.com/spreadsheets/d/1ZtPoIw3SGPKErR8xURvp3gyDvNNl7bISCzLFH_HDOIc/edit?usp=sharing&resourcekey=0-q7s7VtDqDSf762Lvb4d7gA

Bug: 302471415
Test: Manual test calls on Tangor using Meet. Lab testing in TPE labs with ACQUA/Headacoustics. Offline testing on recordings.
Change-Id: I12309ab01772724cda9da6bb793586bf0d79715e
2023-09-28 17:53:01 +00:00
Per Åhgren
1bb9b6b916 Update APMg3 and tuning configs to version 8
This CL updates the APMg3 tunings to version 8. The changes performed is to remove a high-pass filter that replicated what the 3P provider did. Removing this high-pass filter improves the clarity of the near-end speech while having negligible impact on the rest of the processing.

The tunings are available at
https://drive.google.com/drive/folders/1_8KdDcCLUb_ycSY3IMgO3Af11a8McU0S?usp=sharing
Complexity and memory figures are basically the same (slightly lower) as for https://docs.google.com/spreadsheets/d/1ZtPoIw3SGPKErR8xURvp3gyDvNNl7bISCzLFH_HDOIc/edit?usp=sharing&resourcekey=0-q7s7VtDqDSf762Lvb4d7gA

Bug: 301140272
Test: Manual test calls on Tangor using Meet. Lab testing in audio labs with ACQUA/Headacoustics test suites.
Change-Id: I02a604cb88086c160996cd7e46d7f10f876e68eb
2023-09-19 23:00:10 +00:00
Per Åhgren
79357a1d08 Update APMg3 and tuning configs to version 7
This CL updates the APMg3 tunings to version 7. The changes performed is to remove any signal level gains applied in APMg3 in AOC for the headset usecase. This eliminates the issue of APMg3 applying 25 dB gain when headsets are used causing some headset audio signals to be saturated.

The tunings are available at
https://drive.google.com/drive/folders/1TICEDO_vHlpWR8My91kxJrWTpGNqIStE?usp=sharing.
Complexity and memory figures are basically the same (slightly lower) as for https://docs.google.com/spreadsheets/d/1ZtPoIw3SGPKErR8xURvp3gyDvNNl7bISCzLFH_HDOIc/edit?usp=sharing&resourcekey=0-q7s7VtDqDSf762Lvb4d7gA

Bug: 300147435
Test: Manual test calls on Tangor using Meet.
Change-Id: Ib06e05cbaa0e632deb9a4961a98d0ce9737121fb
2023-09-12 21:58:06 +00:00
Per Åhgren
733cea1ebd Update APMg3 and tuning configs to version 6
This CL updates the APMg3 tunings to version 6 (previous version was version 4, and version 5 was skipped).

The tunings are available at
https://drive.google.com/drive/folders/12x0vnEtbDcFyqCKkT7iJISYhOcKmMN2R?usp=sharing. Complexity and memory figures are basically the same as for https://docs.google.com/spreadsheets/d/1ZtPoIw3SGPKErR8xURvp3gyDvNNl7bISCzLFH_HDOIc/edit?usp=sharing&resourcekey=0-q7s7VtDqDSf762Lvb4d7gA

Bug: 292144567
Test: Manual test calls on Tangor using Meet, together with TAP-points recordings for verification, as well as lab benchmarking in the STO audio lab.
Change-Id: I26fe9b8ce430e8cb2143d7b6e0d5e1c80b2c2556
2023-09-05 17:12:59 +00:00
Per Åhgren
04570db34b Update APMg3 and tuning configs.
This CL updates the APMg3 tunings to version 4.

The tunings are available at
https://drive.google.com/drive/folders/1wbYVjMkirbOcdV37DIeT5oipXfGrx1YT?usp=drive_link
and complexity and memory figures for the tunings are available at https://docs.google.com/spreadsheets/d/1ZtPoIw3SGPKErR8xURvp3gyDvNNl7bISCzLFH_HDOIc/edit?usp=sharing&resourcekey=0-q7s7VtDqDSf762Lvb4d7gA

Bug: 292144567
Test: Manual test on Tangor with Meet call.
Change-Id: Id2f5cec85a2b5436b15cbe2981c5b272211d10e6
2023-08-15 14:20:43 +00:00
Viktor Grönroos
846117a234 Install APMg3 external module and tuning configs.
Bug: 292144567
Test: Manual test on Tangor with Meet call.
Change-Id: I1516875745b6ad3696eb5c179866646af0ea5981
2023-08-02 07:49:41 +00:00