anierin/msm-5.15
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

soc: sifive: l2_cache: fix missing of_node_put() in sifive_l2_init()

Browse Source 
commit 8fbf94fea0b4e187ca9100936c5429f96b8a4e44 upstream.

The device_node pointer returned by of_find_matching_node() with
refcount incremented, when finish using it, the refcount need be
decreased.

Fixes: a967a289f1 ("RISC-V: sifive_l2_cache: Add L2 cache controller driver for SiFive SoCs")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
[conor: cache -> l2_cache]
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Yang Yingliang
2023-04-24 10:19:04 +01:00
committed by Greg Kroah-Hartman
parent 71e7ed6e3a
commit 4aed6b5809
1 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
drivers/soc/sifive/sifive_l2_cache.c
View File

@@ -202,12 +202,16 @@ static int __init sifive_l2_init(void)
if (!np)
return -ENODEV;
if (of_address_to_resource(np, 0, &res))
return -ENODEV;
if (of_address_to_resource(np, 0, &res)) {
rc = -ENODEV;
goto err_node_put;
}
l2_base = ioremap(res.start, resource_size(&res));
if (!l2_base)
return -ENOMEM;
if (!l2_base) {
rc = -ENOMEM;
goto err_node_put;
}
intr_num = of_property_count_u32_elems(np, "interrupts");
if (!intr_num) {
@@ -224,6 +228,7 @@ static int __init sifive_l2_init(void)
goto err_free_irq;
}
}
of_node_put(np);
l2_config_read();
@@ -240,6 +245,8 @@ err_free_irq:
free_irq(g_irq[i], NULL);
err_unmap:
iounmap(l2_base);
err_node_put:
of_node_put(np);
return rc;
}
device_initcall(sifive_l2_init);