Revert "BACKPORT: FROMLIST: PCI: dwc: Drop dependency on ZONE_DMA32"

This reverts commit 6c9828727f. Need to
update this FROMLIST patch to pull in the v6 changes. It's been accepted
into the maintainers tree now.

Bug: 241473543
Change-Id: Ie24d5125eafc48d8d3cbd1818e85eb798550150d
Signed-off-by: Will McVicker <willmcvicker@google.com>
This commit is contained in:
Will McVicker
2022-08-29 22:22:32 +00:00
committed by Treehugger Robot
parent c5e662db60
commit a8dfddb2b9
2 changed files with 18 additions and 8 deletions

View File

@@ -263,6 +263,15 @@ static void dw_pcie_free_msi(struct pcie_port *pp)
irq_domain_remove(pp->msi_domain);
irq_domain_remove(pp->irq_domain);
if (pp->msi_data) {
struct dw_pcie *pci = to_dw_pcie_from_pp(pp);
struct device *dev = pci->dev;
dma_unmap_page(dev, pp->msi_data, PAGE_SIZE, DMA_FROM_DEVICE);
if (pp->msi_page)
__free_page(pp->msi_page);
}
}
static void dw_pcie_msi_init(struct pcie_port *pp)
@@ -287,7 +296,6 @@ int dw_pcie_host_init(struct pcie_port *pp)
struct resource_entry *win;
struct pci_host_bridge *bridge;
struct resource *cfg_res;
u64 *msi_vaddr;
int ret;
raw_spin_lock_init(&pci->pp.lock);
@@ -366,15 +374,18 @@ int dw_pcie_host_init(struct pcie_port *pp)
dw_chained_msi_isr,
pp);
ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(32));
ret = dma_set_mask(pci->dev, DMA_BIT_MASK(32));
if (ret)
dev_warn(pci->dev, "Failed to set DMA mask to 32-bit. Devices with only 32-bit MSI support may not work properly\n");
msi_vaddr = dmam_alloc_coherent(dev, sizeof(u64), &pp->msi_data,
GFP_KERNEL);
if (!msi_vaddr) {
dev_err(dev, "Failed to alloc and map MSI data\n");
ret = -ENOMEM;
pp->msi_page = alloc_page(GFP_DMA32);
pp->msi_data = dma_map_page(pci->dev, pp->msi_page, 0, PAGE_SIZE,
DMA_FROM_DEVICE);
if (dma_mapping_error(pci->dev, pp->msi_data)) {
dev_err(pci->dev, "Failed to map MSI data\n");
__free_page(pp->msi_page);
pp->msi_page = NULL;
pp->msi_data = 0;
goto err_free_msi;
}
}

View File

@@ -191,7 +191,6 @@ struct pcie_port {
struct irq_domain *irq_domain;
struct irq_domain *msi_domain;
dma_addr_t msi_data;
/* msi_page is deprecated. Keeping for ABI compatibility */
struct page *msi_page;
struct irq_chip *msi_irq_chip;
u32 num_vectors;