anierin/msm-5.15
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ANDROID: fuse-bpf: Do not change bpf program in lookups

Browse Source 
If a lookup finds an existing inode, it must not change the existing bpf
program since it may be in use.

Bug: 267095363
Test: fuse_test, atest CtsScopedStorageHostTest
Change-Id: Icb00681fbcd51fdd4b0764906509093d98caeec4
Signed-off-by: Paul Lawrence <paullawrence@google.com>
This commit is contained in:
Paul Lawrence
2023-02-10 11:11:33 -08:00
committed by Treehugger Robot
parent dd72bb259f
commit aba5f5754b
1 changed files with 21 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
fs/fuse/backing.c
View File

@@ -1187,27 +1187,26 @@ int fuse_handle_backing(struct fuse_entry_bpf *feb, struct inode **backing_inode
int fuse_handle_bpf_prog(struct fuse_entry_bpf *feb, struct inode *parent,
struct bpf_prog **bpf)
{
struct fuse_inode *pi;
struct bpf_prog *new_bpf;
// Parent isn't presented, but we want to keep
// Don't touch bpf program at all in this case
/* Parent isn't presented, but we want to keep
* Don't touch bpf program at all in this case
*/
if (feb->out.bpf_action == FUSE_ACTION_KEEP && !parent)
goto out;
if (*bpf) {
bpf_prog_put(*bpf);
*bpf = NULL;
}
return 0;
switch (feb->out.bpf_action) {
case FUSE_ACTION_KEEP:
pi = get_fuse_inode(parent);
*bpf = pi->bpf;
if (*bpf)
bpf_prog_inc(*bpf);
case FUSE_ACTION_KEEP: {
struct fuse_inode *pi = get_fuse_inode(parent);
new_bpf = pi->bpf;
if (new_bpf)
bpf_prog_inc(new_bpf);
break;
}
case FUSE_ACTION_REMOVE:
new_bpf = NULL;
break;
case FUSE_ACTION_REPLACE: {
@@ -1220,7 +1219,7 @@ int fuse_handle_bpf_prog(struct fuse_entry_bpf *feb, struct inode *parent,
if (IS_ERR(bpf_prog))
return PTR_ERR(bpf_prog);
*bpf = bpf_prog;
new_bpf = bpf_prog;
break;
}
@@ -1228,7 +1227,13 @@ int fuse_handle_bpf_prog(struct fuse_entry_bpf *feb, struct inode *parent,
return -EINVAL;
}
out:
/* Cannot change existing program */
if (*bpf) {
bpf_prog_put(new_bpf);
return new_bpf == *bpf ? 0 : -EINVAL;
}
*bpf = new_bpf;
return 0;
}