FROMGIT: usb: typec: ucsi: Acknowledge the GET_ERROR_STATUS command completion

We found PPM will not send any notification after it report error status
and OPM issue GET_ERROR_STATUS command to read the details about error.

According UCSI spec, PPM may clear the Error Status Data after the OPM
has acknowledged the command completion.

This change add operation to acknowledge the command completion from PPM.

Fixes: bdc62f2bae (usb: typec: ucsi: Simplified registration and I/O API)
Cc: <stable@vger.kernel.org> # 5.10
Signed-off-by: Jack Pham <quic_jackp@quicinc.com>
Signed-off-by: Linyu Yuan <quic_linyyuan@quicinc.com>
Link: https://lore.kernel.org/r/1658817949-4632-1-git-send-email-quic_linyyuan@quicinc.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

(cherry picked from commit a7dc438b5e446afcd1b3b6651da28271400722f2
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-next)

Bug: 241140735
Change-Id: I8447d618200163c6819f93f8d8b5b7f2bece5e13
Signed-off-by: Mayank Rana <quic_mrana@quicinc.com>
This commit is contained in:
Linyu Yuan
2022-07-26 14:45:49 +08:00
committed by Treehugger Robot
parent 6349c3bbd5
commit b109cefd6f

View File

@@ -76,6 +76,10 @@ static int ucsi_read_error(struct ucsi *ucsi)
if (ret)
return ret;
ret = ucsi_acknowledge_command(ucsi);
if (ret)
return ret;
switch (error) {
case UCSI_ERROR_INCOMPATIBLE_PARTNER:
return -EOPNOTSUPP;