Dave Hansen 41d8b591d7
uaccess: Add speculation barrier to copy_from_user() ...
commit 74e19ef0ff8061ef55957c3abd71614ef0f42f47 upstream.
The results of "access_ok()" can be mis-speculated. The result is that
you can end speculatively:
if (access_ok(from, size))
// Right here
even for bad from/size combinations. On first glance, it would be ideal
to just add a speculation barrier to "access_ok()" so that its results
can never be mis-speculated.
But there are lots of system calls just doing access_ok() via
"copy_to_user()" and friends (example: fstat() and friends). Those are
generally not problematic because they do not _consume_ data from
userspace other than the pointer. They are also very quick and common
system calls that should not be needlessly slowed down.
"copy_from_user()" on the other hand uses a user-controller pointer and
is frequently followed up with code that might affect caches. Take
something like this:
if (!copy_from_user(&kernelvar, uptr, size))
do_something_with(kernelvar);
If userspace passes in an evil 'uptr' that *actually* points to a kernel
addresses, and then do_something_with() has cache (or other)
side-effects, it could allow userspace to infer kernel data values.
Add a barrier to the common copy_from_user() code to prevent
mis-speculated values which happen after the copy.
Also add a stub for architectures that do not define barrier_nospec().
This makes the macro usable in generic code.
Since the barrier is now usable in generic code, the x86 #ifdef in the
BPF code can also go away.
Reported-by: Jordy Zomer <jordyzomer@google.com >
Suggested-by: Linus Torvalds <torvalds@linuxfoundation.org >
Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com >
Reviewed-by: Thomas Gleixner <tglx@linutronix.de >
Acked-by: Daniel Borkmann <daniel@iogearbox.net > # BPF bits
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-02-25 12:06:44 +01:00
2022-04-08 14:23:57 +02:00
2022-12-19 12:36:42 +01:00
2022-05-25 09:57:28 +02:00
2021-07-19 14:28:56 +02:00
2021-07-21 11:53:42 +02:00
2021-11-18 19:17:06 +01:00
2021-07-21 13:14:08 +02:00
2021-07-21 19:54:21 -07:00
2021-08-04 09:53:34 +01:00
2023-02-01 08:27:08 +01:00
2022-12-31 13:14:29 +01:00
2022-08-17 14:22:47 +02:00
2022-08-17 14:24:09 +02:00
2023-01-12 11:59:11 +01:00
2022-12-08 11:28:42 +01:00
2022-06-09 10:23:25 +02:00
2023-01-12 11:59:15 +01:00
2022-08-31 17:16:40 +02:00
2021-09-20 12:43:34 +01:00
2021-07-05 14:16:22 -07:00
2022-11-26 09:24:32 +01:00
2021-09-01 15:25:28 -07:00
2022-07-12 16:34:53 +02:00
2021-08-23 11:06:28 +01:00
2023-02-01 08:27:20 +01:00
2022-12-31 13:13:57 +01:00
2022-08-17 14:23:48 +02:00
2021-10-14 12:47:29 +01:00
2021-08-29 14:47:42 +03:00
2023-01-12 11:59:08 +01:00
2021-11-18 19:15:59 +01:00
2022-12-31 13:14:28 +01:00
2022-08-17 14:23:11 +02:00
2023-02-22 12:57:00 +01:00
2022-08-17 14:23:11 +02:00
2022-03-11 12:22:34 +01:00
2022-10-26 12:35:12 +02:00
2021-07-16 18:46:45 +02:00
2021-09-03 09:58:10 -07:00
2022-06-22 14:22:02 +02:00
2022-04-08 14:24:17 +02:00
2021-08-31 09:41:22 -07:00
2022-07-29 17:25:25 +02:00
2021-08-13 10:27:49 +02:00
2021-07-07 20:01:45 -07:00
2022-07-12 16:34:57 +02:00
2022-04-08 14:22:59 +02:00
2021-08-23 12:54:30 -06:00
2022-01-27 11:04:15 +01:00
2022-08-31 17:16:34 +02:00
2021-09-09 19:14:33 -04:00
2021-10-26 12:35:16 -07:00
2022-11-16 09:58:15 +01:00
2021-11-18 19:16:20 +01:00
2022-11-16 09:58:15 +01:00
2022-08-25 11:40:02 +02:00
2021-07-30 22:22:36 -04:00
2021-07-30 22:22:36 -04:00
2021-08-25 19:41:39 -07:00
2021-07-15 22:31:10 +02:00
2022-09-15 11:30:00 +02:00
2021-07-08 11:48:22 -07:00
2021-08-16 10:50:32 -06:00
2021-09-01 10:29:10 +02:00
2021-11-18 19:17:21 +01:00
2021-07-30 22:13:09 -04:00
2022-07-21 21:24:13 +02:00
2022-12-14 11:37:19 +01:00
2021-09-01 15:26:45 -07:00
2022-12-14 11:37:14 +01:00
2021-09-03 09:58:17 -07:00
2022-06-09 10:22:48 +02:00
2022-07-12 16:35:01 +02:00
2022-07-12 16:35:01 +02:00
2021-09-13 10:18:28 -07:00
2022-07-12 16:35:01 +02:00
2022-02-23 12:03:17 +01:00
2021-11-18 19:16:03 +01:00
2022-04-08 14:24:18 +02:00
2021-08-18 22:33:28 +02:00
2021-08-09 20:17:36 +01:00
2022-07-23 12:54:02 +02:00
2023-02-01 08:27:29 +01:00
2022-05-30 09:29:09 +02:00
2022-09-28 11:11:40 +02:00
2021-08-20 12:32:59 +02:00
2021-07-08 11:48:22 -07:00
2021-08-24 17:09:01 -05:00
2021-09-08 11:50:24 -07:00
2021-08-26 16:52:03 -07:00
2021-08-17 17:29:10 +02:00
2022-12-31 13:14:03 +01:00
2021-07-08 11:48:20 -07:00
2021-12-14 10:57:11 +01:00
2021-07-19 12:13:06 +02:00
2023-01-12 11:58:51 +01:00
2021-08-31 14:55:09 -07:00
2021-09-03 10:34:44 -07:00
2021-07-29 12:54:10 -07:00
2022-07-07 17:53:26 +02:00
2021-11-18 19:16:00 +01:00
2021-08-18 13:27:49 +02:00
2021-08-19 09:02:39 +02:00
2022-04-08 14:24:13 +02:00
2021-11-25 09:48:41 +01:00
2022-10-26 12:35:08 +02:00
2021-07-20 09:20:49 -07:00
2023-01-12 11:59:20 +01:00
2021-10-18 20:22:03 -10:00
2021-09-07 21:17:28 +02:00
2021-08-19 11:19:41 +01:00
2021-08-26 15:32:28 -04:00
2022-04-27 14:38:50 +02:00
2021-11-18 19:17:06 +01:00
2022-03-08 19:12:39 +01:00
2023-01-24 07:22:43 +01:00
2021-08-20 11:39:26 +01:00
2022-06-14 18:36:06 +02:00
2021-08-26 15:32:10 -04:00
2022-06-14 18:36:21 +02:00
2021-08-10 13:08:49 +02:00
2022-04-08 14:22:59 +02:00
2022-07-12 16:35:09 +02:00
2021-07-27 11:00:36 +02:00
2021-09-06 07:20:56 -04:00
2022-03-08 19:12:40 +01:00
2021-11-18 19:16:25 +01:00
2022-01-20 09:13:13 +01:00
2023-01-12 11:59:14 +01:00
2021-08-27 13:34:02 +01:00
2022-01-11 15:35:11 +01:00
2022-11-10 18:15:37 +01:00
2022-02-01 17:27:15 +01:00
2021-08-03 14:31:40 +02:00
2022-06-09 10:22:47 +02:00
2021-07-30 18:35:47 +02:00
2022-03-16 14:23:46 +01:00
2022-06-09 10:23:20 +02:00
2021-07-26 15:09:44 +02:00
2021-07-27 20:11:45 +01:00
2021-07-27 20:11:44 +01:00
2022-01-27 11:04:41 +01:00
2023-02-09 11:26:45 +01:00
2021-09-03 09:58:13 -07:00
2021-07-08 11:48:21 -07:00
2021-08-10 14:42:49 +02:00
2021-08-10 17:57:23 +02:00
2021-09-03 09:58:16 -07:00
2023-02-22 12:57:07 +01:00
2022-05-30 09:29:09 +02:00
2022-12-31 13:14:39 +01:00
2021-08-12 17:26:24 +02:00
2022-08-17 14:23:29 +02:00
2022-03-23 09:16:42 +01:00
2021-08-04 12:35:07 +01:00
2021-08-05 11:46:42 +01:00
2021-07-23 09:27:02 -04:00
2021-08-13 06:41:22 -07:00
2021-12-29 12:28:49 +01:00
2022-09-20 12:39:43 +02:00
2021-07-15 20:49:09 +02:00
2021-08-19 10:41:08 +02:00
2021-08-10 22:50:07 +02:00
2021-08-23 13:10:37 -06:00
2022-08-25 11:40:41 +02:00
2021-07-21 08:14:33 -07:00
2021-07-21 08:14:33 -07:00
2021-07-21 08:14:33 -07:00
2022-05-01 17:22:32 +02:00
2021-09-03 10:44:35 -07:00
2022-05-25 09:57:22 +02:00
2022-08-11 13:07:50 +02:00
2022-10-26 12:35:26 +02:00
2021-11-25 09:48:42 +01:00
2022-04-13 20:59:03 +02:00
2021-08-10 10:59:20 +02:00
2021-09-22 14:29:32 +01:00
2022-09-20 12:39:42 +02:00
2021-07-31 22:20:24 -04:00
2022-03-08 19:12:32 +01:00
2022-06-14 18:36:23 +02:00
2021-07-08 11:48:22 -07:00
2021-08-02 18:14:21 +01:00
2022-03-08 19:12:38 +01:00
2021-07-27 17:05:06 +01:00
2021-11-18 19:16:13 +01:00
2022-05-09 09:14:30 +02:00
2021-07-27 09:29:15 +02:00
2022-07-21 21:24:29 +02:00
2022-04-27 14:38:51 +02:00
2022-08-17 14:24:08 +02:00
2021-12-08 09:04:41 +01:00
2022-10-29 10:12:54 +02:00
2021-09-06 06:30:45 -04:00
2021-08-18 08:27:30 +02:00
2022-12-31 13:14:06 +01:00
2021-08-13 18:37:38 +02:00
2021-07-08 11:48:21 -07:00
2022-07-12 16:35:08 +02:00
2021-08-17 19:08:49 +02:00
2022-08-17 14:23:08 +02:00
2021-07-08 11:48:20 -07:00
2021-11-12 15:05:48 +01:00
2021-11-12 15:05:48 +01:00
2022-06-09 10:23:12 +02:00
2021-07-11 10:02:33 -07:00
2023-01-12 11:59:07 +01:00
2022-12-14 11:37:18 +01:00
2021-08-11 09:50:11 -06:00
2021-09-19 12:08:37 +01:00
2021-07-29 17:08:04 +02:00
2022-01-05 12:42:33 +01:00
2022-08-31 17:16:48 +02:00
2021-09-08 11:50:23 -07:00
2021-10-18 20:22:02 -10:00
2021-09-03 09:58:17 -07:00
2022-07-12 16:35:10 +02:00
2022-08-17 14:23:43 +02:00
2021-12-14 10:57:22 +01:00
2021-09-24 16:13:35 -07:00
2021-08-19 13:06:53 +01:00
2021-08-19 09:02:55 +09:00
2021-08-09 15:49:00 -07:00
2022-07-12 16:35:17 +02:00
2021-09-03 18:42:01 +02:00
2021-09-16 13:05:42 -07:00
2021-08-20 12:32:58 +02:00
2021-07-08 11:48:21 -07:00
2022-04-13 20:59:28 +02:00
2022-07-02 16:41:16 +02:00
2021-08-26 10:36:51 -06:00
2021-07-19 11:57:48 +02:00
2021-08-16 14:42:22 +02:00
2021-11-18 19:17:14 +01:00
2021-08-17 19:05:29 +02:00
2022-06-09 10:23:32 +02:00
2022-05-18 10:26:47 +02:00
2022-12-31 13:14:42 +01:00
2021-08-25 15:20:25 +01:00
2022-06-09 10:23:17 +02:00
2022-09-20 12:39:42 +02:00
2022-11-03 23:59:10 +09:00
2022-08-25 11:40:43 +02:00
2022-06-14 18:36:24 +02:00
2023-02-25 12:06:44 +01:00
2021-08-16 18:55:32 +02:00
2021-07-28 15:33:59 +02:00
2023-01-12 11:58:43 +01:00
2021-09-14 09:02:50 +02:00
2023-02-09 11:26:45 +01:00
2022-07-23 12:54:08 +02:00
2022-09-23 14:15:48 +02:00
2022-01-27 11:04:15 +01:00
2021-08-05 21:21:58 +02:00
2022-03-08 19:12:42 +01:00
2021-09-07 12:27:27 -07:00
2021-08-25 15:43:26 -05:00
2021-07-29 09:02:27 +02:00
2022-08-17 14:23:14 +02:00
2022-10-26 12:34:49 +02:00
2022-12-31 13:14:33 +01:00
2021-09-17 13:52:17 +01:00
2021-07-30 10:58:36 +08:00
2021-09-08 11:50:24 -07:00
2021-09-08 11:50:24 -07:00
2021-10-28 17:18:55 -07:00
2022-05-01 17:22:29 +02:00
2023-02-01 08:27:22 +01:00
2022-03-16 14:23:46 +01:00
2021-08-18 17:32:42 -05:00
2022-08-17 14:22:57 +02:00
2021-09-02 17:59:58 +02:00
2021-07-06 10:37:46 -05:00
2021-08-19 14:13:28 +01:00
2021-09-07 19:13:42 -07:00
2022-04-08 14:23:37 +02:00
2021-07-08 11:48:21 -07:00
2021-07-08 11:48:20 -07:00
2022-11-03 23:59:15 +09:00
2022-02-08 18:34:05 +01:00
2022-07-07 17:53:24 +02:00
2022-10-29 10:12:56 +02:00
2021-08-10 12:53:04 +02:00
2022-08-17 14:22:51 +02:00
2021-09-20 22:28:47 +02:00
2021-08-18 16:08:11 +02:00
2021-08-26 11:28:07 -07:00
2021-08-16 18:45:29 +02:00
2022-07-12 16:35:09 +02:00
2022-07-02 16:41:17 +02:00
2021-08-18 22:08:24 +02:00
2021-11-18 19:17:14 +01:00
2021-08-14 12:48:07 +02:00
2022-05-30 09:29:15 +02:00
2021-08-17 19:06:04 +02:00
2021-11-25 09:48:45 +01:00
2022-12-31 13:14:09 +01:00
2021-07-16 19:17:05 +02:00
2022-02-01 17:27:01 +01:00
2022-02-01 17:27:15 +01:00
2022-04-08 14:23:01 +02:00
2022-06-09 10:23:01 +02:00
2022-01-27 11:03:52 +01:00
2022-06-09 10:22:29 +02:00
2021-09-02 21:38:56 +02:00
2021-10-07 16:51:57 +02:00
2021-08-04 14:23:31 -05:00
2023-02-25 12:06:43 +01:00
2022-04-08 14:23:06 +02:00
2022-06-29 09:03:17 +02:00
2021-08-17 17:36:48 +02:00
2021-08-17 17:36:48 +02:00
2021-08-06 13:41:48 -07:00
2021-08-10 11:00:53 -07:00
2021-08-06 13:41:48 -07:00
2021-08-26 13:40:35 +01:00
2021-07-28 14:57:31 -05:00
2021-08-11 18:42:53 +02:00
2022-07-21 21:24:15 +02:00
2022-11-26 09:24:42 +01:00
2022-09-05 10:30:07 +02:00
2021-11-18 19:16:58 +01:00
2021-08-17 17:37:26 +02:00
2022-07-12 16:35:17 +02:00
2021-08-17 17:12:22 +02:00
2021-08-17 17:50:51 +02:00
2021-08-17 17:50:51 +02:00
2021-09-02 22:07:17 +02:00
2021-08-24 19:52:40 -03:00
2022-10-26 12:35:49 +02:00
2022-10-12 09:53:26 +02:00
2021-07-13 11:39:48 +01:00
2021-10-18 20:22:03 -10:00
2022-05-25 09:57:37 +02:00
2022-07-12 16:35:08 +02:00
2021-08-13 09:12:53 +02:00
2022-10-26 12:35:14 +02:00
2022-12-02 17:40:59 +01:00
2021-08-13 09:14:36 +02:00
2021-07-08 11:48:20 -07:00
2021-09-03 09:58:12 -07:00
2021-07-08 11:48:21 -07:00
2021-11-18 19:16:01 +01:00
2021-07-23 13:16:43 -05:00
2022-05-30 09:29:15 +02:00
2022-10-26 12:35:52 +02:00
2022-12-31 13:14:14 +01:00
2021-09-04 10:22:01 +02:00
2021-08-31 16:43:06 -07:00
2021-08-17 17:43:24 +02:00
2021-08-17 19:06:13 +02:00
2021-08-17 19:06:13 +02:00
2021-08-17 19:06:13 +02:00
2021-08-17 17:43:24 +02:00
2021-08-06 13:41:48 -07:00
2022-04-13 20:59:28 +02:00
2022-04-13 20:59:28 +02:00
2021-08-17 11:47:43 +02:00
2022-04-13 20:59:28 +02:00
2021-08-19 09:02:55 +09:00
2022-07-12 16:35:03 +02:00
2023-02-22 12:57:02 +01:00
2021-11-21 13:44:12 +01:00
2022-02-16 12:56:19 +01:00
2022-12-08 11:28:44 +01:00
2022-04-08 14:24:17 +02:00
2021-09-09 13:25:49 -07:00
2023-02-01 08:27:19 +01:00
2022-07-21 21:24:35 +02:00
2021-08-05 14:47:31 +02:00
2022-10-26 12:34:48 +02:00
2022-03-02 11:47:51 +01:00
2023-02-01 08:27:15 +01:00
2021-09-08 11:50:28 -07:00
2021-08-09 14:58:29 +03:00
2021-09-08 17:44:26 +02:00
2022-12-31 13:14:02 +01:00
2022-05-30 09:29:13 +02:00
2022-08-17 14:23:22 +02:00
2023-01-18 11:48:48 +01:00
2021-11-18 19:16:41 +01:00
2022-10-26 12:34:31 +02:00
2021-10-18 18:12:09 -04:00
2022-11-26 09:24:49 +01:00
2021-09-22 10:24:01 -04:00
2021-08-16 11:37:21 -04:00
2021-07-27 12:12:07 +02:00
2021-07-27 12:17:21 +02:00
2022-07-29 17:25:32 +02:00
2021-07-27 12:12:07 +02:00
2021-07-27 12:12:08 +02:00
2021-07-27 12:12:08 +02:00
2021-07-07 20:01:45 -07:00
2022-08-25 11:40:34 +02:00
2021-09-08 15:32:35 -07:00
2022-09-15 11:30:05 +02:00
2022-05-01 17:22:33 +02:00
2021-09-08 12:55:35 -07:00
2023-01-24 07:22:44 +01:00
2021-10-18 16:02:30 -05:00
2021-09-03 09:58:16 -07:00
2023-02-09 11:26:33 +01:00
2021-09-06 07:20:57 -04:00
2022-04-20 09:34:13 +02:00
2021-08-11 09:50:11 -06:00
2021-07-21 10:29:10 +02:00
2021-09-06 07:20:57 -04:00
2022-03-16 14:23:43 +01:00
2021-12-29 12:28:43 +01:00
2021-07-08 07:49:01 -04:00
2022-03-16 14:23:43 +01:00
2021-09-03 09:58:16 -07:00
2022-07-12 16:35:01 +02:00
2021-09-03 09:58:17 -07:00
2021-08-11 06:44:24 -04:00
2021-07-27 12:23:20 +02:00
2022-08-17 14:23:01 +02:00
2022-03-16 14:23:44 +01:00
2021-08-22 10:28:08 +02:00
2022-11-26 09:24:51 +01:00
2021-09-13 07:53:27 -10:00
2021-09-03 10:08:28 -07:00
2021-08-17 19:05:11 +02:00
2021-08-05 14:37:04 +02:00
41d8b591d7