Laurence de Bruxelles
087d45cd0f
rtc: pxa: fix null pointer dereference
...
commit 34127b3632b21e5c391756e724b1198eb9917981 upstream.
With the latest stable kernel versions the rtc on the PXA based
Zaurus does not work, when booting I see the following kernel messages:
pxa-rtc pxa-rtc: failed to find rtc clock source
pxa-rtc pxa-rtc: Unable to init SA1100 RTC sub-device
pxa-rtc: probe of pxa-rtc failed with error -2
hctosys: unable to open rtc device (rtc0)
I think this is because commit f2997775b1 ("rtc: sa1100: fix possible
race condition") moved the allocation of the rtc_device struct out of
sa1100_rtc_init and into sa1100_rtc_probe. This means that pxa_rtc_probe
also needs to do allocation for the rtc_device struct, otherwise
sa1100_rtc_init will try to dereference a null pointer. This patch adds
that allocation by copying how sa1100_rtc_probe in
drivers/rtc/rtc-sa1100.c does it; after the IRQs are set up a managed
rtc_device is allocated.
I've tested this patch with `qemu-system-arm -machine akita` and with a
real Zaurus SL-C1000 applied to 4.19, 5.4, and 5.10.
Signed-off-by: Laurence de Bruxelles <lfdebrux@gmail.com >
Fixes: f2997775b1 ("rtc: sa1100: fix possible race condition")
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
Link: https://lore.kernel.org/r/20220101154149.12026-1-lfdebrux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-01-27 11:05:34 +01:00
..
2021-02-06 00:58:24 +01:00
2019-10-23 17:23:43 +02:00
2021-04-29 23:04:13 +02:00
2021-09-09 10:18:40 +02:00
2021-08-10 23:21:46 +02:00
2021-08-10 00:09:21 +02:00
2021-08-10 23:22:20 +02:00
2020-11-19 12:50:12 +01:00
2021-05-25 00:36:11 +02:00
2020-11-19 12:50:12 +01:00
2020-11-19 12:50:12 +01:00
2020-11-19 12:50:12 +01:00
2020-11-19 12:50:12 +01:00
2021-04-17 00:07:16 +02:00
2021-02-13 23:03:26 +01:00
2021-01-25 23:45:37 +01:00
2021-01-16 23:19:26 +01:00
2019-05-30 11:26:37 -07:00
2021-01-25 23:46:16 +01:00
2020-11-19 12:50:12 +01:00
2020-11-19 12:50:12 +01:00
2021-07-10 02:42:08 +02:00
2021-07-10 01:53:39 +02:00
2021-06-20 22:24:52 +02:00
2021-02-06 00:58:24 +01:00
2019-05-21 10:50:45 +02:00
2021-02-06 00:58:24 +01:00
2020-11-19 12:50:12 +01:00
2022-01-27 11:02:52 +01:00
2018-09-28 14:20:59 +02:00
2020-11-19 12:50:12 +01:00
2020-11-19 12:50:12 +01:00
2020-11-19 12:50:12 +01:00
2019-05-30 11:26:32 -07:00
2020-11-19 12:50:12 +01:00
2020-11-19 12:50:12 +01:00
2021-02-06 00:58:24 +01:00
2020-11-19 12:50:12 +01:00
2019-10-07 01:07:35 +02:00
2019-10-07 01:07:35 +02:00
2021-11-18 19:16:58 +01:00
2021-01-25 23:46:16 +01:00
2021-04-29 23:37:18 +02:00
2020-11-19 12:50:12 +01:00
2020-11-19 12:50:12 +01:00
2021-07-10 01:53:39 +02:00
2021-11-18 19:16:59 +01:00
2021-04-17 11:21:04 +02:00
2020-11-19 12:50:12 +01:00
2021-02-06 00:58:24 +01:00
2021-01-25 23:46:17 +01:00
2020-11-19 12:50:12 +01:00
2020-11-19 12:50:12 +01:00
2021-02-06 00:58:24 +01:00
2021-05-25 00:39:58 +02:00
2019-11-08 16:14:09 +01:00
2020-12-03 23:49:31 +01:00
2019-07-17 10:03:50 -07:00
2021-04-17 11:21:04 +02:00
2020-11-19 12:50:12 +01:00
2019-05-21 10:50:45 +02:00
2020-11-19 12:50:12 +01:00
2021-06-16 14:53:13 +01:00
2021-01-25 23:46:17 +01:00
2021-04-29 23:03:26 +02:00
2021-05-25 00:41:25 +02:00
2021-02-06 00:58:24 +01:00
2019-06-19 17:09:55 +02:00
2020-11-19 12:50:12 +01:00
2020-11-19 12:50:12 +01:00
2019-06-19 17:09:55 +02:00
2020-04-15 09:56:17 +02:00
2020-11-19 12:50:12 +01:00
2020-11-19 12:50:12 +01:00
2021-06-20 22:19:46 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2020-03-16 11:12:11 +01:00
2021-03-11 09:48:09 +01:00
2020-11-19 12:50:12 +01:00
2021-07-10 01:53:39 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2018-11-22 18:11:35 +01:00
2018-08-14 23:38:45 +02:00
2021-06-20 22:22:13 +02:00
2020-11-19 12:50:12 +01:00
2021-02-02 20:35:02 +01:00
2021-11-18 19:16:59 +01:00
2020-11-19 12:50:12 +01:00
2021-02-06 00:58:24 +01:00
2019-12-23 11:23:49 +01:00
2020-11-19 12:50:12 +01:00
2019-11-18 15:23:54 +01:00
2020-11-19 12:50:12 +01:00
2021-06-01 16:44:09 +01:00
2019-10-07 01:07:35 +02:00
2021-01-16 23:19:26 +01:00
2021-05-25 00:33:17 +02:00
2021-03-16 08:48:44 +01:00
2021-03-10 11:06:33 +00:00
2021-04-29 23:37:18 +02:00
2021-01-16 23:19:26 +01:00
2021-07-10 01:53:39 +02:00
2020-11-19 12:50:12 +01:00
2021-11-18 19:16:59 +01:00
2021-07-10 02:58:31 +02:00
2021-07-10 23:18:30 +02:00
2021-06-20 23:48:35 +02:00
2019-06-19 17:09:55 +02:00
2019-05-30 11:26:32 -07:00
2021-07-10 01:40:49 +02:00
2021-02-06 00:58:25 +01:00
2020-11-19 12:50:12 +01:00
2021-02-02 14:25:50 +01:00
2021-02-22 14:27:07 -08:00
2021-04-17 00:20:01 +02:00
2020-11-19 12:50:12 +01:00
2022-01-27 11:05:34 +01:00
2021-02-06 00:50:47 +01:00
2020-11-19 12:50:12 +01:00
2019-05-30 11:29:52 -07:00
2020-11-19 12:50:12 +01:00
2020-11-19 12:50:12 +01:00
2020-11-19 12:50:12 +01:00
2020-08-21 00:13:44 +02:00
2020-11-19 12:50:12 +01:00
2021-02-06 00:58:25 +01:00
2021-07-10 01:53:39 +02:00
2021-03-15 23:03:27 +01:00
2021-02-06 00:58:25 +01:00
2021-11-18 19:17:01 +01:00
2021-02-06 00:58:25 +01:00
2019-06-19 17:09:55 +02:00
2021-03-23 22:23:22 +01:00
2021-02-06 00:58:25 +01:00
2021-08-17 23:48:33 +02:00
2021-02-06 00:58:25 +01:00
2021-02-06 00:59:16 +01:00
2019-06-19 17:09:55 +02:00
2021-08-06 10:31:59 +02:00
2021-02-06 00:58:25 +01:00
2020-11-19 12:50:12 +01:00
2021-07-10 01:53:39 +02:00
2021-02-06 00:58:26 +01:00
2020-11-19 12:50:12 +01:00
2020-11-19 12:50:12 +01:00
2021-07-10 01:53:57 +02:00
2020-11-19 12:50:12 +01:00
2020-11-19 12:50:12 +01:00
2020-11-19 12:50:12 +01:00
2021-06-20 22:28:02 +02:00
2020-11-19 12:50:12 +01:00
2020-11-19 12:50:12 +01:00
2020-11-19 12:50:12 +01:00
2020-11-19 12:50:12 +01:00
2021-02-06 00:50:47 +01:00
2020-12-03 23:43:23 +01:00
2021-07-10 01:53:40 +02:00
2021-08-17 23:36:22 +02:00
2021-07-10 01:53:39 +02:00
2019-05-30 11:26:32 -07:00
2021-06-20 22:29:50 +02:00
2020-11-19 12:50:12 +01:00
2020-11-19 12:50:12 +01:00
2020-11-19 12:50:12 +01:00
2020-11-19 12:50:12 +01:00
2019-05-30 11:26:32 -07:00
2019-06-19 17:09:55 +02:00
2020-11-19 12:50:12 +01:00
2020-11-19 12:50:12 +01:00
2021-06-20 22:18:05 +02:00