Bjorn Helgaas 40092a8ac0 PCI: Avoid broken MSI on SB600 USB devices ...

[ Upstream commit 63cd736f449445edcd7f0bcc7d84453e9beec0aa ]

Some ATI SB600 USB adapters advertise MSI, but if INTx is disabled by
setting PCI_COMMAND_INTX_DISABLE, MSI doesn't work either.  The PCI/PCIe
specs do not require software to set PCI_COMMAND_INTX_DISABLE when enabling
MSI, but Linux has done that for many years.

Mick reported that 306c54d0ed ("usb: hcd: Try MSI interrupts on PCI
devices") broke these devices.  Prior to 306c54d0ed, they used INTx.
Starting with 306c54d0ed, they use MSI, and and the fact that Linux sets
PCI_COMMAND_INTX_DISABLE means both INTx and MSI are disabled on these
devices.

Avoid this SB600 defect by disabling MSI so we use INTx as before.

Fixes: 306c54d0ed ("usb: hcd: Try MSI interrupts on PCI devices")
Link: https://lore.kernel.org/r/20220321183446.1108325-1-helgaas@kernel.org
Link: https://bugzilla.kernel.org/show_bug.cgi?id=215690
Link: https://lore.kernel.org/all/PxIByDyBRcsbpcmVhGSNDFAoUcMmb78ctXCkw6fbpx25TGlCHvA6SJjjFkNr1FfQZMntYPTNyvEnblxzAZ8a6jP9ddLpKeCN6Chi_2FuexU=@protonmail.com/
Link: https://lore.kernel.org/r/20220314101448.90074-1-andriy.shevchenko@linux.intel.com
BugLink: https://lore.kernel.org/all/20200702143045.23429-1-andriy.shevchenko@linux.intel.com/
Reported-by: Mick Lorain <micklorain@protonmail.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2022-04-08 14:23:42 +02:00

..

controller

PCI: aardvark: Fix reading PCI_EXP_RTSTA_PME bit on emulated bridge

2022-04-08 14:23:30 +02:00

endpoint

Merge tag 'pci-v5.15-changes' of git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci

2021-09-07 19:13:42 -07:00

hotplug

PCI: pciehp: Clear cmd_busy bit in polling mode

2022-04-08 14:23:04 +02:00

pcie

Merge tag 'pci-v5.15-changes' of git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci

2021-09-07 19:13:42 -07:00

switch

PCI/sysfs: Use sysfs_emit() and sysfs_emit_at() in "show" functions

2021-06-03 22:14:47 -05:00

access.c

PCI: Reduce warnings on possible RW1C corruption

2022-04-08 14:23:37 +02:00

ats.c

PCI: Allow PASID on fake PCIe devices without TLP prefixes

2021-08-26 14:21:42 -05:00

bus.c

…

ecam.c

PCI: Dynamically map ECAM regions

2021-06-16 17:20:40 -05:00

host-bridge.c

PCI: VMD: ACPI: Make ACPI companion lookup work for VMD bus

2021-09-02 17:59:58 +02:00

iov.c

Merge branch 'pci/virtualization'

2021-07-06 10:56:26 -05:00

irq.c

…

Kconfig

PCI: only build xen-pcifront in PV-enabled environments

2021-09-20 17:01:11 +02:00

Makefile

PCI: Apply CONFIG_PCI_DEBUG to entire drivers/pci hierarchy

2021-02-09 15:10:20 -06:00

mmap.c

…

msi.c

PCI/MSI: Fix pci_irq_vector()/pci_irq_get_affinity()

2022-01-27 11:04:11 +01:00

of.c

PCI: of: Don't fail devm_pci_alloc_host_bridge() on missing 'ranges'

2021-08-04 12:20:00 +01:00

p2pdma.c

Merge branch 'pci/sysfs'

2021-07-06 10:56:25 -05:00

pci-acpi.c

PCI: ACPI: Check parent pointer in acpi_pci_find_companion()

2021-10-07 18:42:44 +02:00

pci-bridge-emul.c

PCI: pci-bridge-emul: Set PCI_STATUS_CAP_LIST for PCIe device

2022-01-27 11:05:14 +01:00

pci-bridge-emul.h

PCI: pci-bridge-emul: Add PCIe Root Capabilities Register

2021-08-05 10:51:49 +01:00

pci-driver.c

Merge tag 'vfio-v5.15-rc1' of git://github.com/awilliam/linux-vfio

2021-09-02 13:41:33 -07:00

pci-label.c

PCI/sysfs: Use sysfs_emit() and sysfs_emit_at() in "show" functions

2021-06-03 22:14:47 -05:00

pci-mid.c

…

pci-pf-stub.c

…

pci-stub.c

…

pci-sysfs.c

Merge tag 'pci-v5.15-changes' of git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci

2021-09-07 19:13:42 -07:00

pci.c

PCI: Do not enable AtomicOps on VFs

2021-11-18 19:17:08 +01:00

pci.h

Merge tag 'pci-v5.15-changes' of git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci

2021-09-07 19:13:42 -07:00

probe.c

Merge branch 'remotes/lorenzo/pci/hyper-v'

2021-09-02 14:56:47 -05:00

proc.c

Merge tag 'pci-v5.15-changes' of git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci

2021-09-07 19:13:42 -07:00

quirks.c

PCI: Avoid broken MSI on SB600 USB devices

2022-04-08 14:23:42 +02:00

remove.c

PCI: Remove reset_fn field from pci_dev

2021-08-17 17:44:38 -05:00

rom.c

…

search.c

PCI: Remove WARN_ON(in_interrupt())

2021-02-10 16:46:29 -06:00

setup-bus.c

…

setup-irq.c

…

setup-res.c

PCI: Decline to resize resources if boot config must be preserved

2021-01-12 16:39:52 -06:00

slot.c

PCI/sysfs: Use sysfs_emit() and sysfs_emit_at() in "show" functions

2021-06-03 22:14:47 -05:00

syscall.c

PCI: Return int from pciconfig_read() syscall

2021-08-03 16:55:48 -05:00

vc.c

…

vpd.c

PCI/VPD: Defer VPD sizing until first access

2021-09-15 16:26:13 -05:00

xen-pcifront.c

Merge branch 'stable/for-linus-5.15' of git://git.kernel.org/pub/scm/linux/kernel/git/konrad/swiotlb

2021-09-03 10:34:44 -07:00