Files
msm-5.15/include/linux
Gustavo A. R. Silva e7bb7ecefa IB/mlx4: Replace zero-length array with flexible-array
The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:

struct foo {
        int stuff;
        struct boo array[];
};

By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertently introduced[3] to the codebase from now on.

Also, notice that, dynamic memory allocations won't be affected by
this change:

"Flexible array members have incomplete type, and so the sizeof operator
may not be applied. As a quirk of the original implementation of
zero-length arrays, sizeof evaluates to zero."[1]

sizeof(flexible-array-member) triggers a warning because flexible array
members have incomplete type[1]. There are some instances of code in
which the sizeof operator is being incorrectly/erroneously applied to
zero-length arrays and the result is zero. Such instances may be hiding
some bugs. So, this work (flexible-array member conversions) will also
help to get completely rid of those sorts of issues.

This issue was found with the help of Coccinelle.

[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 7649773293 ("cxgb3/l2t: Fix undefined behaviour")

Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2020-05-09 20:49:13 -07:00
..
2019-08-09 09:15:05 +02:00
2020-03-31 21:29:04 +02:00
2019-09-16 09:56:27 -07:00
2019-12-11 09:12:38 +01:00
2019-11-12 11:43:29 -05:00
2018-05-26 09:16:44 +02:00
2018-06-15 18:10:01 -03:00
2020-04-10 15:36:21 -07:00
2019-06-12 20:27:13 +02:00
2020-01-23 00:35:50 +01:00
2018-08-22 10:52:48 -07:00
2019-10-09 19:33:43 -07:00
2020-03-09 11:12:19 +01:00
2019-12-03 11:20:37 +01:00
2020-02-17 13:37:00 +01:00
2019-09-05 19:52:33 -06:00
2019-02-28 03:28:53 -05:00
2018-01-01 12:40:27 -07:00
2020-05-04 11:19:58 -07:00
2020-01-18 09:19:18 -05:00
2018-12-19 10:42:08 +01:00
2017-11-13 01:41:20 +01:00
2020-03-06 11:06:15 +01:00
2019-02-15 16:54:38 +01:00
2010-02-09 11:13:56 +01:00
2020-03-27 20:19:24 -03:00
2020-04-15 11:48:21 +02:00
2019-06-26 13:19:46 -07:00
2020-04-30 12:54:01 -07:00
2019-10-04 12:31:46 -07:00
2018-06-22 13:43:27 +09:00
2020-03-21 16:00:24 +01:00
2019-06-10 13:00:24 +02:00
2019-12-04 19:44:14 -08:00
2020-01-31 17:33:54 +00:00
2020-02-20 21:17:24 +01:00
2019-12-11 09:12:38 +01:00
2019-09-02 11:43:54 +01:00
2018-04-12 09:41:19 -07:00
2019-03-07 18:32:03 -08:00
2020-04-10 15:36:21 -07:00
2018-06-07 17:34:35 -07:00
2020-03-06 11:56:59 +01:00
2020-04-07 10:43:38 -07:00
2019-12-09 10:55:03 +01:00
2019-08-14 15:30:35 +02:00
2018-03-26 13:14:43 -04:00
2020-03-21 16:00:24 +01:00
2019-11-14 19:06:47 -08:00
2018-10-17 13:56:58 -07:00
2020-01-15 10:54:33 -05:00
2020-01-14 12:20:48 +01:00
2019-06-13 09:02:33 -04:00
2019-02-08 15:02:49 -08:00
2019-12-11 16:37:02 +08:00
2020-04-02 09:35:27 -07:00
2020-04-07 10:43:38 -07:00
2018-10-21 10:46:39 -04:00
2019-11-13 19:09:47 +08:00
2017-11-09 10:23:28 +01:00
2020-01-15 16:30:28 +00:00
2018-10-08 22:53:10 +11:00
2019-06-15 12:25:49 +02:00
2018-07-20 01:11:45 +02:00
2020-01-13 18:16:43 -08:00
2018-09-25 20:17:35 -07:00
2019-11-14 13:07:48 +08:00
2020-03-21 16:00:24 +01:00
2020-02-21 10:31:18 +01:00
2020-04-07 10:43:42 -07:00
2018-07-07 17:25:23 +02:00
2020-03-21 16:00:24 +01:00
2020-03-02 14:04:31 -07:00
2019-11-13 12:15:34 -08:00
2019-02-07 16:38:35 +01:00
2018-01-15 12:07:46 -08:00
2020-02-04 03:05:26 +00:00
2020-03-23 13:41:55 +01:00
2018-10-11 09:16:44 -07:00
2020-05-04 09:16:37 -07:00
2020-02-21 11:22:15 -08:00
2020-01-14 12:20:48 +01:00
2005-04-16 15:20:36 -07:00
2020-03-23 17:01:47 +01:00
2020-04-17 06:05:30 -04:00
2020-04-01 12:06:26 -04:00
2020-04-17 06:05:30 -04:00
2019-11-14 12:20:02 +08:00
2019-05-15 17:35:54 +01:00
2017-08-15 09:02:08 -07:00