NeilBrown fbbaf700e7
block: trace completion of all bios. ...
Currently only dm and md/raid5 bios trigger
trace_block_bio_complete(). Now that we have bio_chain() and
bio_inc_remaining(), it is not possible, in general, for a driver to
know when the bio is really complete. Only bio_endio() knows that.
So move the trace_block_bio_complete() call to bio_endio().
Now trace_block_bio_complete() pairs with trace_block_bio_queue().
Any bio for which a 'queue' event is traced, will subsequently
generate a 'complete' event.
There are a few cases where completion tracing is not wanted.
1/ If blk_update_request() has already generated a completion
trace event at the 'request' level, there is no point generating
one at the bio level too. In this case the bi_sector and bi_size
will have changed, so the bio level event would be wrong
2/ If the bio hasn't actually been queued yet, but is being aborted
early, then a trace event could be confusing. Some filesystems
call bio_endio() but do not want tracing.
3/ The bio_integrity code interposes itself by replacing bi_end_io,
then restoring it and calling bio_endio() again. This would produce
two identical trace events if left like that.
To handle these, we introduce a flag BIO_TRACE_COMPLETION and only
produce the trace event when this is set.
We address point 1 above by clearing the flag in blk_update_request().
We address point 2 above by only setting the flag when
generic_make_request() is called.
We address point 3 above by clearing the flag after generating a
completion event.
When bio_split() is used on a bio, particularly in blk_queue_split(),
there is an extra complication. A new bio is split off the front, and
may be handle directly without going through generic_make_request().
The old bio, which has been advanced, is passed to
generic_make_request(), so it will trigger a trace event a second
time.
Probably the best result when a split happens is to see a single
'queue' event for the whole bio, then multiple 'complete' events - one
for each component. To achieve this was can:
- copy the BIO_TRACE_COMPLETION flag to the new bio in bio_split()
- avoid generating a 'queue' event if BIO_TRACE_COMPLETION is already set.
This way, the split-off bio won't create a queue event, the original
won't either even if it re-submitted to generic_make_request(),
but both will produce completion events, each for their own range.
So if generic_make_request() is called (which generates a QUEUED
event), then bi_endio() will create a single COMPLETE event for each
range that the bio is split into, unless the driver has explicitly
requested it not to.
Signed-off-by: NeilBrown <neilb@suse.com >
Signed-off-by: Jens Axboe <axboe@fb.com >
2017-04-07 09:40:52 -06:00
2016-12-14 20:42:45 -08:00
2017-02-08 11:19:43 -08:00
2017-02-06 15:13:24 +01:00
2017-03-07 14:30:38 +01:00
2016-11-02 20:44:20 +01:00
2017-02-20 12:16:11 +01:00
2017-01-25 11:51:39 +05:30
2017-01-09 10:04:09 +09:00
2017-02-10 15:20:44 +01:00
2016-11-29 09:17:20 +01:00
2017-02-23 08:46:04 -08:00
2017-01-24 12:37:43 -08:00
2017-01-28 18:21:49 +00:00
2017-01-31 11:31:49 -08:00
2017-03-06 10:30:57 +00:00
2017-02-13 17:02:50 -05:00
2017-02-27 19:59:21 -08:00
2017-03-01 09:50:58 -08:00
2017-02-23 11:27:49 -08:00
2017-02-22 10:15:09 -08:00
2017-02-27 18:43:46 -08:00
2017-02-12 14:45:11 +01:00
2016-10-03 19:43:08 -07:00
2016-12-14 10:49:33 -08:00
2017-01-26 15:27:54 +01:00
2017-02-27 19:59:21 -08:00
2017-01-12 02:30:13 +01:00
2017-02-19 18:10:42 -05:00
2016-10-07 09:45:43 -07:00
2017-03-09 17:01:09 -08:00
2016-10-18 20:12:05 +05:30
2017-02-06 13:49:29 -08:00
2017-03-03 01:45:41 +01:00
2017-02-23 15:57:04 -08:00
2017-02-27 18:43:46 -08:00
2017-03-02 08:42:32 +01:00
2016-09-14 20:37:50 +02:00
2017-01-20 15:27:35 +08:00
2016-12-06 16:57:33 +01:00
2017-03-11 14:41:20 +01:00
2016-09-20 14:35:59 -05:00
2016-12-05 14:31:24 -05:00
2016-12-22 22:58:37 -05:00
2016-12-01 14:45:08 +01:00
2017-02-08 14:54:12 +00:00
2017-02-16 10:08:41 +05:30
2016-10-19 14:34:36 -04:00
2016-09-27 12:54:03 +02:00
2016-12-15 12:13:31 +00:00
2017-02-21 13:25:50 -08:00
2016-10-11 15:06:31 -07:00
2016-10-11 15:06:31 -07:00
2017-03-02 08:32:46 +01:00
2017-03-22 20:11:30 -06:00
2017-02-02 08:21:32 -07:00
2017-03-03 01:45:23 +01:00
2017-03-23 08:16:11 -06:00
2017-02-10 15:52:24 -05:00
2016-10-07 18:46:26 -07:00
2017-04-07 09:40:52 -06:00
2017-03-29 11:25:48 -06:00
2016-09-15 08:42:03 -06:00
2017-02-27 20:54:05 +02:00
2017-04-05 09:40:15 -06:00
2017-04-05 12:16:38 -06:00
2017-02-02 10:20:16 -07:00
2016-09-15 18:29:06 -04:00
2016-10-07 18:46:28 -07:00
2017-01-25 13:17:47 -05:00
2016-12-08 13:31:11 -05:00
2017-02-12 21:52:19 -05:00
2017-02-17 13:40:05 -05:00
2017-02-07 13:03:10 -05:00
2017-01-27 15:08:35 -07:00
2017-02-08 15:41:43 -08:00
2017-02-24 17:46:56 -08:00
2016-12-22 09:25:45 -08:00
2016-11-22 13:21:00 -06:00
2016-10-25 11:08:28 +08:00
2017-02-14 08:29:56 -07:00
2017-01-10 11:14:27 -05:00
2017-01-10 11:14:27 -05:00
2017-03-02 08:42:25 +01:00
2016-12-27 14:52:47 -05:00
2016-10-17 15:27:27 -07:00
2016-12-08 16:37:33 -08:00
2017-02-07 20:58:30 +01:00
2017-01-14 11:29:43 +01:00
2017-02-24 17:46:55 -08:00
2016-10-07 18:46:29 -07:00
2017-02-27 18:43:45 -08:00
2017-03-01 20:32:25 +01:00
2017-02-27 23:09:29 -08:00
2016-12-21 10:16:05 -08:00
2017-01-25 11:54:02 +01:00
2017-01-14 19:32:40 -05:00
2017-03-02 08:42:40 +01:00
2017-02-04 00:47:59 +01:00
2017-03-02 13:53:13 -08:00
2017-01-31 08:32:13 +11:00
2017-02-20 10:06:32 -08:00
2017-03-02 08:42:38 +01:00
2017-03-02 08:42:31 +01:00
2016-12-17 16:00:34 -08:00
2017-02-02 11:52:14 -05:00
2016-10-11 15:06:30 -07:00
2017-02-24 17:46:54 -08:00
2017-03-02 08:42:24 +01:00
2017-03-07 14:15:27 -08:00
2016-12-05 19:01:16 -05:00
2017-02-23 20:33:51 -08:00
2017-01-20 14:32:39 -08:00
2017-03-03 01:45:28 +01:00
2016-11-23 10:07:35 +08:00
2017-01-31 15:46:49 +09:00
2017-01-27 15:08:35 -07:00
2017-03-16 16:56:19 -07:00
2016-10-28 08:48:16 -06:00
2016-12-30 13:34:16 +01:00
2017-02-24 17:46:55 -08:00
2016-09-26 22:16:41 +05:30
2016-10-25 14:40:39 +02:00
2017-01-09 21:13:49 +05:30
2017-02-06 13:14:10 +01:00
2017-02-25 13:45:43 -08:00
2017-01-31 09:03:20 +05:30
2017-03-02 08:42:38 +01:00
2016-10-27 16:16:09 -04:00
2016-12-25 11:04:12 +01:00
2017-01-06 15:56:18 +01:00
2017-02-01 08:45:46 +01:00
2017-02-07 10:42:10 +01:00
2017-02-10 09:09:59 -07:00
2017-03-02 08:42:36 +01:00
2017-01-29 19:24:12 -05:00
2017-02-03 08:28:25 -08:00
2016-10-06 09:07:44 -04:00
2017-01-09 10:04:58 +09:00
2017-02-27 10:07:47 -08:00
2016-10-03 09:11:14 -07:00
2017-03-03 01:45:28 +01:00
2016-10-20 14:51:10 -04:00
2016-10-15 10:03:15 -07:00
2016-12-05 19:01:16 -05:00
2017-03-12 23:51:34 -07:00
2017-03-01 20:32:25 +01:00
2016-11-11 08:12:37 -08:00
2017-03-09 17:01:09 -08:00
2017-01-31 13:23:09 -05:00
2017-02-06 23:26:43 -05:00
2017-02-06 23:26:43 -05:00
2017-02-06 23:26:43 -05:00
2017-02-10 15:19:48 +01:00
2016-12-05 15:13:58 +01:00
2017-02-06 08:54:01 +01:00
2017-02-20 13:51:07 +01:00
2017-02-23 20:33:51 -08:00
2016-12-05 18:58:32 -05:00
2016-12-15 13:49:34 -08:00
2016-12-25 17:21:22 +01:00
2016-11-29 15:57:42 +00:00
2017-03-24 20:34:39 -06:00
2016-10-27 16:16:09 -04:00
2017-02-24 17:46:55 -08:00
2016-11-07 16:24:29 -08:00
2016-10-20 14:51:09 -04:00
2016-10-17 14:23:46 +02:00
2016-12-03 10:06:13 +00:00
2017-01-05 13:07:24 +00:00
2016-12-14 10:12:26 +01:00
2016-10-20 14:51:10 -04:00
2017-03-03 01:45:40 +01:00
2017-02-24 17:46:54 -08:00
2017-03-09 11:48:47 -08:00
2016-11-21 22:50:45 +08:00
2016-12-09 21:54:22 -08:00
2017-02-14 10:20:35 -08:00
2016-11-24 16:22:06 +01:00
2017-03-02 08:42:32 +01:00
2017-01-31 14:00:44 -07:00
2017-02-13 21:44:03 -05:00
2017-02-08 10:06:24 +01:00
2016-11-27 20:38:47 -05:00
2017-02-03 15:21:21 -05:00
2017-01-27 11:32:26 -05:00
2016-09-24 08:01:26 -04:00
2017-02-11 20:59:41 -05:00
2017-02-11 20:59:41 -05:00
2016-10-07 23:50:39 -04:00
2016-11-15 12:16:13 -05:00
2016-12-20 09:48:44 -08:00
2017-04-04 09:48:23 -06:00
2017-03-03 01:43:47 +01:00
2017-02-07 12:32:52 -08:00
2017-02-10 15:13:10 +01:00
2016-11-09 08:25:09 +01:00
2016-10-26 15:45:38 +10:00
2017-02-24 17:46:54 -08:00
2017-02-10 15:13:10 +01:00
2017-02-24 17:46:56 -08:00
2016-09-14 09:18:09 -06:00
2017-01-05 15:01:55 -06:00
2017-01-27 10:25:34 -05:00
2017-02-20 10:52:23 -08:00
2016-09-14 15:28:15 +02:00
2017-03-06 14:40:04 +00:00
2016-12-24 11:46:01 -08:00
2017-02-01 09:13:45 +01:00
2017-01-12 14:33:16 +01:00
2017-03-07 09:37:28 -08:00
2017-03-16 16:56:18 -07:00
2017-02-27 18:43:47 -08:00
2016-12-14 16:04:08 -08:00
2016-10-09 12:23:38 -07:00
2017-02-01 09:13:58 +01:00
2017-02-24 17:46:57 -08:00
2016-12-27 14:49:03 -05:00
2016-12-16 09:26:42 -08:00
2017-03-02 10:09:00 +11:00
2017-03-02 08:42:28 +01:00
2016-10-11 15:06:33 -07:00
2017-01-19 12:45:33 +01:00
2017-03-22 20:11:35 -06:00
2017-02-27 18:43:45 -08:00
2017-02-10 09:04:19 +01:00
2017-03-02 08:42:28 +01:00
2016-12-12 18:55:06 -08:00
2016-12-25 17:21:23 +01:00
2017-03-01 17:03:21 +01:00
2017-01-29 19:59:42 +01:00
2017-02-21 17:21:32 -08:00
2017-03-01 00:49:42 -08:00
2017-01-31 08:32:13 -07:00
2017-03-09 13:27:17 -08:00
2017-02-03 16:35:42 -05:00
2017-01-23 11:37:13 -08:00
2016-11-30 14:32:25 +11:00
2017-03-02 12:17:22 -08:00
2016-09-19 13:42:38 -04:00
2017-02-10 10:28:49 +11:00
2017-02-24 17:46:57 -08:00
2017-02-02 22:05:28 -05:00
2017-01-14 11:31:50 +01:00
2016-11-18 13:54:21 -05:00
2016-11-29 18:02:58 +01:00
2016-09-27 12:33:47 +02:00
2017-01-04 13:22:38 -07:00
2017-02-07 10:51:46 -05:00
2016-12-06 11:05:46 +01:00
2017-02-24 17:46:54 -08:00
2017-02-22 16:41:27 -08:00
2017-02-03 14:13:19 -08:00
2017-02-24 17:46:56 -08:00
2016-12-12 18:55:07 -08:00
2017-01-24 12:23:35 -05:00
2017-01-27 11:10:50 -05:00
2017-02-24 17:46:55 -08:00
2016-11-02 15:17:09 -04:00
2017-02-23 09:54:19 -08:00
2017-02-24 17:46:54 -08:00
2017-03-03 01:45:25 +01:00
2017-03-03 01:43:48 +01:00
2017-03-09 11:48:47 -08:00
2017-02-24 17:46:54 -08:00
2017-02-24 17:46:54 -08:00
2017-02-07 10:51:46 -05:00
2017-02-22 17:08:33 -08:00
2017-02-02 04:36:12 +13:00
2017-01-18 15:43:59 -05:00
2017-01-12 16:48:26 -05:00
2017-02-23 11:53:22 -08:00
2017-02-20 13:23:30 -08:00
2016-10-07 09:20:53 -07:00
2017-03-09 18:23:27 -08:00
2017-02-03 17:28:29 -05:00
2017-03-01 09:50:58 -08:00
2016-12-06 21:48:21 +01:00
2016-12-06 21:42:16 +01:00
2016-11-16 18:32:02 -05:00
2017-01-24 12:50:47 -05:00
2016-09-22 15:54:27 -04:00
2017-03-02 20:51:15 -05:00
2016-12-09 23:47:10 -05:00
2017-03-03 01:43:38 +01:00
2016-12-24 11:23:24 -08:00
2017-04-04 09:48:23 -06:00
2017-04-04 09:48:23 -06:00
2017-02-22 13:34:00 -07:00
2017-02-22 13:34:00 -07:00
2017-02-22 19:23:14 -08:00
2016-12-12 18:55:07 -08:00
2016-10-03 23:38:11 +02:00
2017-02-15 08:53:32 -06:00
2017-02-10 14:54:37 +01:00
2016-11-29 23:17:02 -05:00
2016-11-14 15:21:14 -06:00
2017-01-17 12:09:33 +00:00
2016-09-28 08:53:14 +05:30
2017-03-02 08:42:29 +01:00
2016-09-19 21:44:30 +02:00
2016-10-07 18:46:27 -07:00
2016-10-07 18:46:27 -07:00
2016-12-29 11:03:15 -08:00
2017-02-22 16:41:30 -08:00
2017-02-03 16:35:42 -05:00
2016-12-06 10:17:03 +02:00
2016-11-17 18:47:58 -06:00
2017-02-09 09:13:20 -06:00
2016-12-06 13:45:48 -06:00
2016-12-06 13:45:50 -06:00
2017-03-02 08:56:04 -07:00
2017-01-28 07:49:42 -05:00
2017-01-14 11:14:35 +01:00
2017-02-10 09:08:09 +01:00
2017-03-02 08:42:36 +01:00
2017-02-24 17:46:54 -08:00
2017-01-25 14:40:19 -05:00
2017-03-05 17:57:27 -08:00
2017-02-24 17:46:56 -08:00
2017-03-02 08:42:38 +01:00
2016-10-31 16:18:30 -04:00
2016-10-05 18:24:00 -04:00
2016-10-14 11:36:59 -07:00
2017-02-09 14:29:27 +01:00
2017-02-09 22:52:17 +01:00
2017-03-03 00:43:11 +01:00
2016-12-13 11:42:18 -08:00
2016-11-29 18:02:58 +01:00
2017-02-06 11:25:55 -07:00
2017-01-14 11:14:53 +01:00
2016-12-24 11:46:01 -08:00
2016-09-27 21:52:00 -04:00
2016-10-08 11:06:08 -04:00
2017-02-01 09:13:55 +01:00
2017-03-03 01:43:47 +01:00
2016-12-27 12:30:56 +01:00
2017-02-08 11:07:11 +01:00
2016-12-13 16:07:55 -08:00
2016-09-22 19:59:41 -05:00
2017-02-07 13:21:15 +01:00
2016-11-15 16:34:26 -08:00
2016-11-15 16:34:27 -08:00
2016-12-12 19:56:15 -08:00
2017-02-20 10:27:56 -05:00
2017-03-02 08:42:29 +01:00
2017-03-10 20:55:09 +01:00
2017-01-30 09:36:42 +01:00
2017-01-04 18:36:41 +00:00
2017-01-16 23:45:04 -06:00
2016-12-19 08:23:53 -08:00
2016-12-05 19:03:06 -05:00
2017-02-13 21:44:09 -05:00
2017-01-27 14:25:06 -05:00
2016-12-20 09:48:47 -08:00
2017-02-24 17:46:57 -08:00
2017-03-09 13:27:17 -08:00
2016-10-31 13:01:57 -07:00
2017-03-02 08:42:24 +01:00
2017-03-02 08:42:24 +01:00
2017-03-02 08:42:24 +01:00
2017-02-01 09:17:51 +01:00
2017-02-24 09:02:10 +01:00
2017-02-03 12:34:59 +01:00
2016-10-11 15:06:32 -07:00
2017-01-30 14:18:54 -08:00
2016-12-12 07:54:43 +01:00
2017-01-20 10:36:15 +01:00
2016-11-11 18:24:16 +00:00
2017-03-02 08:42:38 +01:00
2016-12-02 00:52:34 +01:00
2017-02-24 17:46:55 -08:00
2016-12-12 11:26:47 -08:00
2017-02-27 18:43:48 -08:00
2017-01-18 10:43:15 -08:00
2017-01-27 08:17:44 -07:00
2017-03-03 01:45:41 +01:00
2017-02-19 18:17:59 -05:00
2017-02-23 20:33:51 -08:00
2017-02-23 11:55:41 -07:00
2016-11-09 20:40:06 -05:00
2016-11-09 20:40:06 -05:00
2016-11-09 20:40:06 -05:00
2016-11-09 20:40:06 -05:00
2017-02-27 18:43:46 -08:00
2016-10-07 18:46:30 -07:00
2016-10-25 14:40:39 +02:00
2017-02-03 10:17:02 +01:00
2016-11-16 10:59:38 +01:00
2017-01-12 11:51:24 +01:00
2017-01-19 14:17:05 +01:00
2017-02-24 17:46:56 -08:00
2017-03-03 01:43:48 +01:00
2017-03-03 01:43:48 +01:00
2017-03-02 08:42:29 +01:00
2017-01-09 13:58:57 -05:00
2017-03-02 08:42:27 +01:00
2017-02-22 16:41:27 -08:00
2017-02-22 16:41:27 -08:00
2016-10-18 14:14:20 -04:00
2017-01-09 16:07:38 -05:00
2017-01-12 09:33:39 +01:00
2017-01-12 09:33:39 +01:00
2017-01-12 09:33:39 +01:00
2016-10-05 18:23:36 -04:00
2017-01-25 11:48:03 +01:00
2017-01-25 12:53:20 -08:00
2017-03-02 20:51:15 -05:00
2016-11-22 17:48:04 -05:00
2017-02-08 15:11:22 -05:00
2017-01-20 03:33:57 +01:00
2017-02-22 16:41:30 -08:00
2017-02-22 16:41:30 -08:00
2017-01-06 13:00:01 -05:00
2016-10-25 14:40:39 +02:00
2016-11-10 10:10:37 +01:00
2017-03-02 20:51:15 -05:00
2017-02-13 17:00:06 +13:00
2017-03-24 20:34:39 -06:00
2017-03-02 08:42:29 +01:00
2017-02-03 11:19:34 -05:00
2017-01-04 12:47:28 +08:00
2016-11-11 18:25:08 +00:00
2016-12-25 17:21:22 +01:00
2017-03-03 01:45:25 +01:00
2016-12-25 11:04:12 +01:00
2016-12-25 11:04:12 +01:00
2017-03-03 01:45:25 +01:00
2017-03-03 01:45:39 +01:00
2017-01-10 18:31:55 -08:00
2017-02-22 16:41:26 -08:00
2016-11-22 17:40:00 -05:00
2016-12-09 09:13:30 -05:00
2016-12-09 09:13:30 -05:00
2017-02-03 10:17:02 +01:00
2016-12-25 11:04:12 +01:00
2016-09-30 11:46:40 +02:00
2016-12-09 22:12:21 -05:00
2016-12-16 10:24:44 -08:00
2016-12-11 18:01:51 -08:00
2016-09-13 08:08:24 +02:00
2016-10-24 14:36:25 +02:00
2017-03-06 15:26:37 -06:00
2017-03-09 17:01:10 -08:00
2017-02-10 16:34:17 +00:00
2016-12-01 10:40:05 -07:00
2017-02-27 20:54:05 +02:00
2017-01-20 11:01:17 -05:00
2017-02-07 10:05:12 -05:00
2017-03-09 17:01:10 -08:00
2017-03-02 08:42:25 +01:00
2016-12-12 18:55:08 -08:00
2017-01-11 09:21:41 +01:00
2017-02-03 11:49:06 +01:00
2016-10-27 16:37:44 +02:00
2017-01-14 09:54:13 +01:00
2017-03-08 10:36:03 -08:00
2017-02-24 14:00:23 -08:00
2016-09-21 00:22:59 -04:00
2017-02-02 15:22:18 -05:00
2017-03-22 20:11:33 -06:00
2017-01-14 12:11:59 +01:00
2016-10-07 21:48:36 -04:00
fbbaf700e7