Evolution-X-Devices/hardware_dolby
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

dolby: Use new method to listen for preference changes

Browse Source 
Usage of addOnSwitchChangeListener(OnCheckedChangeListener) is
deprecated. The Javadoc explicitly says:

  Use setOnPreferenceChangeListener(OnPreferenceChangeListener) instead.

Change-Id: I71e0e3f86ff339a312cac1e09106f6d5d15b7e43
Signed-off-by: basamaryan <basam.aryan@gmail.com>
This commit is contained in:
Bruno Martins
2025-11-25 20:56:05 +00:00
committed by Joey
parent f42bd8b0b0
commit 2ac524b54c
1 changed files with 10 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
DolbyManager/src/co/aospa/dolby/DolbySettingsFragment.kt
View File

@@ -12,7 +12,6 @@ import android.media.AudioDeviceInfo
import android.media.AudioManager
import android.os.Bundle
import android.os.Handler
import android.widget.CompoundButton
import android.widget.Toast
import androidx.preference.ListPreference
import androidx.preference.Preference
@@ -24,7 +23,7 @@ import co.aospa.dolby.R
import com.android.settingslib.widget.MainSwitchPreference
class DolbySettingsFragment : PreferenceFragmentCompat(),
OnPreferenceChangeListener, CompoundButton.OnCheckedChangeListener {
OnPreferenceChangeListener {
private val switchBar by lazy {
findPreference<MainSwitchPreference>(DolbyConstants.PREF_ENABLE)!!
@@ -92,7 +91,7 @@ class DolbySettingsFragment : PreferenceFragmentCompat(),
setPreferencesFromResource(R.xml.dolby_settings, rootKey)
val dsOn = dolbyController.dsOn
switchBar.addOnSwitchChangeListener(this)
switchBar.onPreferenceChangeListener = this
switchBar.setChecked(dsOn)
profilePref.onPreferenceChangeListener = this
@@ -143,7 +142,14 @@ class DolbySettingsFragment : PreferenceFragmentCompat(),
override fun onPreferenceChange(preference: Preference, newValue: Any): Boolean {
dlog(TAG, "onPreferenceChange: key=${preference.key} value=$newValue")
when (preference.key) {
DolbyConstants.PREF_PROFILE -> {
PREF_ENABLE -> {
val isChecked = newValue as Boolean
dlog(TAG, "PREF_ENABLE -> $isChecked")
dolbyController.dsOn = isChecked
profilePref.setEnabled(isChecked)
updateProfileSpecificPrefs()
}
PREF_PROFILE -> {
val profile = newValue.toString().toInt()
dolbyController.profile = profile
(preferenceManager.preferenceDataStore as DolbyPreferenceStore).profile = profile
@@ -179,13 +185,6 @@ class DolbySettingsFragment : PreferenceFragmentCompat(),
return true
}
override fun onCheckedChanged(buttonView: CompoundButton, isChecked: Boolean) {
dlog(TAG, "onCheckedChanged($isChecked)")
dolbyController.dsOn = isChecked
profilePref.setEnabled(isChecked)
updateProfileSpecificPrefs()
}
private fun updateSpeakerState() {
val device = audioManager!!.getDevicesForAttributes(ATTRIBUTES_MEDIA)[0]
isOnSpeaker = (device.type == AudioDeviceInfo.TYPE_BUILTIN_SPEAKER)