[ALPS05276847] Leds: fix the coverity issue
[Detail] Fix snprintf out of bounds MTK-Commit-Id: 44bd8e132a70d7126e5fde3e938bdfa72f1f13ee Change-Id: I8964d292fbbbdf8929b5b2cc755184a1aacb747c Signed-off-by: Xing Zhang <xing.zhang@mediatek.com> CR-Id: ALPS05276847 Feature: [Android Default] Backlight
This commit is contained in:
@@ -122,7 +122,8 @@ static void led_debug_log(struct mtk_led_data *s_led,
|
||||
cur_time_mod = do_div(cur_time_display, 1000);
|
||||
|
||||
ret = snprintf(s_led->debug.buffer + strlen(s_led->debug.buffer),
|
||||
4096, "T:%lld.%ld,L:%d L:%d map:%d ",
|
||||
4095 - strlen(s_led->debug.buffer),
|
||||
"T:%lld.%ld,L:%d L:%d map:%d ",
|
||||
cur_time_display, cur_time_mod,
|
||||
s_led->conf.cdev.brightness, level, mappingLevel);
|
||||
|
||||
@@ -303,7 +304,8 @@ static int led_data_init(struct device *dev, struct mtk_led_data *s_led)
|
||||
pr_info("%s devm_led_classdev_register ok! ", s_led->conf.cdev.name);
|
||||
|
||||
ret = snprintf(s_led->debug.buffer + strlen(s_led->debug.buffer),
|
||||
4096, "[Light] Set %s directly ", s_led->conf.cdev.name);
|
||||
4095 - strlen(s_led->debug.buffer),
|
||||
"[Light] Set %s directly ", s_led->conf.cdev.name);
|
||||
if (ret < 0 || ret >= 4096)
|
||||
pr_info("print log init error!");
|
||||
|
||||
|
||||
@@ -125,7 +125,8 @@ static void led_debug_log(struct mtk_led_data *s_led,
|
||||
cur_time_mod = do_div(cur_time_display, 1000);
|
||||
|
||||
ret = snprintf(s_led->debug.buffer + strlen(s_led->debug.buffer),
|
||||
4096, "T:%lld.%ld,L:%d L:%d map:%d ",
|
||||
4095 - strlen(s_led->debug.buffer),
|
||||
"T:%lld.%ld,L:%d L:%d map:%d ",
|
||||
cur_time_display, cur_time_mod,
|
||||
s_led->conf.cdev.brightness, level, mappingLevel);
|
||||
|
||||
@@ -353,7 +354,8 @@ static int led_data_init(struct device *dev, struct mtk_led_data *s_led)
|
||||
|
||||
INIT_WORK(&s_led->work, mtk_led_work);
|
||||
ret = snprintf(s_led->debug.buffer + strlen(s_led->debug.buffer),
|
||||
4096, "[Light] Set %s directly ", s_led->conf.cdev.name);
|
||||
4095 - strlen(s_led->debug.buffer),
|
||||
"[Light] Set %s directly ", s_led->conf.cdev.name);
|
||||
|
||||
if (ret < 0 || ret >= 4096)
|
||||
pr_info("print log init error!");
|
||||
|
||||
@@ -138,7 +138,7 @@ static void backlight_debug_log(int level, int mappingLevel)
|
||||
cur_time_mod = do_div(cur_time_display, 1000);
|
||||
|
||||
ret = snprintf(buffer + strlen(buffer),
|
||||
4096, "T:%lld.%ld,L:%d map:%d ",
|
||||
4095 - strlen(buffer), "T:%lld.%ld,L:%d map:%d ",
|
||||
cur_time_display, cur_time_mod, level, mappingLevel);
|
||||
|
||||
count++;
|
||||
|
||||
@@ -139,7 +139,7 @@ static void backlight_debug_log(int level, int mappingLevel)
|
||||
cur_time_mod = do_div(cur_time_display, 1000);
|
||||
|
||||
ret = snprintf(buffer + strlen(buffer),
|
||||
4096, "T:%lld.%ld,L:%d map:%d ",
|
||||
4095 - strlen(buffer), "T:%lld.%ld,L:%d map:%d ",
|
||||
cur_time_display, cur_time_mod, level, mappingLevel);
|
||||
|
||||
count++;
|
||||
|
||||
@@ -130,7 +130,7 @@ static void backlight_debug_log(int level, int mappingLevel)
|
||||
cur_time_mod = do_div(cur_time_display, 1000);
|
||||
|
||||
ret = snprintf(buffer + strlen(buffer),
|
||||
4096, "T:%lld.%ld,L:%d map:%d ",
|
||||
4095 - strlen(buffer), "T:%lld.%ld,L:%d map:%d ",
|
||||
cur_time_display, cur_time_mod, level, mappingLevel);
|
||||
|
||||
count++;
|
||||
|
||||
@@ -130,7 +130,7 @@ static void backlight_debug_log(int level, int mappingLevel)
|
||||
cur_time_mod = do_div(cur_time_display, 1000);
|
||||
|
||||
ret = snprintf(buffer + strlen(buffer),
|
||||
4096, "T:%lld.%ld,L:%d map:%d ",
|
||||
4095 - strlen(buffer), "T:%lld.%ld,L:%d map:%d ",
|
||||
cur_time_display, cur_time_mod, level, mappingLevel);
|
||||
|
||||
count++;
|
||||
|
||||
@@ -130,7 +130,7 @@ static void backlight_debug_log(int level, int mappingLevel)
|
||||
cur_time_mod = do_div(cur_time_display, 1000);
|
||||
|
||||
ret = snprintf(buffer + strlen(buffer),
|
||||
4096, "T:%lld.%ld,L:%d map:%d ",
|
||||
4095 - strlen(buffer), "T:%lld.%ld,L:%d map:%d ",
|
||||
cur_time_display, cur_time_mod, level, mappingLevel);
|
||||
|
||||
count++;
|
||||
|
||||
@@ -133,7 +133,7 @@ static void backlight_debug_log(int level, int mappingLevel)
|
||||
cur_time_mod = do_div(cur_time_display, 1000);
|
||||
|
||||
ret = snprintf(buffer + strlen(buffer),
|
||||
4096, "T:%lld.%ld,L:%d map:%d ",
|
||||
4095 - strlen(buffer), "T:%lld.%ld,L:%d map:%d ",
|
||||
cur_time_display, cur_time_mod, level, mappingLevel);
|
||||
|
||||
count++;
|
||||
|
||||
@@ -133,7 +133,7 @@ static void backlight_debug_log(int level, int mappingLevel)
|
||||
cur_time_mod = do_div(cur_time_display, 1000);
|
||||
|
||||
ret = snprintf(buffer + strlen(buffer),
|
||||
4096, "T:%lld.%ld,L:%d map:%d ",
|
||||
4095 - strlen(buffer), "T:%lld.%ld,L:%d map:%d ",
|
||||
cur_time_display, cur_time_mod, level, mappingLevel);
|
||||
|
||||
count++;
|
||||
|
||||
@@ -140,7 +140,7 @@ static void backlight_debug_log(int level, int mappingLevel)
|
||||
cur_time_mod = do_div(cur_time_display, 1000);
|
||||
|
||||
ret = snprintf(buffer + strlen(buffer),
|
||||
4096, "T:%lld.%ld,L:%d map:%d ",
|
||||
4095 - strlen(buffer), "T:%lld.%ld,L:%d map:%d ",
|
||||
cur_time_display, cur_time_mod, level, mappingLevel);
|
||||
|
||||
count++;
|
||||
|
||||
Reference in New Issue
Block a user