drivers: fix random gcc warnings

Signed-off-by: Yaroslav Furman <yaro330@gmail.com>
Signed-off-by: UtsavBalar1231 <utsavbalar1231@gmail.com>

drivers/char/diag/diag_memorydevice.c

@@ -206,7 +206,7 @@ int diag_md_write(int id, unsigned char *buf, int len, int ctx)
 {
 	int i, peripheral, pid = 0;
 	uint8_t found = 0;
-	unsigned long flags, flags_sec;
+	unsigned long flags, flags_sec = 0;
 	struct diag_md_info *ch = NULL;
 	struct diag_md_session_t *session_info = NULL;
 

drivers/gpu/drm/msm/sde/sde_kms.c

@@ -2787,9 +2787,14 @@ retry:
 	}
 
 	crtc_state->active = true;
-	drm_atomic_set_crtc_for_connector(conn_state, enc->crtc);
+	ret = drm_atomic_set_crtc_for_connector(conn_state, enc->crtc);
+	if (ret)
+		goto end;
+
+	ret = drm_atomic_commit(state);
+	if (ret != -EDEADLK)
+		goto end;
 
-	drm_atomic_commit(state);
 end:
 	if (state)
 		drm_atomic_state_put(state);

drivers/hid/hid-qvr.c

@@ -410,7 +410,8 @@ static ssize_t fd_show(struct kobject *kobj,
 	struct kobj_attribute *attr,
 	char *buf)
 {
-	return snprintf(buf, sizeof(buf), "%d\n", qvr_external_sensor.fd);
+	/* sizeof(buf) should be 16 bytes but who knows */
+	return snprintf(buf, 16, "%d\n", qvr_external_sensor.fd);
 }
 
 static ssize_t fd_store(struct kobject *kobj,

drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c

@@ -225,8 +225,6 @@ static void rmnet_map_process_flow_end(struct sk_buff *skb,
 	is_dl_mark_v2 = data_format & RMNET_INGRESS_FORMAT_DL_MARKER_V2;
 	if (is_dl_mark_v2) {
 		pskb_pull(skb, sizeof(struct rmnet_map_header));
-		qcmd = (struct rmnet_map_control_command_header *)
-			rmnet_map_data_ptr(skb);
 		pskb_pull(skb, sizeof(struct rmnet_map_control_command_header));
 	} else {
 		pskb_pull(skb, RMNET_MAP_CMD_SIZE);
@@ -237,9 +235,11 @@ static void rmnet_map_process_flow_end(struct sk_buff *skb,
 	port->stats.dl_trl_last_seq = dltrl->seq_le;
 	port->stats.dl_trl_count++;
 
-	if (is_dl_mark_v2)
+	if (is_dl_mark_v2) {
+		qcmd = (struct rmnet_map_control_command_header *)
+			rmnet_map_data_ptr(skb);
 		rmnet_map_dl_trl_notify_v2(port, dltrl, qcmd);
-	else
+	} else
 		rmnet_map_dl_trl_notify(port, dltrl);
 
 	if (rmnet_perf) {

drivers/platform/msm/qcom-geni-se.c

@@ -1988,8 +1988,10 @@ static int geni_se_probe(struct platform_device *pdev)
 
 		ret = sysfs_create_file(&geni_se_dev->dev->kobj,
 			 &dev_attr_ssc_qup_state.attr);
-		if (ret)
+		if (ret) {
 			dev_err(dev, "Unable to create sysfs file\n");
+			return ret;
+		}
 	}
 
 	device_enable_async_suspend(&pdev->dev);

drivers/power/supply/qcom/smb5-lib.c

@@ -2942,7 +2942,7 @@ static int smblib_therm_charging(struct smb_charger *chg)
 {
 	int thermal_icl_ua = 0;
 	int thermal_fcc_ua = 0;
-	int rc;
+	int rc = 0;
 
 	if (chg->system_temp_level >= MAX_TEMP_LEVEL)
 		return 0;

drivers/spi/spi-geni-qcom.c

@@ -1737,6 +1737,9 @@ static int spi_geni_probe(struct platform_device *pdev)
 	}
 	ret = sysfs_create_file(&(geni_mas->dev->kobj),
 				&dev_attr_spi_slave_state.attr);
+	if (ret)
+		dev_err(&pdev->dev, "Failed to create sysfs\n");
+
 	snprintf(boot_marker, sizeof(boot_marker),
 			"M - DRIVER GENI_SPI_%d Ready", spi->bus_num);
 	place_marker(boot_marker);